-
-
Notifications
You must be signed in to change notification settings - Fork 945
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
website/integrations: add engomo #10538
website/integrations: add engomo #10538
Conversation
Signed-off-by: NiceDevil <[email protected]>
✅ Deploy Preview for authentik-storybook canceled.
|
✅ Deploy Preview for authentik-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10538 +/- ##
==========================================
- Coverage 92.62% 92.50% -0.12%
==========================================
Files 714 719 +5
Lines 35008 35197 +189
==========================================
+ Hits 32425 32558 +133
- Misses 2583 2639 +56
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Hi @nicedevil007 thanks for this contribution! I'll give it a review as soon as possible. It looks like the lint-prettier build check failed... can you run Oh, also, you'll need to add it to the |
Trank you for your quick response, never had to use these commands before, so I guess I have to pull this to linux Shell and run These commands inside the Shell Right? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again @nicedevil007! Lots of nits in my review, let me know if any questions, or if I changed something and mucked it up technically. Once these changes are made, let's merge!
Yes, in your terminal or shell, in the branch run the command Let me know if any questions. We appreciate the contributions! |
Co-authored-by: Tana M Berry <[email protected]> Signed-off-by: NiceDevil <[email protected]>
Co-authored-by: Tana M Berry <[email protected]> Signed-off-by: NiceDevil <[email protected]>
Co-authored-by: Tana M Berry <[email protected]> Signed-off-by: NiceDevil <[email protected]>
Co-authored-by: Tana M Berry <[email protected]> Signed-off-by: NiceDevil <[email protected]>
Co-authored-by: Tana M Berry <[email protected]> Signed-off-by: NiceDevil <[email protected]>
Co-authored-by: Tana M Berry <[email protected]> Signed-off-by: NiceDevil <[email protected]>
Co-authored-by: Tana M Berry <[email protected]> Signed-off-by: NiceDevil <[email protected]>
Co-authored-by: Tana M Berry <[email protected]> Signed-off-by: NiceDevil <[email protected]>
Co-authored-by: Tana M Berry <[email protected]> Signed-off-by: NiceDevil <[email protected]>
Co-authored-by: Tana M Berry <[email protected]> Signed-off-by: NiceDevil <[email protected]>
Co-authored-by: Tana M Berry <[email protected]> Signed-off-by: NiceDevil <[email protected]>
Co-authored-by: Tana M Berry <[email protected]> Signed-off-by: NiceDevil <[email protected]>
Co-authored-by: Tana M Berry <[email protected]> Signed-off-by: NiceDevil <[email protected]>
Co-authored-by: Tana M Berry <[email protected]> Signed-off-by: NiceDevil <[email protected]>
Co-authored-by: Tana M Berry <[email protected]> Signed-off-by: NiceDevil <[email protected]>
Co-authored-by: Tana M Berry <[email protected]> Signed-off-by: NiceDevil <[email protected]>
Signed-off-by: NiceDevil <[email protected]>
ty @4d62 Signed-off-by: NiceDevil <[email protected]>
Co-authored-by: 4d62 <[email protected]> Signed-off-by: NiceDevil <[email protected]>
Co-authored-by: 4d62 <[email protected]> Signed-off-by: NiceDevil <[email protected]>
Co-authored-by: 4d62 <[email protected]> Signed-off-by: NiceDevil <[email protected]>
Signed-off-by: NiceDevil <[email protected]>
Signed-off-by: NiceDevil <[email protected]>
- Name: `SP-engomo` | ||
- Client type: `Public` | ||
- Redirect URIs/Origins (RegEx): `https://engomo.company/auth` and `com.engomo.engomo://callback/` | ||
- Signing Key: `ak.cert` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't know how/what to do with this. Do you mean the name? I can use anything more "standardized" if you want. All my SP's got the SP-
in front of the apps name.
@tanberry does anything else come to mind here? think it's close to ready for merge after these last few things |
Signed-off-by: NiceDevil <[email protected]>
Signed-off-by: NiceDevil <[email protected]>
@nicedevil007 it looks like the lint-prettier check is still failing. Did you want to run the build locally so that you can run If you want to run locally I am here to help you with that process. It will make future PRs much more simple. ;-) |
Co-authored-by: 4d62 <[email protected]> Signed-off-by: NiceDevil <[email protected]>
no I wasn't successfull with this :( so yeah I need help with this. I have linux servers here and I have my windows machine. What prerequisits are needed to run make website (only default build-essentials?) |
git pull https://github.com/myusername/authentik && cd authentik && git switch patch-1 (or your branch)
at project root. notice the Makefile https://github.com/goauthentik/authentik/blob/main/Makefile defined Line 239 in 3f30ccf
|
forget everything about this, and please if you are so kind and help me out doing this prettier stuff i was able to directly pull my patch branch then there was no prettier installed then there was no docusaurus and there was no codespell... sry but that is that much of effort that most of the time I get an error during the setup that it is more time investing than just writing the guide :( |
to be honest, you don't need the entire dev env for prettier. just |
@tanberry dev env is annoying / too overcomplicated to install. especially for people who never contributed to the project. i never even bothered to set it up |
|
This should be added to the documentation for contributors :) |
I do believe a good part of the contributors or new contributors will be able to install things without help but I'll create a pr later today with general install steps and suggestions for installation of dependencies (ex: use nvm to manage node and so on) |
Thats possibly true, sorry that I struggled with it :( But with your help learned it, or at least know what to do for other PRs here. I useally edit the Part I Need in the Web directly on github and make the PR then. Most of the time this was Enough ;) Do I have to do anything Else (still 6 errors?) do get this PR merged? |
the remaining errors look to be from ci with that build permission thing i asked about some time back. should be fine to ignore. now you'll just have to wait on one of the project maintainers to do a last review and merge this |
Oh gosh, @nicedevil007 I am so sorry that I did not see your messages (GitHub nor email) from earlier in the week! I am really sad that I was not faster in replying and helping... thank you @4d62 for your help! Yes, it is a bit more work to fork and clone the authentik repo, and be able to work on it locally. However... I am pretty sure it can be a lot more simple than the route I think you took. And, being able to build locally, and run the linters, results in much higher-quality contributions. I agree with @4d62 that it would be good to have documentation around how to set up your environment for Docs contributions, without trying to build the whole dev environment. The challenge around such docs is that everyone does things differently, but we can, in the docs, stick to the bare basics. When we have those docs in a PR, perhaps you could help review them and add anything from your painful lessons learned? :-) |
Oh at least it wasn't such a pain with the help of @4d62 :) I setup a fresh LXC ubuntu 24.04 and did the commands from above. Had to install curl and git by myself and the NVM stuff from their gitrepo and the markdown file was called different ofc. Thank you very much for the merge :) |
* main: (98 commits) outposts: implement general paginator for list API requests (#10619) website/scripts/docsmg: switch docsmg from using .env to docsmg.env (#10680) web: fix dark theme and theme switch (#10667) website/scripts/docsmg: Updated README (#10678) core: bump goauthentik.io/api/v3 from 3.2024061.8 to 3.2024061.9 (#10669) web: bump @babel/preset-env from 7.24.8 to 7.25.0 in /web in the babel group across 1 directory (#10670) web: bump the rollup group across 1 directory with 3 updates (#10672) web: bump @swc/core from 1.7.2 to 1.7.3 in /web/sfe (#10673) web: bump rollup from 4.19.0 to 4.19.1 in /web/sfe (#10674) website/scripts/docsmg: Bug fixes (#10668) website/integrations: add engomo (#10538) ci: fix expression for outpost GHA caching website/docs: fix typos in passwordless setup guide (#10661) website/docs: fix missing mermaid theme (#10665) website/scripts/docsmg: Add install script and readme draft (#10659) web: bump API Client version (#10653) website/scripts: Add docsmg migration tool (#10658) core: add primitives for source property mappings (#10651) root: make pyrad a standard dependency (#10649) core: remove deprecated sentry-sdk method usage (#10648) ...
Details
This is my guide to get authentik up and running with Engomo. This application is a low code platform to create apps on android/iOS and iPadOS. I was able to run this appication after 10 minutes setup time on authentik.
This was done (by accident) because we struggled with an other IDP from an other manufacturer. I just wanted to see if authentik is "quick & dirty" to setup :)
I hope the formatting is done "ok", I used my old PR for the documentation on the fortigate-admin guide.
Checklist
ak test authentik/
)If applicable
make website
)