providers/proxy: fix Traefik label generation for v3 #10411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for authentik-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for authentik-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
DriftDevil
changed the title
BeryJu
approved these changes
Jul 9, 2024
BeryJu
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10411 +/- ##
==========================================
+ Coverage 92.62% 92.64% +0.01%
==========================================
Files 714 714
Lines 35012 35014 +2
==========================================
+ Hits 32431 32438 +7
+ Misses 2581 2576 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Broke up the line so code line is not too long Signed-off-by: DriftDevil <[email protected]>
It does yes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9786
Details
When deploying a proxy outpost, labels are added automatically which add the outpost to Traefik. For each single-forward provider a Host() label has to be used. Authentik generates these as Host(, , ...) which is not possible anymore since Traefik v3.0. This leads to an invalid deployment of the outpost.
This PR remedies that and created labels that separate the Host. i.e. (Host() || Host())