Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: return relative app launch URL to improve app list performance #10368

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

BeryJu
Copy link
Member

@BeryJu BeryJu commented Jul 4, 2024

Details

REPLACE ME


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

@BeryJu BeryJu requested review from a team as code owners July 4, 2024 10:59
Copy link

netlify bot commented Jul 4, 2024

Deploy Preview for authentik-docs ready!

Name Link
🔨 Latest commit 36e4184
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/668680806734ce0008359dce
😎 Deploy Preview https://deploy-preview-10368--authentik-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jul 4, 2024

Deploy Preview for authentik-storybook ready!

Name Link
🔨 Latest commit 36e4184
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/66868080b6e847000804de61
😎 Deploy Preview https://deploy-preview-10368--authentik-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Jul 4, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 51.00%. Comparing base (2fc0c6e) to head (36e4184).
Report is 10 commits behind head on main.

Files Patch % Lines
authentik/core/api/applications.py 33.33% 4 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (2fc0c6e) and HEAD (36e4184). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (2fc0c6e) HEAD (36e4184)
unit 2 0
Additional details and impacted files
@@             Coverage Diff             @@
##             main   #10368       +/-   ##
===========================================
- Coverage   92.62%   51.00%   -41.62%     
===========================================
  Files         713      711        -2     
  Lines       34999    34739      -260     
===========================================
- Hits        32418    17720    -14698     
- Misses       2581    17019    +14438     
Flag Coverage Δ
e2e 49.63% <33.33%> (+0.07%) ⬆️
integration 25.38% <33.33%> (+<0.01%) ⬆️
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BeryJu BeryJu marked this pull request as draft July 4, 2024 11:15
Copy link
Contributor

@kensternberg-authentik kensternberg-authentik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see nothing obviously wrong with the update to LibraryApplication. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants