web: provide 'show password' button #10337

kensternberg-authentik · 2024-07-02T15:35:10Z

Details

web: provide show password on login page

What

Provide a show password icon, text, and button for the password field both in the IdentificationStage and the PasswordStage. Essentially the same code for both, although the id of the password field is unique to each.

This code is derived from the Patternfly 4 example. The HTML example is broken, but the React one was
straightforward to read and port.

At Jens's suggestion, I have added a field to the PasswordStage model, allow_show_password, and threaded
its availability through both the challenge and admin configuration details. It can now be on a
per-password-stage basis. Currently false by default.

Why

Requested by users. Seems to be a common thing anyway.

Local tests pass (ak test authentik/)
The code has been formatted (make lint-fix)
The API schema has been updated (make gen-build)
The code has been formatted (make web)
The documentation has been updated

Getting ESBuild, Lit, and Storybook to all agree on how to read and parse stylesheets is a serious pain. This fix better identifies the value types (instances) being passed from various sources in the repo to the three *different* kinds of style processors we're using (the native one, the polyfill one, and whatever the heck Storybook does internally). Falling back to using older CSS instantiating techniques one era at a time seems to do the trick. It's ugly, but in the face of the aggressive styling we use to avoid Flashes of Unstyled Content (FLoUC), it's the logic with which we're left. In standard mode, the following warning appears on the console when running a Flow: ``` Autofocus processing was blocked because a document already has a focused element. ``` In compatibility mode, the following **error** appears on the console when running a Flow: ``` crawler-inject.js:1106 Uncaught TypeError: Failed to execute 'observe' on 'MutationObserver': parameter 1 is not of type 'Node'. at initDomMutationObservers (crawler-inject.js:1106:18) at crawler-inject.js:1114:24 at Array.forEach (<anonymous>) at initDomMutationObservers (crawler-inject.js:1114:10) at crawler-inject.js:1549:1 initDomMutationObservers @ crawler-inject.js:1106 (anonymous) @ crawler-inject.js:1114 initDomMutationObservers @ crawler-inject.js:1114 (anonymous) @ crawler-inject.js:1549 ``` Despite this error, nothing seems to be broken and flows work as anticipated.

* main: tenants: really ensure default tenant cannot be deleted (#8875) core: bump github.com/go-openapi/runtime from 0.27.2 to 0.28.0 (#8867) core: bump pytest from 8.0.2 to 8.1.1 (#8868) core: bump github.com/go-openapi/strfmt from 0.22.2 to 0.23.0 (#8869) core: bump bandit from 1.7.7 to 1.7.8 (#8870) core: bump packaging from 23.2 to 24.0 (#8871) core: bump ruff from 0.3.1 to 0.3.2 (#8873) web: bump the wdio group in /tests/wdio with 3 updates (#8865) core: bump requests-oauthlib from 1.3.1 to 1.4.0 (#8866) core: bump uvicorn from 0.27.1 to 0.28.0 (#8872) core: bump django-filter from 23.5 to 24.1 (#8874)

* main: web: fix esbuild issue with style sheets (#8856)

* main: web: upgrade to lit 3 (#8781)

* main: Update _envoy_istio.md (#8888) website/docs: new landing page for Providers (#8879) web: bump the sentry group in /web with 1 update (#8881) web: bump chromedriver from 122.0.4 to 122.0.5 in /tests/wdio (#8884) web: bump the eslint group in /tests/wdio with 2 updates (#8883) web: bump the eslint group in /web with 2 updates (#8885) website: bump @types/react from 18.2.64 to 18.2.65 in /website (#8886)

* main: api: capabilities: properly set can_save_media when s3 is enabled (#8896) web: bump the rollup group in /web with 3 updates (#8891) core: bump pydantic from 2.6.3 to 2.6.4 (#8892) core: bump twilio from 9.0.0 to 9.0.1 (#8893)

* main: web: bump chromedriver from 122.0.5 to 122.0.6 in /tests/wdio (#8902) web: bump vite-tsconfig-paths from 4.3.1 to 4.3.2 in /web (#8903) core: bump google.golang.org/protobuf from 1.32.0 to 1.33.0 (#8901) web: provide InstallID on EnterpriseListPage (#8898)

* main: web: clean up and remove redundant alias '@goauthentik/app' (#8889) web/admin: fix markdown table rendering (#8908)

* main: (31 commits) root: support redis username (#8935) core: bump black from 24.2.0 to 24.3.0 (#8945) web: bump the wdio group in /tests/wdio with 2 updates (#8939) web: bump the sentry group in /web with 1 update (#8941) website: bump postcss from 8.4.35 to 8.4.36 in /website (#8940) core: bump twilio from 9.0.1 to 9.0.2 (#8942) core: bump ruff from 0.3.2 to 0.3.3 (#8943) events: discard notification if user has empty email (#8938) ci: always run ci-main on branch pushes (#8950) core: bump goauthentik.io/api/v3 from 3.2024022.2 to 3.2024022.3 (#8946) website/docs: add new name "Microsft Entra ID" for Azure AD (#8930) outposts: Enhance config options for k8s outposts (#7363) website/docs: add link to CRUD docs (#8925) web: bump API Client version (#8927) outpost: improved set secret answers for flow execution (#8013) stages/user_write: ensure user data is json-serializable (#8926) website/docs: update example ldapsearch commands (#8906) admin: Handle latest version unknown in admin dashboard (#8858) core: bump coverage from 7.4.3 to 7.4.4 (#8917) core: bump urllib3 from 1.26.18 to 2.2.1 (#8918) ...

* main: outposts/proxy: Fix invalid redirect on external hosts containing path components (#8915) core: cache user application list under policies (#8895) web: bump the eslint group in /web with 2 updates (#8959) web: bump core-js from 3.36.0 to 3.36.1 in /web (#8960) website: bump @types/react from 18.2.66 to 18.2.67 in /website (#8962) web: bump the eslint group in /tests/wdio with 2 updates (#8963)

* main: web: improve build speeds even moar!!!!!! (#8954)

* main: website/docs: config: remove options moved to tenants (#8976) web: bump @types/grecaptcha from 3.0.8 to 3.0.9 in /web (#8971) web: bump country-flag-icons from 1.5.9 to 1.5.10 in /web (#8970) web: bump the babel group in /web with 7 updates (#8969) core: bump uvicorn from 0.28.0 to 0.28.1 (#8968) website: bump postcss from 8.4.36 to 8.4.37 in /website (#8967) internal: cleanup static file serving setup code (#8965) website/integrations: portainer: match portainer settings order (#8974)

* main: website/docs: add example policy to enforce unique email address (#8955) web/admin: remove enterprise preview banner (#8991) core: bump uvicorn from 0.28.1 to 0.29.0 (#8980) core: bump sentry-sdk from 1.42.0 to 1.43.0 (#8981) web: bump the babel group in /web with 3 updates (#8983) web: bump typescript from 5.4.2 to 5.4.3 in /web (#8984) web: bump typescript from 5.4.2 to 5.4.3 in /tests/wdio (#8986) web: bump chromedriver from 122.0.6 to 123.0.0 in /tests/wdio (#8987) website: bump typescript from 5.4.2 to 5.4.3 in /website (#8989) core: bump importlib-metadata from 7.0.2 to 7.1.0 (#8982) web: bump the wdio group in /tests/wdio with 3 updates (#8985) website: bump postcss from 8.4.37 to 8.4.38 in /website (#8988)

* main: web: bump API Client version (#9021) sources/ldap: add ability to disable password write on login (#8377) web: bump API Client version (#9020) lifecycle: migrate: ensure template schema exists before migrating (#8952) website/integrations: Update nextcloud Admin Group Expression (#7314) web/flow: general ux improvements (#8558) website: bump @types/react from 18.2.67 to 18.2.69 in /website (#9016) core: bump requests-oauthlib from 1.4.0 to 2.0.0 (#9018) web: bump the sentry group in /web with 2 updates (#9017) web/admin: small fixes (#9002) website: bump webpack-dev-middleware from 5.3.3 to 5.3.4 in /website (#9001) core: bump ruff from 0.3.3 to 0.3.4 (#8998) website/docs: Upgrade nginx reverse porxy config (#8947) website/docs: improve flow inspector docs (#8993) website/deverlop-docs website/integrations: add links to integrations template (#8995)

* main: web: bump API Client version (#9035) website/docs: maintenance, re-add system settings (#9026) core: bump duo-client from 5.2.0 to 5.3.0 (#9029) website: bump express from 4.18.2 to 4.19.2 in /website (#9027) web: bump express from 4.18.3 to 4.19.2 in /web (#9028) web: bump the eslint group in /web with 2 updates (#9030) core: bump goauthentik.io/api/v3 from 3.2024022.3 to 3.2024022.5 (#9031) website: bump @types/react from 18.2.69 to 18.2.70 in /website (#9032) web: bump the eslint group in /tests/wdio with 2 updates (#9033) web: bump katex from 0.16.9 to 0.16.10 in /web (#9025) translate: Updates for file locale/en/LC_MESSAGES/django.po in fr (#9023) website/docs: include OS-specific docker-compose install instructions + minor fixes (#8975)

* main: web: a few minor bugfixes and lintfixes (#9044) website/integrations: add documentation for OIDC setup with Xen Orchestra (#9000) website: bump @types/react from 18.2.70 to 18.2.72 in /website (#9041) core: bump goauthentik.io/api/v3 from 3.2024022.5 to 3.2024022.6 (#9042) web: fix markdown rendering bug for alerts (#9037)

* main: (23 commits) providers/oauth2: fix interactive device flow (#9076) website/docs: fix transports example (#9074) events: fix log_capture (#9075) web: bump the sentry group in /web with 2 updates (#9065) core: bump goauthentik.io/api/v3 from 3.2024022.6 to 3.2024022.7 (#9064) web: bump @codemirror/lang-python from 6.1.4 to 6.1.5 in /web (#9068) web: bump the eslint group in /web with 1 update (#9066) web: bump glob from 10.3.10 to 10.3.12 in /web (#9069) web: bump the rollup group in /web with 3 updates (#9067) web: bump the eslint group in /tests/wdio with 1 update (#9071) core: bump webauthn from 2.0.0 to 2.1.0 (#9070) core: bump sentry-sdk from 1.43.0 to 1.44.0 (#9073) core: bump requests-mock from 1.12.0 to 1.12.1 (#9072) web: bump API Client version (#9061) events: rework log messages returned from API and their rendering (#8770) website/docs: update airgapped config (#9049) website: bump @types/react from 18.2.72 to 18.2.73 in /website (#9052) web: bump the rollup group in /web with 3 updates (#9053) core: bump django-filter from 24.1 to 24.2 (#9055) core: bump requests-mock from 1.11.0 to 1.12.0 (#9056) ...

* main: web: move context controllers into reactive controller plugins (#8996) web: maintenance: split tsconfig into “base” and “build” variants. (#9036) web: consistent style declarations internally (#9077)

* main: web: bump @patternfly/elements from 2.4.0 to 3.0.0 in /web (#9089) web: bump ts-pattern from 5.0.8 to 5.1.0 in /web (#9090) website: bump the docusaurus group in /website with 9 updates (#9087) web/admin: allow custom sorting for bound* tables (#9080)

* main: root: fix missing imports after #9081 (#9106) root: move database calls from ready() to dedicated startup signal (#9081) web: fix console log leftover (#9096) web: bump the eslint group in /web with 2 updates (#9098) core: bump twilio from 9.0.2 to 9.0.3 (#9103) web: bump the eslint group in /tests/wdio with 2 updates (#9099) core: bump drf-spectacular from 0.27.1 to 0.27.2 (#9100) core: bump django-model-utils from 4.4.0 to 4.5.0 (#9101) core: bump ruff from 0.3.4 to 0.3.5 (#9102) website/docs: update notes on SECRET_KEY (#9091) web: fix broken locale compile (#9095) website/integrations: add outline knowledge base (#8786) website/docs: fix typo (#9082) website/docs: email stage: fix example translation error (#9048)

* main: (22 commits) blueprints: fix default username field in user-settings flow (#9136) website/docs: add procedural docs for RAC (#9006) web: bump API Client version (#9133) ci: fix python client generator (#9134) root: generate python client (#9107) web: Bump vite from 5.1.4 to 5.2.8 in /web (#9120) core, web: update translations (#9124) core: Bump golang from 1.22.1-bookworm to 1.22.2-bookworm (#9125) web: Bump the babel group in /web with 2 updates (#9126) web: Bump the eslint group in /web with 1 update (#9127) web: Bump the eslint group in /tests/wdio with 1 update (#9129) core: Bump sentry-sdk from 1.44.0 to 1.44.1 (#9130) core: Bump channels from 4.0.0 to 4.1.0 (#9131) core: Bump django from 5.0.3 to 5.0.4 (#9132) web: Bump the rollup group in /web with 3 updates (#9128) translate: Updates for file locale/en/LC_MESSAGES/django.po in zh-Hans (#9110) translate: Updates for file locale/en/LC_MESSAGES/django.po in zh_CN (#9109) translate: Updates for file web/xliff/en.xlf in zh_CN (#9111) translate: Updates for file web/xliff/en.xlf in zh-Hans (#9112) web: Bump @fortawesome/fontawesome-free from 6.5.1 to 6.5.2 in /web (#9116) ...

* main: (25 commits) root: fix readme (#9178) enterprise: fix audit middleware import (#9177) web: bump @spotlightjs/spotlight from 1.2.16 to 1.2.17 in /web in the sentry group (#9162) web: bump API Client version (#9174) stages/authenticator_webauthn: add MDS support (#9114) website/integrations: Update Nextcloud OIDC secret size limitation (#9139) translate: Updates for file web/xliff/en.xlf in zh_CN (#9170) translate: Updates for file web/xliff/en.xlf in zh-Hans (#9171) web: bump the rollup group in /web with 3 updates (#9164) web: bump @codemirror/legacy-modes from 6.3.3 to 6.4.0 in /web (#9166) web: bump ts-pattern from 5.1.0 to 5.1.1 in /web (#9167) core: bump github.com/go-ldap/ldap/v3 from 3.4.6 to 3.4.7 (#9168) core, web: update translations (#9156) root: fix redis username in lifecycle (#9158) web: ak-checkbox-group for short, static, multi-select events (#9138) root: fix startup (#9151) core: Bump golang.org/x/oauth2 from 0.18.0 to 0.19.0 (#9146) core: Bump twilio from 9.0.3 to 9.0.4 (#9143) web: Bump country-flag-icons from 1.5.10 to 1.5.11 in /web (#9144) web: Bump typescript from 5.4.3 to 5.4.4 in /web (#9145) ...

* main: web/admin: fix SAML Provider preview (#9192) core, web: update translations (#9183) web: bump chromedriver from 123.0.1 to 123.0.2 in /tests/wdio (#9188) website: bump @types/react from 18.2.74 to 18.2.75 in /website (#9185) website/docs: update Postgresql username (#9190) core: bump maxmind/geoipupdate from v6.1 to v7.0 (#9186) events: add context manager to ignore/modify audit events being written (#9181) web: fix application library list display length and capability (#9094)

* main: translate: Updates for file locale/en/LC_MESSAGES/django.po in zh_CN (#9194) translate: Updates for file locale/en/LC_MESSAGES/django.po in zh-Hans (#9197) translate: Updates for file web/xliff/en.xlf in zh_CN (#9196) translate: Updates for file web/xliff/en.xlf in zh-Hans (#9198) web: preserve selected list when provider updates (#9200) web: bump API Client version (#9195) sources/oauth: make URLs not required, only check when no OIDC URLs are defined (#9182)

* main: website/docs: add note for flow compatibility mode (#9204)

* main: website/docs: add more info and links about enforciing unique email addresses (#9154) core: bump goauthentik.io/api/v3 from 3.2024022.7 to 3.2024022.8 (#9215) web: bump API Client version (#9214) stages/authenticator_validate: add ability to limit webauthn device types (#9180) web: bump API Client version (#9213) core: add user settable token durations (#7410) core, web: update translations (#9205) web: bump typescript from 5.4.4 to 5.4.5 in /tests/wdio (#9206) web: bump chromedriver from 123.0.2 to 123.0.3 in /tests/wdio (#9207) core: bump sentry-sdk from 1.44.1 to 1.45.0 (#9208) web: bump typescript from 5.4.4 to 5.4.5 in /web (#9209) website: bump typescript from 5.4.4 to 5.4.5 in /website (#9210) core: bump python from 3.12.2-slim-bookworm to 3.12.3-slim-bookworm (#9211)

* main: (21 commits) web: manage stacked modals with a stack (#9193) website/docs: ensure yaml code blocks have language tags (#9240) blueprints: only create default brand if no other default brand exists (#9222) web: bump API Client version (#9239) website/integrations: portainer: Fix Redirect URL mismatch (#9226) api: fix authentication schema (#9238) translate: Updates for file web/xliff/en.xlf in zh_CN (#9229) translate: Updates for file web/xliff/en.xlf in zh-Hans (#9230) translate: Updates for file locale/en/LC_MESSAGES/django.po in zh_CN (#9228) translate: Updates for file locale/en/LC_MESSAGES/django.po in zh-Hans (#9231) core: bump pydantic from 2.6.4 to 2.7.0 (#9232) core: bump ruff from 0.3.5 to 0.3.7 (#9233) web: bump @sentry/browser from 7.109.0 to 7.110.0 in /web in the sentry group (#9234) website: bump @types/react from 18.2.75 to 18.2.77 in /website (#9236) core, web: update translations (#9225) website/integrations: add pfSense search scope (#9221) core: bump idna from 3.6 to 3.7 (#9224) website/docs: add websocket support to nginx snippets (#9220) internal: add tests to go flow executor (#9219) website/integrations: nextcloud: add tip to solve hashed groups configuring OAuth2 (#9153) ...

* main: (34 commits) web: bump API Client version (#9299) core: fix api schema for users and groups (#9298) providers/oauth2: fix refresh_token grant returning incorrect id_token (#9275) web: bump @sentry/browser from 7.110.0 to 7.110.1 in /web in the sentry group (#9278) core, web: update translations (#9277) web: bump the rollup group in /web with 3 updates (#9280) web: bump lit from 3.1.2 to 3.1.3 in /web (#9282) web: bump @lit/context from 1.1.0 to 1.1.1 in /web (#9281) website: bump @types/react from 18.2.78 to 18.2.79 in /website (#9286) core: bump goauthentik.io/api/v3 from 3.2024022.10 to 3.2024022.11 (#9285) core: bump sqlparse from 0.4.4 to 0.5.0 (#9276) lifecycle: gunicorn: fix app preload (#9274) events: add indexes (#9272) web/flows: fix passwordless hidden without input (#9273) root: fix geoipupdate arguments (#9271) website/docs: cleanup more (#9249) web: bump API Client version (#9270) sources: add SCIM source (#3051) core: delegated group member management (#9254) web: bump API Client version (#9269) ...

* main: (23 commits) web: bump API Client version (#9316) release: 2024.2.3 website/docs: 2024.2.3 release notes (#9313) web/admin: fix log viewer empty state (#9315) website/docs: fix formatting for stage changes (#9314) core: bump github.com/go-ldap/ldap/v3 from 3.4.7 to 3.4.8 (#9310) core: bump goauthentik.io/api/v3 from 3.2024022.11 to 3.2024022.12 (#9311) web: bump core-js from 3.36.1 to 3.37.0 in /web (#9309) core: bump gunicorn from 21.2.0 to 22.0.0 (#9308) core, web: update translations (#9307) website/docs: system settings: add default token duration and length (#9306) web/flows: update flow background (#9305) web: fix locale loading being skipped (#9301) translate: Updates for file web/xliff/en.xlf in fr (#9304) translate: Updates for file locale/en/LC_MESSAGES/django.po in fr (#9303) core: replace authentik_signals_ignored_fields with audit_ignore (#9291) web/flow: fix form input rendering issue (#9297) events: fix incorrect user logged when using API token authentication (#9302) translate: Updates for file locale/en/LC_MESSAGES/django.po in zh_CN (#9293) translate: Updates for file locale/en/LC_MESSAGES/django.po in zh-Hans (#9295) ...

* main: stages/prompt: fix username field throwing error with existing user (#9342) root: expose session storage configuration (#9337) website/integrations: fix typo (#9340) root: fix go.mod for codeql checking (#9338) root: make redis settings more consistent (#9335) web/admin: fix error in admin interface due to un-hydrated context (#9336) web: bump API Client version (#9334) stages/authenticator_webauthn: fix attestation value (#9333) website/docs: fix SECRET_KEY length (#9328) website/docs: fix email template formatting (#9330) core, web: update translations (#9323) web: bump @patternfly/elements from 3.0.0 to 3.0.1 in /web (#9324) core: bump celery from 5.3.6 to 5.4.0 (#9325) core: bump goauthentik.io/api/v3 from 3.2024022.12 to 3.2024023.1 (#9327) sources/scim: service account should be internal (#9321) web: bump the storybook group in /web with 8 updates (#9266) sources/scim: cleanup service account when source is deleted (#9319)

* main: web: fix package lock out of sync (#10314) core, web: update translations (#10294) stages/authenticator_webauthn: Update FIDO MDS3 & Passkey aaguid blobs (#10306) web: bump the esbuild group in /web with 2 updates (#10308) web: bump esbuild from 0.21.5 to 0.22.0 in /web (#10309) website: bump postcss from 8.4.38 to 8.4.39 in /website (#10310) core: bump goauthentik.io/api/v3 from 3.2024060.1 to 3.2024060.2 (#10311) core: bump psycopg from 3.1.19 to 3.2.1 (#10313) stages/user_login: fix ?next parameter not carried through broken session binding (#10301)

* main: web: provide default endpoint api configuration (#10319) provider/scim: Fix exception handling for missing ServiceProviderConfig (#10322) translate: Updates for file web/xliff/en.xlf in fr (#10334) translate: Updates for file web/xliff/en.xlf in zh-Hans (#10293) web: bump esbuild from 0.22.0 to 0.23.0 in /web (#10331) web: fixed missed internationalized strings (#10323) core, web: update translations (#10324) website: bump typescript from 5.5.2 to 5.5.3 in /website (#10326) core: bump pydantic from 2.7.4 to 2.8.0 (#10325) web: bump typescript from 5.5.2 to 5.5.3 in /tests/wdio (#10327) web: bump the esbuild group in /web with 2 updates (#10330) web: bump typescript from 5.5.2 to 5.5.3 in /web (#10332) web: set noopener and noreferrer on all external links (#10304) core: remove transitionary old JS urls (#10317) web/flows: remove background image link (#10318) translate: Updates for file web/xliff/en.xlf in zh_CN (#10315)

Provide a `show password` icon, text, and button for the password field both in the IdentificationStage and the PasswordStage. Essentially the same code for both, although the id of the password field is unique to each. Requested by Cloudflare. Seems to be a common thing anyway. Should it be an administrative option that this facility is available? From where should I derive that information? I suspect the answer is "a site attribute," but I'd like to get confirmation.

netlify · 2024-07-02T15:35:25Z

✅ Deploy Preview for authentik-storybook ready!

Name	Link
🔨 Latest commit	`a09afd3`
🔍 Latest deploy log	https://app.netlify.com/sites/authentik-storybook/deploys/6695c4d459870800083f7862
😎 Deploy Preview	https://deploy-preview-10337--authentik-storybook.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify · 2024-07-02T15:35:31Z

✅ Deploy Preview for authentik-docs ready!

Name	Link
🔨 Latest commit	`a09afd3`
🔍 Latest deploy log	https://app.netlify.com/sites/authentik-docs/deploys/6695c4d4d7b2470008240d0f
😎 Deploy Preview	https://deploy-preview-10337--authentik-docs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

BeryJu

🎉 I wonder if we can dedupe more code between password stage and identification stage with password enabled

codecov · 2024-07-02T15:44:22Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.62%. Comparing base (d0a4590) to head (a09afd3).

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #10337   +/-   ##
=======================================
  Coverage   92.61%   92.62%           
=======================================
  Files         714      714           
  Lines       35005    35008    +3     
=======================================
+ Hits        32421    32425    +4     
+ Misses       2584     2583    -1

Flag	Coverage Δ
e2e	`49.63% <100.00%> (+0.03%)`	⬆️
integration	`25.37% <80.00%> (+<0.01%)`	⬆️
unit	`90.11% <100.00%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-actions · 2024-07-02T16:09:53Z

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-ghcr.io/goauthentik/dev-server:gh-a09afd3bd01487ace9b5b12e1c49f1af09f36369
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

For arm64, use these values:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-ghcr.io/goauthentik/dev-server:gh-a09afd3bd01487ace9b5b12e1c49f1af09f36369-arm64
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-ghcr.io/goauthentik/dev-server:gh-a09afd3bd01487ace9b5b12e1c49f1af09f36369

For arm64, use these values:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-ghcr.io/goauthentik/dev-server:gh-a09afd3bd01487ace9b5b12e1c49f1af09f36369-arm64

Afterwards, run the upgrade commands from the latest release notes.

During testing, the buttons did not change as expected. We are using pure DOM state to control the look of the button, and avoiding using `.requestUpdate()` to avoid losing customer input, so depending upon Lit to re-render just the button was an error. This commit goes old-school and updates the button's label and icon using standard DOM features, although we do lean into Lit-html`s `render()` function to create the DOM component for the icon.

Provide a `show password` icon, text, and button for the password field both in the IdentificationStage and the PasswordStage. Essentially the same code for both, although the id of the password field is unique to each. Provide a configuration detail server-side to allow administrator to enable or disable the 'show password' feature. Off by default. Requested by Cloudflare. Seems to be a common thing anyway. Making it configurable wasn't in Cloudfare's request, but it seemed logical to add.

…continues.

kensternberg-authentik · 2024-07-02T22:18:24Z

authentik/stages/identification/stage.py

@@ -199,6 +200,8 @@ def get_challenge(self) -> Challenge:
                "primary_action": self.get_primary_action(),
                "user_fields": current_stage.user_fields,
                "password_fields": bool(current_stage.password_stage),
+                "allow_show_password": bool(current_stage.password_stage)
+                and current_stage.password_stage.allow_show_password,


I wouldn't normally argue with black but, man, that is ugly.

kensternberg-authentik · 2024-07-02T22:21:08Z

web/src/flow/stages/identification/IdentificationStage.ts

+            PFForm,
+            PFFormControl,
+            PFTitle,
+            PFButton,
            /* login page's icons */


Although this is in response to my adding PFInputGroup, I moved this comment out of the CSS; there's no reason to ship it with what the user sees.

kensternberg-authentik · 2024-07-02T22:22:07Z

authentik/stages/identification/models.py

@@ -38,10 +38,11 @@ class IdentificationStage(Stage):
        help_text=_(
            (
                "When set, shows a password field, instead of showing the "
-                "password field as seaprate step."
+                "password field as separate step."


Genuinely surprised codespell didn't throw a fit here.

…nent Provides a `show password` field, but as a LightDOM-oriented web component. This form of input[type="password"] is for flows only, as it has a number of specializations for understanding a flow's validating round-trip, possible error messages within the challenge, and is left within the LightDOM both to support compatibility issues and to avoid using `elementInterals`, which is a DOM feature not supported by some older browsers. Avoids having to maintain two different instances of the same logic, both for permitting 'show password', and for handling it.

* main: website/docs: add links and tweaks to existing docs on flow executors (#10340) sources/saml: fix pickle error, add saml auth tests (#10348) web: bump API Client version (#10351) core: applications api: add option to only list apps with launch url (#10336) website/integrations: minio: configure openid on web (#9874) website/docs: integrations: gitea: specify callback url (#10180) providers/saml: fix metadata import error handling (#10349) core, web: update translations (#10341) core: bump twilio from 9.2.2 to 9.2.3 (#10343) core: bump google-api-python-client from 2.135.0 to 2.136.0 (#10344) translate: Updates for file web/xliff/en.xlf in zh-Hans (#10339) translate: Updates for file web/xliff/en.xlf in zh_CN (#10338) web: bump the storybook group in /web with 7 updates (#10263) web: lintpicking (#10212)

* main: docs/troubleshooting: upgrade docker: prompt user to ensure pg_dump'd file has data (#10353)

With lit-analyzer in the mix and functional, we're seeing new complaints about inconsistent typing in lit objects, and this was one of them.

* main: web: enhance search select with portal, overflow, and keyboard controls (#9517) Create readme.md (#10507)

* web: fix esbuild issue with style sheets Getting ESBuild, Lit, and Storybook to all agree on how to read and parse stylesheets is a serious pain. This fix better identifies the value types (instances) being passed from various sources in the repo to the three *different* kinds of style processors we're using (the native one, the polyfill one, and whatever the heck Storybook does internally). Falling back to using older CSS instantiating techniques one era at a time seems to do the trick. It's ugly, but in the face of the aggressive styling we use to avoid Flashes of Unstyled Content (FLoUC), it's the logic with which we're left. In standard mode, the following warning appears on the console when running a Flow: ``` Autofocus processing was blocked because a document already has a focused element. ``` In compatibility mode, the following **error** appears on the console when running a Flow: ``` crawler-inject.js:1106 Uncaught TypeError: Failed to execute 'observe' on 'MutationObserver': parameter 1 is not of type 'Node'. at initDomMutationObservers (crawler-inject.js:1106:18) at crawler-inject.js:1114:24 at Array.forEach (<anonymous>) at initDomMutationObservers (crawler-inject.js:1114:10) at crawler-inject.js:1549:1 initDomMutationObservers @ crawler-inject.js:1106 (anonymous) @ crawler-inject.js:1114 initDomMutationObservers @ crawler-inject.js:1114 (anonymous) @ crawler-inject.js:1549 ``` Despite this error, nothing seems to be broken and flows work as anticipated. * web: provide `show password` on login page Provide a `show password` icon, text, and button for the password field both in the IdentificationStage and the PasswordStage. Essentially the same code for both, although the id of the password field is unique to each. Requested by Cloudflare. Seems to be a common thing anyway. Should it be an administrative option that this facility is available? From where should I derive that information? I suspect the answer is "a site attribute," but I'd like to get confirmation. * web: comment doesn't need to be exposed. It's sufficient where it is . * web: fix button rendering issues During testing, the buttons did not change as expected. We are using pure DOM state to control the look of the button, and avoiding using `.requestUpdate()` to avoid losing customer input, so depending upon Lit to re-render just the button was an error. This commit goes old-school and updates the button's label and icon using standard DOM features, although we do lean into Lit-html`s `render()` function to create the DOM component for the icon. * web: provide `show password` on login page Provide a `show password` icon, text, and button for the password field both in the IdentificationStage and the PasswordStage. Essentially the same code for both, although the id of the password field is unique to each. Provide a configuration detail server-side to allow administrator to enable or disable the 'show password' feature. Off by default. Requested by Cloudflare. Seems to be a common thing anyway. Making it configurable wasn't in Cloudfare's request, but it seemed logical to add. * ensure the tests pass; quibbling over the wording of the admin field continues. * Removed some manually identified fluff. * web: break out `show password`-enabled input field into its own component Provides a `show password` field, but as a LightDOM-oriented web component. This form of input[type="password"] is for flows only, as it has a number of specializations for understanding a flow's validating round-trip, possible error messages within the challenge, and is left within the LightDOM both to support compatibility issues and to avoid using `elementInterals`, which is a DOM feature not supported by some older browsers. Avoids having to maintain two different instances of the same logic, both for permitting 'show password', and for handling it. * web: update PasswordStageForm according to lit-analyzer With lit-analyzer in the mix and functional, we're seeing new complaints about inconsistent typing in lit objects, and this was one of them. * Another lit-analyze error found.

kensternberg-authentik added 30 commits March 8, 2024 14:15

Merge branch 'main' into dev

e505f27

* main: web: fix esbuild issue with style sheets (#8856)

Merge branch 'main' into dev

5090621

* main: web: upgrade to lit 3 (#8781)

Merge branch 'main' into dev

2d0117d

* main: api: capabilities: properly set can_save_media when s3 is enabled (#8896) web: bump the rollup group in /web with 3 updates (#8891) core: bump pydantic from 2.6.3 to 2.6.4 (#8892) core: bump twilio from 9.0.0 to 9.0.1 (#8893)

Merge branch 'main' into dev

8b4e036

* main: web: clean up and remove redundant alias '@goauthentik/app' (#8889) web/admin: fix markdown table rendering (#8908)

Merge branch 'main' into dev

30beca9

* main: web: improve build speeds even moar!!!!!! (#8954)

Merge branch 'main' into dev

7123b2c

* main: web: move context controllers into reactive controller plugins (#8996) web: maintenance: split tsconfig into “base” and “build” variants. (#9036) web: consistent style declarations internally (#9077)

Merge branch 'main' into dev

23665d1

* main: website/docs: add note for flow compatibility mode (#9204)

kensternberg-authentik added 3 commits July 1, 2024 07:43

web: comment doesn't need to be exposed. It's sufficient where it is .

5a340a5

kensternberg-authentik marked this pull request as ready for review July 2, 2024 15:38

kensternberg-authentik requested a review from a team as a code owner July 2, 2024 15:38

BeryJu approved these changes Jul 2, 2024

View reviewed changes

kensternberg-authentik added 2 commits July 2, 2024 09:37

kensternberg-authentik requested a review from a team as a code owner July 2, 2024 21:46

kensternberg-authentik added 2 commits July 2, 2024 15:16

ensure the tests pass; quibbling over the wording of the admin field …

587ec68

…continues.

Removed some manually identified fluff.

0b05d43

kensternberg-authentik commented Jul 2, 2024

View reviewed changes

kensternberg-authentik requested review from a team and BeryJu July 3, 2024 18:02

kensternberg-authentik added 6 commits July 3, 2024 13:12

Merge branch 'main' into web/cf/provide-show-password-button

3bc1a78

* main: docs/troubleshooting: upgrade docker: prompt user to ensure pg_dump'd file has data (#10353)

I guess 'challenge type' has been eliminated as a field.

7719cfc

web: update PasswordStageForm according to lit-analyzer

c5a65f7

With lit-analyzer in the mix and functional, we're seeing new complaints about inconsistent typing in lit objects, and this was one of them.

Another lit-analyze error found.

f4c8624

Merge branch 'main' into web/cf/provide-show-password-button

a09afd3

* main: web: enhance search select with portal, overflow, and keyboard controls (#9517) Create readme.md (#10507)

kensternberg-authentik merged commit b0507d2 into main Jul 16, 2024
65 of 66 checks passed

kensternberg-authentik deleted the web/cf/provide-show-password-button branch July 16, 2024 01:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

web: provide 'show password' button #10337

web: provide 'show password' button #10337

kensternberg-authentik commented Jul 2, 2024 •

edited

Loading

netlify bot commented Jul 2, 2024 •

edited

Loading

netlify bot commented Jul 2, 2024 •

edited

Loading

BeryJu left a comment

codecov bot commented Jul 2, 2024 •

edited

Loading

github-actions bot commented Jul 2, 2024 •

edited

Loading

kensternberg-authentik Jul 2, 2024

kensternberg-authentik Jul 2, 2024

kensternberg-authentik Jul 2, 2024

web: provide 'show password' button #10337

web: provide 'show password' button #10337

Conversation

kensternberg-authentik commented Jul 2, 2024 • edited Loading

Details

What

Why

netlify bot commented Jul 2, 2024 • edited Loading

✅ Deploy Preview for authentik-storybook ready!

netlify bot commented Jul 2, 2024 • edited Loading

✅ Deploy Preview for authentik-docs ready!

BeryJu left a comment

Choose a reason for hiding this comment

codecov bot commented Jul 2, 2024 • edited Loading

Codecov Report

github-actions bot commented Jul 2, 2024 • edited Loading

kensternberg-authentik Jul 2, 2024

Choose a reason for hiding this comment

kensternberg-authentik Jul 2, 2024

Choose a reason for hiding this comment

kensternberg-authentik Jul 2, 2024

Choose a reason for hiding this comment

kensternberg-authentik commented Jul 2, 2024 •

edited

Loading

netlify bot commented Jul 2, 2024 •

edited

Loading

netlify bot commented Jul 2, 2024 •

edited

Loading

codecov bot commented Jul 2, 2024 •

edited

Loading

github-actions bot commented Jul 2, 2024 •

edited

Loading