web: all aboard the anti-if bus, according to tooling #10220

kensternberg-authentik · 2024-06-25T20:49:40Z

Details

web: all-aboard the anti-if bus, according to tooling

This commit revises a number of bugs eslint has been complaining about for awhile now. This is the lesser of two PRs that will address this issue, and in this case the two biggest problems were inappropriate conditionals (using a switch for a single comparison), unnecessarily named returns, empty returns. This brings our use of conditions in-line with the coding standards we say we want in eslintrc!

The code has been formatted (make web)

Getting ESBuild, Lit, and Storybook to all agree on how to read and parse stylesheets is a serious pain. This fix better identifies the value types (instances) being passed from various sources in the repo to the three *different* kinds of style processors we're using (the native one, the polyfill one, and whatever the heck Storybook does internally). Falling back to using older CSS instantiating techniques one era at a time seems to do the trick. It's ugly, but in the face of the aggressive styling we use to avoid Flashes of Unstyled Content (FLoUC), it's the logic with which we're left. In standard mode, the following warning appears on the console when running a Flow: ``` Autofocus processing was blocked because a document already has a focused element. ``` In compatibility mode, the following **error** appears on the console when running a Flow: ``` crawler-inject.js:1106 Uncaught TypeError: Failed to execute 'observe' on 'MutationObserver': parameter 1 is not of type 'Node'. at initDomMutationObservers (crawler-inject.js:1106:18) at crawler-inject.js:1114:24 at Array.forEach (<anonymous>) at initDomMutationObservers (crawler-inject.js:1114:10) at crawler-inject.js:1549:1 initDomMutationObservers @ crawler-inject.js:1106 (anonymous) @ crawler-inject.js:1114 initDomMutationObservers @ crawler-inject.js:1114 (anonymous) @ crawler-inject.js:1549 ``` Despite this error, nothing seems to be broken and flows work as anticipated.

* main: tenants: really ensure default tenant cannot be deleted (#8875) core: bump github.com/go-openapi/runtime from 0.27.2 to 0.28.0 (#8867) core: bump pytest from 8.0.2 to 8.1.1 (#8868) core: bump github.com/go-openapi/strfmt from 0.22.2 to 0.23.0 (#8869) core: bump bandit from 1.7.7 to 1.7.8 (#8870) core: bump packaging from 23.2 to 24.0 (#8871) core: bump ruff from 0.3.1 to 0.3.2 (#8873) web: bump the wdio group in /tests/wdio with 3 updates (#8865) core: bump requests-oauthlib from 1.3.1 to 1.4.0 (#8866) core: bump uvicorn from 0.27.1 to 0.28.0 (#8872) core: bump django-filter from 23.5 to 24.1 (#8874)

* main: web: fix esbuild issue with style sheets (#8856)

* main: web: upgrade to lit 3 (#8781)

* main: Update _envoy_istio.md (#8888) website/docs: new landing page for Providers (#8879) web: bump the sentry group in /web with 1 update (#8881) web: bump chromedriver from 122.0.4 to 122.0.5 in /tests/wdio (#8884) web: bump the eslint group in /tests/wdio with 2 updates (#8883) web: bump the eslint group in /web with 2 updates (#8885) website: bump @types/react from 18.2.64 to 18.2.65 in /website (#8886)

* main: api: capabilities: properly set can_save_media when s3 is enabled (#8896) web: bump the rollup group in /web with 3 updates (#8891) core: bump pydantic from 2.6.3 to 2.6.4 (#8892) core: bump twilio from 9.0.0 to 9.0.1 (#8893)

* main: web: bump chromedriver from 122.0.5 to 122.0.6 in /tests/wdio (#8902) web: bump vite-tsconfig-paths from 4.3.1 to 4.3.2 in /web (#8903) core: bump google.golang.org/protobuf from 1.32.0 to 1.33.0 (#8901) web: provide InstallID on EnterpriseListPage (#8898)

* main: web: clean up and remove redundant alias '@goauthentik/app' (#8889) web/admin: fix markdown table rendering (#8908)

* main: (31 commits) root: support redis username (#8935) core: bump black from 24.2.0 to 24.3.0 (#8945) web: bump the wdio group in /tests/wdio with 2 updates (#8939) web: bump the sentry group in /web with 1 update (#8941) website: bump postcss from 8.4.35 to 8.4.36 in /website (#8940) core: bump twilio from 9.0.1 to 9.0.2 (#8942) core: bump ruff from 0.3.2 to 0.3.3 (#8943) events: discard notification if user has empty email (#8938) ci: always run ci-main on branch pushes (#8950) core: bump goauthentik.io/api/v3 from 3.2024022.2 to 3.2024022.3 (#8946) website/docs: add new name "Microsft Entra ID" for Azure AD (#8930) outposts: Enhance config options for k8s outposts (#7363) website/docs: add link to CRUD docs (#8925) web: bump API Client version (#8927) outpost: improved set secret answers for flow execution (#8013) stages/user_write: ensure user data is json-serializable (#8926) website/docs: update example ldapsearch commands (#8906) admin: Handle latest version unknown in admin dashboard (#8858) core: bump coverage from 7.4.3 to 7.4.4 (#8917) core: bump urllib3 from 1.26.18 to 2.2.1 (#8918) ...

* main: outposts/proxy: Fix invalid redirect on external hosts containing path components (#8915) core: cache user application list under policies (#8895) web: bump the eslint group in /web with 2 updates (#8959) web: bump core-js from 3.36.0 to 3.36.1 in /web (#8960) website: bump @types/react from 18.2.66 to 18.2.67 in /website (#8962) web: bump the eslint group in /tests/wdio with 2 updates (#8963)

* main: web: improve build speeds even moar!!!!!! (#8954)

* main: website/docs: config: remove options moved to tenants (#8976) web: bump @types/grecaptcha from 3.0.8 to 3.0.9 in /web (#8971) web: bump country-flag-icons from 1.5.9 to 1.5.10 in /web (#8970) web: bump the babel group in /web with 7 updates (#8969) core: bump uvicorn from 0.28.0 to 0.28.1 (#8968) website: bump postcss from 8.4.36 to 8.4.37 in /website (#8967) internal: cleanup static file serving setup code (#8965) website/integrations: portainer: match portainer settings order (#8974)

* main: website/docs: add example policy to enforce unique email address (#8955) web/admin: remove enterprise preview banner (#8991) core: bump uvicorn from 0.28.1 to 0.29.0 (#8980) core: bump sentry-sdk from 1.42.0 to 1.43.0 (#8981) web: bump the babel group in /web with 3 updates (#8983) web: bump typescript from 5.4.2 to 5.4.3 in /web (#8984) web: bump typescript from 5.4.2 to 5.4.3 in /tests/wdio (#8986) web: bump chromedriver from 122.0.6 to 123.0.0 in /tests/wdio (#8987) website: bump typescript from 5.4.2 to 5.4.3 in /website (#8989) core: bump importlib-metadata from 7.0.2 to 7.1.0 (#8982) web: bump the wdio group in /tests/wdio with 3 updates (#8985) website: bump postcss from 8.4.37 to 8.4.38 in /website (#8988)

* main: web: bump API Client version (#9021) sources/ldap: add ability to disable password write on login (#8377) web: bump API Client version (#9020) lifecycle: migrate: ensure template schema exists before migrating (#8952) website/integrations: Update nextcloud Admin Group Expression (#7314) web/flow: general ux improvements (#8558) website: bump @types/react from 18.2.67 to 18.2.69 in /website (#9016) core: bump requests-oauthlib from 1.4.0 to 2.0.0 (#9018) web: bump the sentry group in /web with 2 updates (#9017) web/admin: small fixes (#9002) website: bump webpack-dev-middleware from 5.3.3 to 5.3.4 in /website (#9001) core: bump ruff from 0.3.3 to 0.3.4 (#8998) website/docs: Upgrade nginx reverse porxy config (#8947) website/docs: improve flow inspector docs (#8993) website/deverlop-docs website/integrations: add links to integrations template (#8995)

* main: web: bump API Client version (#9035) website/docs: maintenance, re-add system settings (#9026) core: bump duo-client from 5.2.0 to 5.3.0 (#9029) website: bump express from 4.18.2 to 4.19.2 in /website (#9027) web: bump express from 4.18.3 to 4.19.2 in /web (#9028) web: bump the eslint group in /web with 2 updates (#9030) core: bump goauthentik.io/api/v3 from 3.2024022.3 to 3.2024022.5 (#9031) website: bump @types/react from 18.2.69 to 18.2.70 in /website (#9032) web: bump the eslint group in /tests/wdio with 2 updates (#9033) web: bump katex from 0.16.9 to 0.16.10 in /web (#9025) translate: Updates for file locale/en/LC_MESSAGES/django.po in fr (#9023) website/docs: include OS-specific docker-compose install instructions + minor fixes (#8975)

* main: web: a few minor bugfixes and lintfixes (#9044) website/integrations: add documentation for OIDC setup with Xen Orchestra (#9000) website: bump @types/react from 18.2.70 to 18.2.72 in /website (#9041) core: bump goauthentik.io/api/v3 from 3.2024022.5 to 3.2024022.6 (#9042) web: fix markdown rendering bug for alerts (#9037)

* main: (23 commits) providers/oauth2: fix interactive device flow (#9076) website/docs: fix transports example (#9074) events: fix log_capture (#9075) web: bump the sentry group in /web with 2 updates (#9065) core: bump goauthentik.io/api/v3 from 3.2024022.6 to 3.2024022.7 (#9064) web: bump @codemirror/lang-python from 6.1.4 to 6.1.5 in /web (#9068) web: bump the eslint group in /web with 1 update (#9066) web: bump glob from 10.3.10 to 10.3.12 in /web (#9069) web: bump the rollup group in /web with 3 updates (#9067) web: bump the eslint group in /tests/wdio with 1 update (#9071) core: bump webauthn from 2.0.0 to 2.1.0 (#9070) core: bump sentry-sdk from 1.43.0 to 1.44.0 (#9073) core: bump requests-mock from 1.12.0 to 1.12.1 (#9072) web: bump API Client version (#9061) events: rework log messages returned from API and their rendering (#8770) website/docs: update airgapped config (#9049) website: bump @types/react from 18.2.72 to 18.2.73 in /website (#9052) web: bump the rollup group in /web with 3 updates (#9053) core: bump django-filter from 24.1 to 24.2 (#9055) core: bump requests-mock from 1.11.0 to 1.12.0 (#9056) ...

* main: web: move context controllers into reactive controller plugins (#8996) web: maintenance: split tsconfig into “base” and “build” variants. (#9036) web: consistent style declarations internally (#9077)

* main: web: bump @patternfly/elements from 2.4.0 to 3.0.0 in /web (#9089) web: bump ts-pattern from 5.0.8 to 5.1.0 in /web (#9090) website: bump the docusaurus group in /website with 9 updates (#9087) web/admin: allow custom sorting for bound* tables (#9080)

* main: root: fix missing imports after #9081 (#9106) root: move database calls from ready() to dedicated startup signal (#9081) web: fix console log leftover (#9096) web: bump the eslint group in /web with 2 updates (#9098) core: bump twilio from 9.0.2 to 9.0.3 (#9103) web: bump the eslint group in /tests/wdio with 2 updates (#9099) core: bump drf-spectacular from 0.27.1 to 0.27.2 (#9100) core: bump django-model-utils from 4.4.0 to 4.5.0 (#9101) core: bump ruff from 0.3.4 to 0.3.5 (#9102) website/docs: update notes on SECRET_KEY (#9091) web: fix broken locale compile (#9095) website/integrations: add outline knowledge base (#8786) website/docs: fix typo (#9082) website/docs: email stage: fix example translation error (#9048)

* main: (22 commits) blueprints: fix default username field in user-settings flow (#9136) website/docs: add procedural docs for RAC (#9006) web: bump API Client version (#9133) ci: fix python client generator (#9134) root: generate python client (#9107) web: Bump vite from 5.1.4 to 5.2.8 in /web (#9120) core, web: update translations (#9124) core: Bump golang from 1.22.1-bookworm to 1.22.2-bookworm (#9125) web: Bump the babel group in /web with 2 updates (#9126) web: Bump the eslint group in /web with 1 update (#9127) web: Bump the eslint group in /tests/wdio with 1 update (#9129) core: Bump sentry-sdk from 1.44.0 to 1.44.1 (#9130) core: Bump channels from 4.0.0 to 4.1.0 (#9131) core: Bump django from 5.0.3 to 5.0.4 (#9132) web: Bump the rollup group in /web with 3 updates (#9128) translate: Updates for file locale/en/LC_MESSAGES/django.po in zh-Hans (#9110) translate: Updates for file locale/en/LC_MESSAGES/django.po in zh_CN (#9109) translate: Updates for file web/xliff/en.xlf in zh_CN (#9111) translate: Updates for file web/xliff/en.xlf in zh-Hans (#9112) web: Bump @fortawesome/fontawesome-free from 6.5.1 to 6.5.2 in /web (#9116) ...

* main: (25 commits) root: fix readme (#9178) enterprise: fix audit middleware import (#9177) web: bump @spotlightjs/spotlight from 1.2.16 to 1.2.17 in /web in the sentry group (#9162) web: bump API Client version (#9174) stages/authenticator_webauthn: add MDS support (#9114) website/integrations: Update Nextcloud OIDC secret size limitation (#9139) translate: Updates for file web/xliff/en.xlf in zh_CN (#9170) translate: Updates for file web/xliff/en.xlf in zh-Hans (#9171) web: bump the rollup group in /web with 3 updates (#9164) web: bump @codemirror/legacy-modes from 6.3.3 to 6.4.0 in /web (#9166) web: bump ts-pattern from 5.1.0 to 5.1.1 in /web (#9167) core: bump github.com/go-ldap/ldap/v3 from 3.4.6 to 3.4.7 (#9168) core, web: update translations (#9156) root: fix redis username in lifecycle (#9158) web: ak-checkbox-group for short, static, multi-select events (#9138) root: fix startup (#9151) core: Bump golang.org/x/oauth2 from 0.18.0 to 0.19.0 (#9146) core: Bump twilio from 9.0.3 to 9.0.4 (#9143) web: Bump country-flag-icons from 1.5.10 to 1.5.11 in /web (#9144) web: Bump typescript from 5.4.3 to 5.4.4 in /web (#9145) ...

* main: web/admin: fix SAML Provider preview (#9192) core, web: update translations (#9183) web: bump chromedriver from 123.0.1 to 123.0.2 in /tests/wdio (#9188) website: bump @types/react from 18.2.74 to 18.2.75 in /website (#9185) website/docs: update Postgresql username (#9190) core: bump maxmind/geoipupdate from v6.1 to v7.0 (#9186) events: add context manager to ignore/modify audit events being written (#9181) web: fix application library list display length and capability (#9094)

* main: translate: Updates for file locale/en/LC_MESSAGES/django.po in zh_CN (#9194) translate: Updates for file locale/en/LC_MESSAGES/django.po in zh-Hans (#9197) translate: Updates for file web/xliff/en.xlf in zh_CN (#9196) translate: Updates for file web/xliff/en.xlf in zh-Hans (#9198) web: preserve selected list when provider updates (#9200) web: bump API Client version (#9195) sources/oauth: make URLs not required, only check when no OIDC URLs are defined (#9182)

* main: website/docs: add note for flow compatibility mode (#9204)

* main: website/docs: add more info and links about enforciing unique email addresses (#9154) core: bump goauthentik.io/api/v3 from 3.2024022.7 to 3.2024022.8 (#9215) web: bump API Client version (#9214) stages/authenticator_validate: add ability to limit webauthn device types (#9180) web: bump API Client version (#9213) core: add user settable token durations (#7410) core, web: update translations (#9205) web: bump typescript from 5.4.4 to 5.4.5 in /tests/wdio (#9206) web: bump chromedriver from 123.0.2 to 123.0.3 in /tests/wdio (#9207) core: bump sentry-sdk from 1.44.1 to 1.45.0 (#9208) web: bump typescript from 5.4.4 to 5.4.5 in /web (#9209) website: bump typescript from 5.4.4 to 5.4.5 in /website (#9210) core: bump python from 3.12.2-slim-bookworm to 3.12.3-slim-bookworm (#9211)

* main: (21 commits) web: manage stacked modals with a stack (#9193) website/docs: ensure yaml code blocks have language tags (#9240) blueprints: only create default brand if no other default brand exists (#9222) web: bump API Client version (#9239) website/integrations: portainer: Fix Redirect URL mismatch (#9226) api: fix authentication schema (#9238) translate: Updates for file web/xliff/en.xlf in zh_CN (#9229) translate: Updates for file web/xliff/en.xlf in zh-Hans (#9230) translate: Updates for file locale/en/LC_MESSAGES/django.po in zh_CN (#9228) translate: Updates for file locale/en/LC_MESSAGES/django.po in zh-Hans (#9231) core: bump pydantic from 2.6.4 to 2.7.0 (#9232) core: bump ruff from 0.3.5 to 0.3.7 (#9233) web: bump @sentry/browser from 7.109.0 to 7.110.0 in /web in the sentry group (#9234) website: bump @types/react from 18.2.75 to 18.2.77 in /website (#9236) core, web: update translations (#9225) website/integrations: add pfSense search scope (#9221) core: bump idna from 3.6 to 3.7 (#9224) website/docs: add websocket support to nginx snippets (#9220) internal: add tests to go flow executor (#9219) website/integrations: nextcloud: add tip to solve hashed groups configuring OAuth2 (#9153) ...

* main: (34 commits) web: bump API Client version (#9299) core: fix api schema for users and groups (#9298) providers/oauth2: fix refresh_token grant returning incorrect id_token (#9275) web: bump @sentry/browser from 7.110.0 to 7.110.1 in /web in the sentry group (#9278) core, web: update translations (#9277) web: bump the rollup group in /web with 3 updates (#9280) web: bump lit from 3.1.2 to 3.1.3 in /web (#9282) web: bump @lit/context from 1.1.0 to 1.1.1 in /web (#9281) website: bump @types/react from 18.2.78 to 18.2.79 in /website (#9286) core: bump goauthentik.io/api/v3 from 3.2024022.10 to 3.2024022.11 (#9285) core: bump sqlparse from 0.4.4 to 0.5.0 (#9276) lifecycle: gunicorn: fix app preload (#9274) events: add indexes (#9272) web/flows: fix passwordless hidden without input (#9273) root: fix geoipupdate arguments (#9271) website/docs: cleanup more (#9249) web: bump API Client version (#9270) sources: add SCIM source (#3051) core: delegated group member management (#9254) web: bump API Client version (#9269) ...

* main: (23 commits) web: bump API Client version (#9316) release: 2024.2.3 website/docs: 2024.2.3 release notes (#9313) web/admin: fix log viewer empty state (#9315) website/docs: fix formatting for stage changes (#9314) core: bump github.com/go-ldap/ldap/v3 from 3.4.7 to 3.4.8 (#9310) core: bump goauthentik.io/api/v3 from 3.2024022.11 to 3.2024022.12 (#9311) web: bump core-js from 3.36.1 to 3.37.0 in /web (#9309) core: bump gunicorn from 21.2.0 to 22.0.0 (#9308) core, web: update translations (#9307) website/docs: system settings: add default token duration and length (#9306) web/flows: update flow background (#9305) web: fix locale loading being skipped (#9301) translate: Updates for file web/xliff/en.xlf in fr (#9304) translate: Updates for file locale/en/LC_MESSAGES/django.po in fr (#9303) core: replace authentik_signals_ignored_fields with audit_ignore (#9291) web/flow: fix form input rendering issue (#9297) events: fix incorrect user logged when using API token authentication (#9302) translate: Updates for file locale/en/LC_MESSAGES/django.po in zh_CN (#9293) translate: Updates for file locale/en/LC_MESSAGES/django.po in zh-Hans (#9295) ...

* main: stages/prompt: fix username field throwing error with existing user (#9342) root: expose session storage configuration (#9337) website/integrations: fix typo (#9340) root: fix go.mod for codeql checking (#9338) root: make redis settings more consistent (#9335) web/admin: fix error in admin interface due to un-hydrated context (#9336) web: bump API Client version (#9334) stages/authenticator_webauthn: fix attestation value (#9333) website/docs: fix SECRET_KEY length (#9328) website/docs: fix email template formatting (#9330) core, web: update translations (#9323) web: bump @patternfly/elements from 3.0.0 to 3.0.1 in /web (#9324) core: bump celery from 5.3.6 to 5.4.0 (#9325) core: bump goauthentik.io/api/v3 from 3.2024022.12 to 3.2024023.1 (#9327) sources/scim: service account should be internal (#9321) web: bump the storybook group in /web with 8 updates (#9266) sources/scim: cleanup service account when source is deleted (#9319)

* main: website/docs: add docs for configuring Facebook as a source (#9884) web: bump the esbuild group in /web with 2 updates (#9879) core: bump twilio from 9.0.5 to 9.1.0 (#9875) core: bump coverage from 7.5.1 to 7.5.2 (#9876) core: bump goauthentik.io/api/v3 from 3.2024042.7 to 3.2024042.8 (#9877) web: bump the babel group in /web with 7 updates (#9878) web: bump glob from 10.4.0 to 10.4.1 in /web (#9881) web: bump the wdio group in /tests/wdio with 4 updates (#9882) events: fix geoip enrich context not converting to json-seriazable data (#9885) stages/user_login: fix non-json-serializable being used (#9886)

* main: (44 commits) translate: Updates for file locale/en/LC_MESSAGES/django.po in ru (#9943) translate: Updates for file locale/en/LC_MESSAGES/django.po in zh-Hans (#9944) translate: Updates for file locale/en/LC_MESSAGES/django.po in zh_CN (#9942) stages/authenticator_webauthn: migrate device type import to systemtask and schedule (#9958) website: bump prettier from 3.2.5 to 3.3.0 in /website (#9951) web: bump yaml from 2.4.2 to 2.4.3 in /web (#9945) web: bump prettier from 3.2.5 to 3.3.0 in /web (#9946) core: bump uvicorn from 0.30.0 to 0.30.1 (#9948) core: bump ruff from 0.4.6 to 0.4.7 (#9949) website: bump the docusaurus group in /website with 9 updates (#9950) web: bump prettier from 3.2.5 to 3.3.0 in /tests/wdio (#9952) web: bump chromedriver from 125.0.2 to 125.0.3 in /tests/wdio (#9953) core: groups: optimize recursive children query (#9931) core, web: update translations (#9938) stages/authenticator_webauthn: optimize device types creation (#9932) stages/authenticator_webauthn: Update FIDO MDS3 & Passkey aaguid blobs (#9936) providers/oauth2: don't handle api scope as special scope (#9910) core: bump goauthentik.io/api/v3 from 3.2024042.8 to 3.2024042.9 (#9915) web: bump the storybook group in /web with 7 updates (#9917) website/integrations: firezone: remove question mark typo and remove promotional sentence (#9927) ...

* main: web: bump API Client version (#9967) stages/captcha: rework (#9959) website/docs: fixed broken links to helm repo (#9960) core: bump pydantic from 2.7.2 to 2.7.3 (#9962) web: bump the wdio group in /tests/wdio with 4 updates (#9963)

* main: (66 commits) rbac: filters: fix missing attribute for unauthenticated requests (#10061) tests/e2e: docker-compose.yml: remove version element forgotten last time (#10067) providers/microsoft_entra: fix error when updating connection attributes (#10039) website/integrations: aws: fix about service link (#10062) translate: Updates for file locale/en/LC_MESSAGES/django.po in it (#10060) core: bump github.com/redis/go-redis/v9 from 9.5.2 to 9.5.3 (#10046) core: bump github.com/gorilla/websocket from 1.5.1 to 1.5.2 (#10047) translate: Updates for file locale/en/LC_MESSAGES/django.po in ru (#10058) core: bump sentry-sdk from 2.5.0 to 2.5.1 (#10048) core: bump django-cte from 1.3.2 to 1.3.3 (#10049) core: bump packaging from 24.0 to 24.1 (#10050) web: bump yaml from 2.4.3 to 2.4.5 in /web (#10054) web: bump @sentry/browser from 8.7.0 to 8.8.0 in /web in the sentry group (#10051) web: bump esbuild from 0.21.4 to 0.21.5 in /web (#10053) crypto: update fingerprint at same time as certificate (#10036) translate: Updates for file locale/en/LC_MESSAGES/django.po in ru (#10056) website/integrations: gitea: fix helm values (#10043) core, web: update translations (#10038) translate: Updates for file locale/en/LC_MESSAGES/django.po in ru (#10040) docs/troubleshooting: upgrade docker: erroneous command (#10044) ...

* main: website/developer-docs: add a baby Style Guide (#9900) website/integrations: gitlab: update certificate key pair location and specify sha (#9925) root: handle asgi exception (#10085) website: bump prettier from 3.3.1 to 3.3.2 in /website (#10082) web: bump prettier from 3.3.1 to 3.3.2 in /web (#10081) core: bump google-api-python-client from 2.132.0 to 2.133.0 (#10083) web: bump prettier from 3.3.1 to 3.3.2 in /tests/wdio (#10079) web: bump chromedriver from 125.0.3 to 126.0.0 in /tests/wdio (#10078) web: bump @sentry/browser from 8.8.0 to 8.9.1 in /web in the sentry group (#10080) web: bump braces from 3.0.2 to 3.0.3 in /web (#10077) website: bump braces from 3.0.2 to 3.0.3 in /website (#10076) web: bump braces from 3.0.2 to 3.0.3 in /tests/wdio (#10075) core: bump azure-identity from 1.16.0 to 1.16.1 (#10071)

* main: website/docs: release notes for 2024.6 (#9812) policies/reputation: save to database directly (#10059) providers/enterprise: import user/group data when manually linking objects (#10089) core, web: update translations (#10108) web: Add enterprise / FIPS notification to the AdminOverviewPage (#10090) core: bump github.com/getsentry/sentry-go from 0.28.0 to 0.28.1 (#10095) web: bump API Client version (#10107) admin: system api: do not show FIPS status if no valid license (#10091) root: add configuration option to enable fips (#10088) web: bump the sentry group across 1 directory with 2 updates (#10101) web: bump ts-pattern from 5.1.2 to 5.2.0 in /web (#10098) web: bump the storybook group across 1 directory with 7 updates (#10102) core: bump github.com/gorilla/websocket from 1.5.2 to 1.5.3 (#10103) core: bump pydantic from 2.7.3 to 2.7.4 (#10093) core: bump bandit from 1.7.8 to 1.7.9 (#10094)

* main: (27 commits) root: use custom model serializer that saves m2m without bulk (#10139) core: bump urllib3 from 2.2.1 to 2.2.2 (#10143) ci: bump docker/build-push-action from 5 to 6 (#10144) web: bump the storybook group in /web with 7 updates (#10147) web: bump ws from 8.16.0 to 8.17.1 in /web (#10149) web: fix needed because recent upgrade to task breaks spinner button (#10142) core: include version in built JS files (#9558) website/integations/services: Slack integration docs (#9933) web: fix early modal stack depletion (#10068) website: bump react-tooltip from 5.26.4 to 5.27.0 in /website (#10129) web: bump @patternfly/elements from 3.0.1 to 3.0.2 in /web (#10132) core: bump github.com/gorilla/sessions from 1.2.2 to 1.3.0 (#10135) web: bump chromedriver from 126.0.0 to 126.0.1 in /tests/wdio (#10136) core: bump github.com/spf13/cobra from 1.8.0 to 1.8.1 (#10133) core, web: update translations (#10127) core: bump ruff from 0.4.8 to 0.4.9 (#10128) core: bump goauthentik.io/api/v3 from 3.2024042.11 to 3.2024042.13 (#10134) core, web: update translations (#10118) translate: Updates for file web/xliff/en.xlf in zh-Hans (#10121) translate: Updates for file web/xliff/en.xlf in zh_CN (#10120) ...

* main: website/docs: update 2024.6 release notes with latest changes (#10174) core: fix error when raising SkipObject in mapping (#10153) website/docs: 2024.6 release notes: add note about group names (#10170) website/docs: update 2024.6 release notes with latest changes (#10167) core: bump twilio from 9.1.1 to 9.2.0 (#10162) web: bump chromedriver from 126.0.1 to 126.0.2 in /tests/wdio (#10161) web: bump the wdio group in /tests/wdio with 4 updates (#10160) website/integrations: jellyfin: add OIDC configuration (#9538) website/docs: Describe where to apply the auto setup env vars (#9863) website/integrations: gitlab: better service description (#9923) web: fix docker build for non-release versions (#10154) root: makefile: add codespell to make-website (#10116)

* main: website/docs: Fix nginx proxy_pass directive documentation (#10181) website/docs: Remove hyphen in read replica in Release Notes (#10178) core: rework base for SkipObject exception to better support control flow exceptions (#10186) web: bump glob from 10.4.1 to 10.4.2 in /web (#10163) core: bump google-api-python-client from 2.133.0 to 2.134.0 (#10183) web: bump @sentry/browser from 8.9.2 to 8.10.0 in /web in the sentry group (#10185) website/docs: update template reference (#10166)

* main: web/flows: update flow background (#10206) core: bump coverage from 7.5.3 to 7.5.4 (#10201) core: bump twilio from 9.2.0 to 9.2.1 (#10202) web: bump chromedriver from 126.0.2 to 126.0.3 in /tests/wdio (#10203) web: bump @sentry/browser from 8.10.0 to 8.11.0 in /web in the sentry group (#10204) website: bump typescript from 5.4.5 to 5.5.2 in /website (#10190) web: bump typescript from 5.4.5 to 5.5.2 in /web (#10191) web: bump typescript from 5.4.5 to 5.5.2 in /tests/wdio (#10192) core: bump ruff from 0.4.9 to 0.4.10 (#10193) core: bump selenium from 4.21.0 to 4.22.0 (#10194)

This commit revises a number of bugs `eslint` has been complaining about for awhile now. This is the lesser of two PRs that will address this issue, and in this case the two biggest problems were inappropriate conditionals (using a `switch` for a single comparison), unnecessarily named returns, empty returns. This brings our use of conditions in-line with the coding standards we _say_ we want in eslintrc!

netlify · 2024-06-25T20:49:57Z

✅ Deploy Preview for authentik-docs ready!

Name	Link
🔨 Latest commit	`dd9349c`
🔍 Latest deploy log	https://app.netlify.com/sites/authentik-docs/deploys/66958408c40c770008390805
😎 Deploy Preview	https://deploy-preview-10220--authentik-docs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify · 2024-06-25T20:49:58Z

✅ Deploy Preview for authentik-storybook ready!

Name	Link
🔨 Latest commit	`dd9349c`
🔍 Latest deploy log	https://app.netlify.com/sites/authentik-storybook/deploys/6695840887c2ae0008b29e7e
😎 Deploy Preview	https://deploy-preview-10220--authentik-storybook.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

…ated files

codecov · 2024-06-25T20:56:18Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.50%. Comparing base (c0063c1) to head (dd9349c).

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #10220      +/-   ##
==========================================
- Coverage   92.62%   92.50%   -0.12%     
==========================================
  Files         714      714              
  Lines       35005    35005              
==========================================
- Hits        32422    32383      -39     
- Misses       2583     2622      +39

Flag	Coverage Δ
e2e	`48.48% <ø> (-1.12%)`	⬇️
integration	`25.36% <ø> (ø)`
unit	`90.11% <ø> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

kensternberg-authentik · 2024-06-25T20:53:40Z

web/scripts/build-locales.mjs

-function compareXlfAndSrc(loc) {
-    const xlf = path.join("./xliff", `${loc}.xlf`);
-    const src = path.join("./src/locales", `${loc}.ts`);
+function generatedFileIsUpToDateWithXliffSource(loc) {


It took me awhile to figure out what this function does. That isn't good, considering I wrote it initially. I've revised it with a better name and the clear comparison eslint demanded.

kensternberg-authentik · 2024-06-25T20:54:08Z

web/scripts/eslint-nightmare.mjs

@@ -0,0 +1,55 @@
+import { execFileSync } from "child_process";


ESlint in nightmare mode, only this checks everything.

kensternberg-authentik · 2024-06-25T20:55:38Z

web/src/elements/Tabs.ts

-                    // To update the URL to match with the current slot
-                    this.onClick(params[this.pageIdentifier] as string);
-                }
+            if (


// collapse-nested-if

kensternberg-authentik · 2024-06-25T20:58:05Z

web/src/common/helpers/webauthn.ts

@@ -98,12 +97,11 @@ export function transformCredentialRequestOptions(
        },
    );

-    const transformedCredentialRequestOptions = Object.assign({}, credentialRequestOptions, {


// prefer-immediate-return

kensternberg-authentik · 2024-06-25T20:58:23Z

web/src/elements/forms/SearchSelect/ak-search-select.ts

@@ -352,10 +352,13 @@ export class SearchSelect<T> extends CustomEmitterElement(AKElement) {
        const onFocus = (ev: FocusEvent) => {
            this.open = true;
            this.renderMenu();
-            if (this.blankable && this.renderedValue === this.emptyOption) {


// collapse-nested-if

kensternberg-authentik · 2024-06-25T21:02:17Z

web/src/elements/sidebar/SidebarItem.ts

@@ -117,19 +117,11 @@ export class SidebarItem extends AKElement {
        if (!this.path) {
            return false;
        }
-        if (this.path) {


I realized the two comparisons were complimentary, so that takes out the if. exec isn't needed here, just test. Giving the two comparisons names helps understand what the code is doing.

// prefer-single-boolean-return

kensternberg-authentik · 2024-06-25T21:03:51Z

web/src/flow/stages/prompt/PromptStage.ts

@@ -231,14 +231,11 @@ ${prompt.initialValue}</textarea

    shouldRenderInWrapper(prompt: StagePrompt): boolean {
        // Special types that aren't rendered in a wrapper
-        if (


// prefer-single-boolean-return

kensternberg-authentik · 2024-06-25T21:04:09Z

web/src/user/user-settings/details/UserSettingsFlowExecutor.ts

@@ -169,21 +166,20 @@ export class UserSettingsFlowExecutor
            case ChallengeChoices.Shell:
                return html`${unsafeHTML((this.challenge as ShellChallenge).body)}`;
            case ChallengeChoices.Native:
-                switch (this.challenge.component) {


// small-switch-statement

Unlike most of the others, there's that debug statement right in the middle, so I couldn't make this a conditional expression, so if is recommended here instead of switch.

kensternberg-authentik · 2024-06-25T21:04:25Z

web/src/user/user-settings/details/UserSettingsFlowExecutor.ts

@@ -71,10 +71,7 @@ export class UserSettingsFlowExecutor
            })
            .then((data) => {
                this.challenge = data;
-                if (this.challenge.responseErrors) {


// prefer-single-boolean-return

kensternberg-authentik · 2024-06-25T21:05:01Z

web/src/user/user-settings/details/stages/prompt/PromptStage.ts

@@ -10,20 +10,16 @@ import { PromptTypeEnum, StagePrompt } from "@goauthentik/api";
 @customElement("ak-user-stage-prompt")
 export class UserSettingsPromptStage extends PromptStage {
    renderPromptInner(prompt: StagePrompt): TemplateResult {
-        switch (prompt.type) {


// small-switch-statement

github-actions · 2024-06-25T21:17:21Z

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-ghcr.io/goauthentik/dev-server:gh-dd9349c8de077b5256b3e36af49fd30ca5cb6a2f
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

For arm64, use these values:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-ghcr.io/goauthentik/dev-server:gh-dd9349c8de077b5256b3e36af49fd30ca5cb6a2f-arm64
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-ghcr.io/goauthentik/dev-server:gh-dd9349c8de077b5256b3e36af49fd30ca5cb6a2f

For arm64, use these values:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-ghcr.io/goauthentik/dev-server:gh-dd9349c8de077b5256b3e36af49fd30ca5cb6a2f-arm64

Afterwards, run the upgrade commands from the latest release notes.

kensternberg-authentik · 2024-06-25T21:26:20Z

web/src/admin/property-mappings/PropertyMappingTestForm.ts

@@ -66,14 +66,11 @@ export class PolicyTestForm extends Form<PropertyMappingTestRequest> {
        </ak-form-element-horizontal>`;
    }

-    renderExampleButtons(): TemplateResult {
-        const header = html`<p>${msg("Example context data")}</p>`;


// small-switch-statement

* main: (199 commits) core: bump setuptools from 69.5.1 to 70.0.0 (#10503) web: replace multi-select with dual-select for all propertyMapping invocations (#9359) web: enable custom-element-manifest and DOM/JS integration checking. (#10177) website/docs: configuration: fix typo in kubectl command (#10492) website/integrations: fix typo in minio instructions (#10500) web: bump @typescript-eslint/eslint-plugin from 7.5.0 to 7.16.0 in /tests/wdio (#10496) website: bump prettier from 3.3.2 to 3.3.3 in /website (#10493) core: bump ruff from 0.5.1 to 0.5.2 (#10494) web: bump @typescript-eslint/parser from 7.5.0 to 7.16.0 in /tests/wdio (#10495) web: bump eslint-plugin-sonarjs from 0.25.1 to 1.0.3 in /tests/wdio (#10498) web: bump prettier from 3.3.2 to 3.3.3 in /tests/wdio (#10497) web: bump pseudolocale from 2.0.0 to 2.1.0 in /web (#10499) core: bump goauthentik.io/api/v3 from 3.2024061.1 to 3.2024061.2 (#10491) web: bump API Client version (#10488) flows: remove stage challenge type (#10476) core: bump github.com/redis/go-redis/v9 from 9.5.3 to 9.5.4 (#10469) core: bump goauthentik.io/api/v3 from 3.2024060.6 to 3.2024061.1 (#10470) web: bump the babel group across 1 directory with 2 updates (#10471) web: bump the storybook group across 1 directory with 7 updates (#10472) core: bump coverage from 7.5.4 to 7.6.0 (#10473) ...

* main: web: fix bad name target that's breaking build (#10506) web: add HTMLTagNameElementMaps to everything to activate lit analyzer (#10217) web: replace handmade list in Admin Overview with generator, storybook generator, fix storybook, fix bug in list's parent component (#9726)

…older

* main: web: all aboard the anti-if bus, according to tooling (#10220) web: fix bad name target that's breaking build (#10506) web: add HTMLTagNameElementMaps to everything to activate lit analyzer (#10217) web: replace handmade list in Admin Overview with generator, storybook generator, fix storybook, fix bug in list's parent component (#9726) core: bump setuptools from 69.5.1 to 70.0.0 (#10503) web: replace multi-select with dual-select for all propertyMapping invocations (#9359) web: enable custom-element-manifest and DOM/JS integration checking. (#10177)

) * web: fix esbuild issue with style sheets Getting ESBuild, Lit, and Storybook to all agree on how to read and parse stylesheets is a serious pain. This fix better identifies the value types (instances) being passed from various sources in the repo to the three *different* kinds of style processors we're using (the native one, the polyfill one, and whatever the heck Storybook does internally). Falling back to using older CSS instantiating techniques one era at a time seems to do the trick. It's ugly, but in the face of the aggressive styling we use to avoid Flashes of Unstyled Content (FLoUC), it's the logic with which we're left. In standard mode, the following warning appears on the console when running a Flow: ``` Autofocus processing was blocked because a document already has a focused element. ``` In compatibility mode, the following **error** appears on the console when running a Flow: ``` crawler-inject.js:1106 Uncaught TypeError: Failed to execute 'observe' on 'MutationObserver': parameter 1 is not of type 'Node'. at initDomMutationObservers (crawler-inject.js:1106:18) at crawler-inject.js:1114:24 at Array.forEach (<anonymous>) at initDomMutationObservers (crawler-inject.js:1114:10) at crawler-inject.js:1549:1 initDomMutationObservers @ crawler-inject.js:1106 (anonymous) @ crawler-inject.js:1114 initDomMutationObservers @ crawler-inject.js:1114 (anonymous) @ crawler-inject.js:1549 ``` Despite this error, nothing seems to be broken and flows work as anticipated. * web: all-aboard the anti-if bus, according to tooling This commit revises a number of bugs `eslint` has been complaining about for awhile now. This is the lesser of two PRs that will address this issue, and in this case the two biggest problems were inappropriate conditionals (using a `switch` for a single comparison), unnecessarily named returns, empty returns. This brings our use of conditions in-line with the coding standards we _say_ we want in eslintrc! * web: better names and logic for comparing the dates of Xliff vs generated files * Missed one. * Fixed a redirect issue that was creating an empty file in the ./web folder

kensternberg-authentik added 30 commits March 8, 2024 14:15

Merge branch 'main' into dev

e505f27

* main: web: fix esbuild issue with style sheets (#8856)

Merge branch 'main' into dev

5090621

* main: web: upgrade to lit 3 (#8781)

Merge branch 'main' into dev

2d0117d

* main: api: capabilities: properly set can_save_media when s3 is enabled (#8896) web: bump the rollup group in /web with 3 updates (#8891) core: bump pydantic from 2.6.3 to 2.6.4 (#8892) core: bump twilio from 9.0.0 to 9.0.1 (#8893)

Merge branch 'main' into dev

8b4e036

* main: web: clean up and remove redundant alias '@goauthentik/app' (#8889) web/admin: fix markdown table rendering (#8908)

Merge branch 'main' into dev

30beca9

* main: web: improve build speeds even moar!!!!!! (#8954)

Merge branch 'main' into dev

7123b2c

* main: web: move context controllers into reactive controller plugins (#8996) web: maintenance: split tsconfig into “base” and “build” variants. (#9036) web: consistent style declarations internally (#9077)

Merge branch 'main' into dev

23665d1

* main: website/docs: add note for flow compatibility mode (#9204)

kensternberg-authentik added 11 commits May 28, 2024 11:03

Merge branch 'main' into dev

312f364

* main: web: bump API Client version (#9967) stages/captcha: rework (#9959) website/docs: fixed broken links to helm repo (#9960) core: bump pydantic from 2.7.2 to 2.7.3 (#9962) web: bump the wdio group in /tests/wdio with 4 updates (#9963)

web: better names and logic for comparing the dates of Xliff vs gener…

d3e2273

…ated files

kensternberg-authentik commented Jun 25, 2024

View reviewed changes

kensternberg-authentik marked this pull request as ready for review June 25, 2024 21:06

kensternberg-authentik requested a review from a team as a code owner June 25, 2024 21:06

Missed one.

f800754

kensternberg-authentik commented Jun 25, 2024

View reviewed changes

BeryJu approved these changes Jul 9, 2024

View reviewed changes

kensternberg-authentik added 3 commits July 15, 2024 10:51

Fixed a redirect issue that was creating an empty file in the ./web f…

dd9349c

…older

kensternberg-authentik merged commit 085ab3c into main Jul 15, 2024
66 checks passed

kensternberg-authentik deleted the web/lint/sonar-rider branch July 15, 2024 20:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

web: all aboard the anti-if bus, according to tooling #10220

web: all aboard the anti-if bus, according to tooling #10220

kensternberg-authentik commented Jun 25, 2024

netlify bot commented Jun 25, 2024 •

edited

Loading

netlify bot commented Jun 25, 2024 •

edited

Loading

codecov bot commented Jun 25, 2024 •

edited

Loading

kensternberg-authentik Jun 25, 2024

kensternberg-authentik Jun 25, 2024

kensternberg-authentik Jun 25, 2024

kensternberg-authentik Jun 25, 2024

kensternberg-authentik Jun 25, 2024

kensternberg-authentik Jun 25, 2024

kensternberg-authentik Jun 25, 2024

kensternberg-authentik Jun 25, 2024

kensternberg-authentik Jun 25, 2024

kensternberg-authentik Jun 25, 2024

github-actions bot commented Jun 25, 2024 •

edited

Loading

kensternberg-authentik Jun 25, 2024

		@@ -0,0 +1,55 @@
		import { execFileSync } from "child_process";

web: all aboard the anti-if bus, according to tooling #10220

web: all aboard the anti-if bus, according to tooling #10220

Conversation

kensternberg-authentik commented Jun 25, 2024

Details

netlify bot commented Jun 25, 2024 • edited Loading

✅ Deploy Preview for authentik-docs ready!

netlify bot commented Jun 25, 2024 • edited Loading

✅ Deploy Preview for authentik-storybook ready!

codecov bot commented Jun 25, 2024 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Jun 25, 2024 • edited Loading

Choose a reason for hiding this comment

netlify bot commented Jun 25, 2024 •

edited

Loading

netlify bot commented Jun 25, 2024 •

edited

Loading

codecov bot commented Jun 25, 2024 •

edited

Loading

github-actions bot commented Jun 25, 2024 •

edited

Loading