-
-
Notifications
You must be signed in to change notification settings - Fork 944
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
website/docs: Fix nginx proxy_pass directive documentation #10181
Conversation
Signed-off-by: Mike Fotinakis <[email protected]>
Signed-off-by: Mike Fotinakis <[email protected]>
✅ Deploy Preview for authentik-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for authentik-storybook canceled.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't even remember where this incorrect configuration came from tbh
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10181 +/- ##
==========================================
- Coverage 92.62% 92.61% -0.01%
==========================================
Files 712 712
Lines 34933 34933
==========================================
- Hits 32356 32354 -2
- Misses 2577 2579 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Thanks @BeryJu 👍 FYI: this only worked for me using a manual outpost. I'm unable to get any kind of |
* main: website/docs: Fix nginx proxy_pass directive documentation (#10181) website/docs: Remove hyphen in read replica in Release Notes (#10178) core: rework base for SkipObject exception to better support control flow exceptions (#10186) web: bump glob from 10.4.1 to 10.4.2 in /web (#10163) core: bump google-api-python-client from 2.133.0 to 2.134.0 (#10183) web: bump @sentry/browser from 8.9.2 to 8.10.0 in /web in the sentry group (#10185) website/docs: update template reference (#10166)
Details
As per the nginx docs,
proxy_pass
sets the baseline for the reverse proxied URLs and will prepend theproxy_pass
URL.In the nginx docs in authentik, it's currently misdocumented and causes a duplicate
/outpost.goauthentik.io
path to be added during the rewrite, causing 404s with the forward auth (single domain) proxy setup and likely others?I believe this might be the cause of a few github issues noticing 404s on the outpost, namely things like #9122 and maybe others.
Previous behavior (incorrect):
https://some-proxy.company/outpost.goauthentik.io/auth/nginx
http://outpost.company:9000/outpost.goauthentik.io/outpost.goauthentik.io/auth/nginx
(incorrect)New behavior:
https://some-proxy.company/outpost.goauthentik.io/auth/nginx
http://outpost.company:9000/outpost.goauthentik.io/auth/nginx