Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

website/docs: Fix nginx proxy_pass directive documentation #10181

Merged
merged 2 commits into from
Jun 20, 2024

Conversation

fotinakis
Copy link
Contributor

Details

As per the nginx docs, proxy_pass sets the baseline for the reverse proxied URLs and will prepend the proxy_pass URL.

In the nginx docs in authentik, it's currently misdocumented and causes a duplicate /outpost.goauthentik.io path to be added during the rewrite, causing 404s with the forward auth (single domain) proxy setup and likely others?

I believe this might be the cause of a few github issues noticing 404s on the outpost, namely things like #9122 and maybe others.

Previous behavior (incorrect):

  1. nginx proxy receives request for https://some-proxy.company/outpost.goauthentik.io/auth/nginx
  2. nginx reverse proxies this to http://outpost.company:9000/outpost.goauthentik.io/outpost.goauthentik.io/auth/nginx (incorrect)

New behavior:

  1. nginx proxy receives request for https://some-proxy.company/outpost.goauthentik.io/auth/nginx
  2. nginx reverse proxies this to http://outpost.company:9000/outpost.goauthentik.io/auth/nginx

@fotinakis fotinakis requested a review from a team as a code owner June 20, 2024 01:41
Copy link

netlify bot commented Jun 20, 2024

Deploy Preview for authentik-docs ready!

Name Link
🔨 Latest commit 00d8fc0
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/667388ce6912dc0008e4dac8
😎 Deploy Preview https://deploy-preview-10181--authentik-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jun 20, 2024

Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit 00d8fc0
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/667388ce0a841a0008eb5c06

@BeryJu BeryJu changed the title Fix nginx proxy_pass directive documentation website/docs: Fix nginx proxy_pass directive documentation Jun 20, 2024
Copy link
Member

@BeryJu BeryJu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't even remember where this incorrect configuration came from tbh

Copy link

codecov bot commented Jun 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.61%. Comparing base (e6fd7cc) to head (00d8fc0).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10181      +/-   ##
==========================================
- Coverage   92.62%   92.61%   -0.01%     
==========================================
  Files         712      712              
  Lines       34933    34933              
==========================================
- Hits        32356    32354       -2     
- Misses       2577     2579       +2     
Flag Coverage Δ
e2e 49.55% <ø> (-0.01%) ⬇️
integration 25.40% <ø> (ø)
unit 90.09% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rissson rissson merged commit b334050 into goauthentik:main Jun 20, 2024
61 of 67 checks passed
@fotinakis
Copy link
Contributor Author

fotinakis commented Jun 20, 2024

Thanks @BeryJu 👍 FYI: this only worked for me using a manual outpost. I'm unable to get any kind of /outpost.goauthentik.io paths working on the embedded outpost at all, likely because of Host header problems.

kensternberg-authentik added a commit that referenced this pull request Jun 24, 2024
* main:
  website/docs: Fix nginx proxy_pass directive documentation (#10181)
  website/docs: Remove hyphen in read replica in Release Notes (#10178)
  core: rework base for SkipObject exception to better support control flow exceptions (#10186)
  web: bump glob from 10.4.1 to 10.4.2 in /web (#10163)
  core: bump google-api-python-client from 2.133.0 to 2.134.0 (#10183)
  web: bump @sentry/browser from 8.9.2 to 8.10.0 in /web in the sentry group (#10185)
  website/docs: update template reference (#10166)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants