From c9feb64269fd8d16a5ba6d21999f4f966752021d Mon Sep 17 00:00:00 2001 From: rmknan Date: Thu, 14 Sep 2023 20:22:02 -0400 Subject: [PATCH 01/10] Made changes to header files for documentation --- include/stumpless/element.h | 2 +- include/stumpless/param.h | 2 +- src/param.c | 28 ++++++++++++++++++---------- test/function/element.cpp | 2 +- test/function/param.cpp | 2 +- 5 files changed, 22 insertions(+), 14 deletions(-) diff --git a/include/stumpless/element.h b/include/stumpless/element.h index 6ddb28e0d..3e9b913d3 100644 --- a/include/stumpless/element.h +++ b/include/stumpless/element.h @@ -369,7 +369,7 @@ stumpless_element_has_param( const struct stumpless_element *element, * * @param element The element to get the name and params from. * - * @return The formatted string of or :[param1,...] if no error is encountered. + * @return The formatted string of name or name=[param1,...] if no error is encountered. * If an error is encountered, then NULL is returned and an error code is set appropriately. */ STUMPLESS_PUBLIC_FUNCTION diff --git a/include/stumpless/param.h b/include/stumpless/param.h index 0e346d286..20f0c008d 100644 --- a/include/stumpless/param.h +++ b/include/stumpless/param.h @@ -411,7 +411,7 @@ stumpless_set_param_value( struct stumpless_param *param, const char *value ); * * @param param The param to get the name and the value from. * - * @return The formatted string of "param_name: param_value" if no error is + * @return The formatted string of "param_name=param_value" if no error is * encountered. If an error is encountered, then NULL is returned and an * error code is set appropriately. */ diff --git a/src/param.c b/src/param.c index 564ef143a..beb6b3def 100644 --- a/src/param.c +++ b/src/param.c @@ -215,23 +215,31 @@ stumpless_param_to_string( const struct stumpless_param *param ) { name_len = param->name_length; value_len = param->value_length; - /* : */ - format = alloc_mem( value_len + name_len + 6 ); + // /* : */ + /* name="value"*/ + format = alloc_mem( value_len + name_len + 4 ); if( !format ) { goto fail; } - memcpy(format + 1, name, name_len); - memcpy(format + name_len + 4, value, value_len); + // memcpy(format + 1, name, name_len); + // memcpy(format + name_len + 4, value, value_len); + memcpy(format, name, name_len); + memcpy(format + name_len + 2, value, value_len); unlock_param( param ); - format[0] = '<'; - format[name_len + 1] = '>'; - format[name_len + 2] = ':'; - format[name_len + 3] = '<'; - format[name_len + value_len + 4] = '>'; - format[name_len + value_len + 5] = '\0'; + // format[0] = '<'; + // format[name_len + 1] = '>'; + // format[name_len + 2] = ':'; + // format[name_len + 3] = '<'; + // format[name_len + value_len + 4] = '>'; + // format[name_len + value_len + 5] = '\0'; + + format[name_len ] = '='; + format[name_len + 1] = '\"'; + format[name_len + value_len + 2] = '"'; + format[name_len + value_len + 3] = '\0' clear_error( ); diff --git a/test/function/element.cpp b/test/function/element.cpp index b27244525..9d81caa87 100644 --- a/test/function/element.cpp +++ b/test/function/element.cpp @@ -808,7 +808,7 @@ namespace { format = stumpless_element_to_string( element_with_params ); ASSERT_NOT_NULL( format ); - EXPECT_STREQ( format, ":[:,:]" ); + EXPECT_STREQ( format, ":[param-1=\"value-1\",param-2=\"value-2\"]" ); EXPECT_NO_ERROR; free( ( void * ) format ); diff --git a/test/function/param.cpp b/test/function/param.cpp index fd772907f..e377c5ce7 100644 --- a/test/function/param.cpp +++ b/test/function/param.cpp @@ -174,7 +174,7 @@ namespace { format = stumpless_param_to_string( &basic_param ); ASSERT_NOT_NULL( format ); - EXPECT_STREQ( format, ":" ); + EXPECT_STREQ( format, "basic-name=\"basic-value\"" ); EXPECT_NO_ERROR; free( ( void * ) format ); From c58b5ffb06f321b153e6e884953ba7383a7b497b Mon Sep 17 00:00:00 2001 From: rmknan Date: Thu, 14 Sep 2023 20:24:23 -0400 Subject: [PATCH 02/10] Redid the changes to files --- src/param.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/param.c b/src/param.c index beb6b3def..01c180a64 100644 --- a/src/param.c +++ b/src/param.c @@ -238,8 +238,8 @@ stumpless_param_to_string( const struct stumpless_param *param ) { format[name_len ] = '='; format[name_len + 1] = '\"'; - format[name_len + value_len + 2] = '"'; - format[name_len + value_len + 3] = '\0' + format[name_len + value_len + 2] = '\"'; + format[name_len + value_len + 3] = '\0'; clear_error( ); From 13bffe3f191d3be696f777ab4af6f4f3163e9037 Mon Sep 17 00:00:00 2001 From: rmknan Date: Thu, 14 Sep 2023 22:22:11 -0400 Subject: [PATCH 03/10] removed the commented lines --- src/param.c | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/src/param.c b/src/param.c index 01c180a64..d2f05d5a4 100644 --- a/src/param.c +++ b/src/param.c @@ -215,27 +215,18 @@ stumpless_param_to_string( const struct stumpless_param *param ) { name_len = param->name_length; value_len = param->value_length; - // /* : */ /* name="value"*/ format = alloc_mem( value_len + name_len + 4 ); if( !format ) { goto fail; } - // memcpy(format + 1, name, name_len); - // memcpy(format + name_len + 4, value, value_len); + memcpy(format, name, name_len); memcpy(format + name_len + 2, value, value_len); unlock_param( param ); - // format[0] = '<'; - // format[name_len + 1] = '>'; - // format[name_len + 2] = ':'; - // format[name_len + 3] = '<'; - // format[name_len + value_len + 4] = '>'; - // format[name_len + value_len + 5] = '\0'; - format[name_len ] = '='; format[name_len + 1] = '\"'; format[name_len + value_len + 2] = '\"'; From 53f7fe9aa1857fc8e0e23b3eee51e5a79209aeff Mon Sep 17 00:00:00 2001 From: rmknan Date: Fri, 15 Sep 2023 19:31:06 -0400 Subject: [PATCH 04/10] Made changes to target and stumpless_private and new header file --- .../config/wrapper/open_default_target.h | 40 +++++++++++++++++++ src/target.c | 1 + tools/check_headers/stumpless_private.yml | 1 + 3 files changed, 42 insertions(+) create mode 100644 include/private/config/wrapper/open_default_target.h diff --git a/include/private/config/wrapper/open_default_target.h b/include/private/config/wrapper/open_default_target.h new file mode 100644 index 000000000..0f05d1e25 --- /dev/null +++ b/include/private/config/wrapper/open_default_target.h @@ -0,0 +1,40 @@ +/* SPDX-License-Identifier: Apache-2.0 */ + +/* + * Copyright 2022 Joel E. Anderson + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +#ifndef __STUMPLESS_PRIVATE_CONFIG_WRAPPER_CONFIG_OPEN_DEFAULT_TARGET_H +# define __STUMPLESS_PRIVATE_CONFIG_WRAPPER_CONFIG_OPEN_DEFAULT_TARGET_H + + +/* definition of config_open_default_target */ +# ifdef STUMPLESS_WINDOWS_EVENT_LOG_TARGETS_SUPPORTED +# include "private/config/wel_supported.h" +# include "stumpless/target/wel.h" +# define config_open_default_target wel_open_default_target +# define config_close_default_target stumpless_close_wel_target +# elif STUMPLESS_SOCKET_TARGETS_SUPPORTED +# include +# include "private/config/socket_supported.h" +# define config_open_default_target socket_open_default_target +# define config_close_default_target stumpless_close_socket_target +# else +# include +# include "private/target/file.h" +# define config_open_default_target file_open_default_target +# define config_close_default_target stumpless_close_file_target +# endif +#endif /* __STUMPLESS_PRIVATE_CONFIG_OPEN_DEFAULT_TARGET_H */ diff --git a/src/target.c b/src/target.c index 34c12920f..7f0820b9f 100644 --- a/src/target.c +++ b/src/target.c @@ -40,6 +40,7 @@ #include "private/config/network_support_wrapper.h" #include "private/config/locale/wrapper.h" #include "private/config/wrapper.h" +#include "private/config/wrapper/config_open_default_target.h" #include "private/config/wrapper/wel.h" #include "private/config/wrapper/journald.h" #include "private/config/wrapper/socket.h" diff --git a/tools/check_headers/stumpless_private.yml b/tools/check_headers/stumpless_private.yml index 7432c5e64..5d486a10a 100644 --- a/tools/check_headers/stumpless_private.yml +++ b/tools/check_headers/stumpless_private.yml @@ -21,6 +21,7 @@ "config_format_string": "private/config/wrapper/format_string.h" "config_get_local_socket_name": "private/config/wrapper/socket.h" "config_get_now": "private/config/wrapper/get_now.h" +"config_open_default_target": "private/config/wrapper/config_open_default_target.h" "config_gethostbyname": "private/config/wrapper/gethostbyname.h" "config_gethostname": "private/config/wrapper/gethostname.h" "config_getpagesize": "private/config/wrapper/getpagesize.h" From 8f933271e65fcaf8d8cbde6747e3300e2eb9109e Mon Sep 17 00:00:00 2001 From: rmknan Date: Fri, 15 Sep 2023 19:45:18 -0400 Subject: [PATCH 05/10] Made changes to wrapper.h --- include/private/config/wrapper.h | 21 --------------------- 1 file changed, 21 deletions(-) diff --git a/include/private/config/wrapper.h b/include/private/config/wrapper.h index 3ac7bb799..2d92e4f02 100644 --- a/include/private/config/wrapper.h +++ b/include/private/config/wrapper.h @@ -16,27 +16,6 @@ * limitations under the License. */ -#ifndef __STUMPLESS_PRIVATE_CONFIG_WRAPPER_H -# define __STUMPLESS_PRIVATE_CONFIG_WRAPPER_H -# include -/* definition of config_open_default_target */ -# ifdef STUMPLESS_WINDOWS_EVENT_LOG_TARGETS_SUPPORTED -# include "private/config/wel_supported.h" -# include "stumpless/target/wel.h" -# define config_open_default_target wel_open_default_target -# define config_close_default_target stumpless_close_wel_target -# elif STUMPLESS_SOCKET_TARGETS_SUPPORTED -# include -# include "private/config/socket_supported.h" -# define config_open_default_target socket_open_default_target -# define config_close_default_target stumpless_close_socket_target -# else -# include -# include "private/target/file.h" -# define config_open_default_target file_open_default_target -# define config_close_default_target stumpless_close_file_target -# endif -#endif /* __STUMPLESS_PRIVATE_CONFIG_WRAPPER_H */ From 900fb5dc085b6ea7b79e304482faa85906e53f9b Mon Sep 17 00:00:00 2001 From: rmknan Date: Fri, 15 Sep 2023 19:52:29 -0400 Subject: [PATCH 06/10] Made changes to target and stumpless.yml --- src/target.c | 2 +- tools/check_headers/stumpless.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/target.c b/src/target.c index 7f0820b9f..715346b17 100644 --- a/src/target.c +++ b/src/target.c @@ -39,7 +39,7 @@ #include "private/config.h" #include "private/config/network_support_wrapper.h" #include "private/config/locale/wrapper.h" -#include "private/config/wrapper.h" +// #include "private/config/wrapper.h" #include "private/config/wrapper/config_open_default_target.h" #include "private/config/wrapper/wel.h" #include "private/config/wrapper/journald.h" diff --git a/tools/check_headers/stumpless.yml b/tools/check_headers/stumpless.yml index 330987e3c..9197ee9e2 100644 --- a/tools/check_headers/stumpless.yml +++ b/tools/check_headers/stumpless.yml @@ -18,7 +18,7 @@ "CATEGORY_TREE": "docs/examples/wel/example_events.h" "clear_error": "private/error.h" "close_server_socket": "test/helper/server.hpp" -"config_close_default_target": "private/config/wrapper.h" +"config_close_default_target": "private/config/wrapper/config_open_default_target.h" "config_close_network_target": "private/config/network_support_wrapper.h" "config_close_tcp4_target": "private/config/network_support_wrapper.h" "config_close_udp4_target": "private/config/network_support_wrapper.h" From b64014469a5ed251dea12829caa7d1a5f6cb5c8e Mon Sep 17 00:00:00 2001 From: rmknan Date: Fri, 15 Sep 2023 20:05:52 -0400 Subject: [PATCH 07/10] Made changes to new header --- include/private/config/wrapper.h | 21 +++++++++++++++++++ .../config/wrapper/open_default_target.h | 1 + 2 files changed, 22 insertions(+) diff --git a/include/private/config/wrapper.h b/include/private/config/wrapper.h index 2d92e4f02..fd006fa31 100644 --- a/include/private/config/wrapper.h +++ b/include/private/config/wrapper.h @@ -16,6 +16,27 @@ * limitations under the License. */ +#ifndef __STUMPLESS_PRIVATE_CONFIG_WRAPPER_H +# define __STUMPLESS_PRIVATE_CONFIG_WRAPPER_H +// # include +// /* definition of config_open_default_target */ +// # ifdef STUMPLESS_WINDOWS_EVENT_LOG_TARGETS_SUPPORTED +// # include "private/config/wel_supported.h" +// # include "stumpless/target/wel.h" +// # define config_open_default_target wel_open_default_target +// # define config_close_default_target stumpless_close_wel_target +// # elif STUMPLESS_SOCKET_TARGETS_SUPPORTED +// # include +// # include "private/config/socket_supported.h" +// # define config_open_default_target socket_open_default_target +// # define config_close_default_target stumpless_close_socket_target +// # else +// # include +// # include "private/target/file.h" +// # define config_open_default_target file_open_default_target +// # define config_close_default_target stumpless_close_file_target +// # endif +// #endif /* __STUMPLESS_PRIVATE_CONFIG_WRAPPER_H */ diff --git a/include/private/config/wrapper/open_default_target.h b/include/private/config/wrapper/open_default_target.h index 0f05d1e25..76f79f321 100644 --- a/include/private/config/wrapper/open_default_target.h +++ b/include/private/config/wrapper/open_default_target.h @@ -19,6 +19,7 @@ #ifndef __STUMPLESS_PRIVATE_CONFIG_WRAPPER_CONFIG_OPEN_DEFAULT_TARGET_H # define __STUMPLESS_PRIVATE_CONFIG_WRAPPER_CONFIG_OPEN_DEFAULT_TARGET_H +# include /* definition of config_open_default_target */ # ifdef STUMPLESS_WINDOWS_EVENT_LOG_TARGETS_SUPPORTED From fc39738101f5c9b721fb92b6e0e3c1c9f38083dc Mon Sep 17 00:00:00 2001 From: rmknan Date: Fri, 15 Sep 2023 20:10:08 -0400 Subject: [PATCH 08/10] Made changes to stumpless.yml --- tools/check_headers/stumpless.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/check_headers/stumpless.yml b/tools/check_headers/stumpless.yml index 9197ee9e2..c409cc2c4 100644 --- a/tools/check_headers/stumpless.yml +++ b/tools/check_headers/stumpless.yml @@ -32,7 +32,7 @@ "config_init_udp4": "private/config/network_support_wrapper.h" "config_network_free_all": "private/config/network_support_wrapper.h" "config_network_target_is_open": "private/config/network_support_wrapper.h" -"config_open_default_target": "private/config/wrapper.h" +"config_open_default_target": "private/config/wrapper/config_open_default_target.h" "config_open_network_target": "private/config/network_support_wrapper.h" "config_open_tcp4_target": "private/config/network_support_wrapper.h" "config_open_udp4_target": "private/config/network_support_wrapper.h" From c2a9be63d9a1d8bff885e8cd15fe6296581a6cd2 Mon Sep 17 00:00:00 2001 From: rmknan Date: Fri, 15 Sep 2023 21:08:36 -0400 Subject: [PATCH 09/10] Working- All changes done --- include/private/config/wrapper.h | 42 ------------------- .../config/wrapper/open_default_target.h | 1 + src/target.c | 2 +- tools/check_headers/stumpless.yml | 11 +---- tools/check_headers/stumpless_private.yml | 1 - 5 files changed, 4 insertions(+), 53 deletions(-) delete mode 100644 include/private/config/wrapper.h diff --git a/include/private/config/wrapper.h b/include/private/config/wrapper.h deleted file mode 100644 index fd006fa31..000000000 --- a/include/private/config/wrapper.h +++ /dev/null @@ -1,42 +0,0 @@ -/* SPDX-License-Identifier: Apache-2.0 */ - -/* -* Copyright 2018-2022 Joel E. Anderson -* -* Licensed under the Apache License, Version 2.0 (the "License"); -* you may not use this file except in compliance with the License. -* You may obtain a copy of the License at -* -* http://www.apache.org/licenses/LICENSE-2.0 -* -* Unless required by applicable law or agreed to in writing, software -* distributed under the License is distributed on an "AS IS" BASIS, -* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -* See the License for the specific language governing permissions and -* limitations under the License. -*/ - -#ifndef __STUMPLESS_PRIVATE_CONFIG_WRAPPER_H -# define __STUMPLESS_PRIVATE_CONFIG_WRAPPER_H - -// # include - -// /* definition of config_open_default_target */ -// # ifdef STUMPLESS_WINDOWS_EVENT_LOG_TARGETS_SUPPORTED -// # include "private/config/wel_supported.h" -// # include "stumpless/target/wel.h" -// # define config_open_default_target wel_open_default_target -// # define config_close_default_target stumpless_close_wel_target -// # elif STUMPLESS_SOCKET_TARGETS_SUPPORTED -// # include -// # include "private/config/socket_supported.h" -// # define config_open_default_target socket_open_default_target -// # define config_close_default_target stumpless_close_socket_target -// # else -// # include -// # include "private/target/file.h" -// # define config_open_default_target file_open_default_target -// # define config_close_default_target stumpless_close_file_target -// # endif - -// #endif /* __STUMPLESS_PRIVATE_CONFIG_WRAPPER_H */ diff --git a/include/private/config/wrapper/open_default_target.h b/include/private/config/wrapper/open_default_target.h index 76f79f321..b4b2bf223 100644 --- a/include/private/config/wrapper/open_default_target.h +++ b/include/private/config/wrapper/open_default_target.h @@ -21,6 +21,7 @@ # include + /* definition of config_open_default_target */ # ifdef STUMPLESS_WINDOWS_EVENT_LOG_TARGETS_SUPPORTED # include "private/config/wel_supported.h" diff --git a/src/target.c b/src/target.c index 715346b17..708b24f38 100644 --- a/src/target.c +++ b/src/target.c @@ -40,7 +40,7 @@ #include "private/config/network_support_wrapper.h" #include "private/config/locale/wrapper.h" // #include "private/config/wrapper.h" -#include "private/config/wrapper/config_open_default_target.h" +#include "private/config/wrapper/open_default_target.h" #include "private/config/wrapper/wel.h" #include "private/config/wrapper/journald.h" #include "private/config/wrapper/socket.h" diff --git a/tools/check_headers/stumpless.yml b/tools/check_headers/stumpless.yml index c409cc2c4..dcddd109e 100644 --- a/tools/check_headers/stumpless.yml +++ b/tools/check_headers/stumpless.yml @@ -18,32 +18,25 @@ "CATEGORY_TREE": "docs/examples/wel/example_events.h" "clear_error": "private/error.h" "close_server_socket": "test/helper/server.hpp" -"config_close_default_target": "private/config/wrapper/config_open_default_target.h" +"config_close_default_target": "private/config/wrapper/open_default_target.h" "config_close_network_target": "private/config/network_support_wrapper.h" "config_close_tcp4_target": "private/config/network_support_wrapper.h" "config_close_udp4_target": "private/config/network_support_wrapper.h" -"config_copy_wel_fields": "private/config/wrapper.h" -"config_destroy_insertion_params": "private/config/wrapper.h" -"config_fopen": "private/config/wrapper.h" -"config_gethostname": "private/config/wrapper.h" "config_getpagesize": "private/config/wrapper/getpagesize.h" "config_get_now": "private/config/wrapper/get_now.h" "config_init_tcp4": "private/config/network_support_wrapper.h" "config_init_udp4": "private/config/network_support_wrapper.h" "config_network_free_all": "private/config/network_support_wrapper.h" "config_network_target_is_open": "private/config/network_support_wrapper.h" -"config_open_default_target": "private/config/wrapper/config_open_default_target.h" +"config_open_default_target": "private/config/wrapper/open_default_target.h" "config_open_network_target": "private/config/network_support_wrapper.h" "config_open_tcp4_target": "private/config/network_support_wrapper.h" "config_open_udp4_target": "private/config/network_support_wrapper.h" "config_reopen_tcp4_target": "private/config/network_support_wrapper.h" "config_reopen_udp4_target": "private/config/network_support_wrapper.h" -"config_send_entry_to_wel_target": "private/config/wrapper.h" "config_sendto_network_target": "private/config/network_support_wrapper.h" "config_sendto_tcp4_target": "private/config/network_support_wrapper.h" "config_sendto_udp4_target": "private/config/network_support_wrapper.h" -"config_set_tcp4_port": "private/config/wrapper.h" -"config_set_udp4_port": "private/config/wrapper.h" "config_socket_handle_t": "private/config/network_support_wrapper.h" "config_tcp4_is_open": "private/config/network_support_wrapper.h" "config_udp4_is_open": "private/config/network_support_wrapper.h" diff --git a/tools/check_headers/stumpless_private.yml b/tools/check_headers/stumpless_private.yml index 5d486a10a..7432c5e64 100644 --- a/tools/check_headers/stumpless_private.yml +++ b/tools/check_headers/stumpless_private.yml @@ -21,7 +21,6 @@ "config_format_string": "private/config/wrapper/format_string.h" "config_get_local_socket_name": "private/config/wrapper/socket.h" "config_get_now": "private/config/wrapper/get_now.h" -"config_open_default_target": "private/config/wrapper/config_open_default_target.h" "config_gethostbyname": "private/config/wrapper/gethostbyname.h" "config_gethostname": "private/config/wrapper/gethostname.h" "config_getpagesize": "private/config/wrapper/getpagesize.h" From c986a920020a9b340c2ced86047f4cff26698bf4 Mon Sep 17 00:00:00 2001 From: rmknan Date: Sat, 16 Sep 2023 15:56:54 -0400 Subject: [PATCH 10/10] made the requested changes --- include/private/config/wrapper/open_default_target.h | 6 +++--- src/target.c | 1 - 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/include/private/config/wrapper/open_default_target.h b/include/private/config/wrapper/open_default_target.h index b4b2bf223..29e5723d8 100644 --- a/include/private/config/wrapper/open_default_target.h +++ b/include/private/config/wrapper/open_default_target.h @@ -16,8 +16,8 @@ * limitations under the License. */ -#ifndef __STUMPLESS_PRIVATE_CONFIG_WRAPPER_CONFIG_OPEN_DEFAULT_TARGET_H -# define __STUMPLESS_PRIVATE_CONFIG_WRAPPER_CONFIG_OPEN_DEFAULT_TARGET_H +#ifndef __STUMPLESS_PRIVATE_CONFIG_WRAPPER_OPEN_DEFAULT_TARGET_H +# define __STUMPLESS_PRIVATE_CONFIG_WRAPPER_OPEN_DEFAULT_TARGET_H # include @@ -39,4 +39,4 @@ # define config_open_default_target file_open_default_target # define config_close_default_target stumpless_close_file_target # endif -#endif /* __STUMPLESS_PRIVATE_CONFIG_OPEN_DEFAULT_TARGET_H */ +#endif /* __STUMPLESS_PRIVATE_CONFIG_WRAPPER_OPEN_DEFAULT_TARGET_H */ diff --git a/src/target.c b/src/target.c index 708b24f38..9755a1d69 100644 --- a/src/target.c +++ b/src/target.c @@ -39,7 +39,6 @@ #include "private/config.h" #include "private/config/network_support_wrapper.h" #include "private/config/locale/wrapper.h" -// #include "private/config/wrapper.h" #include "private/config/wrapper/open_default_target.h" #include "private/config/wrapper/wel.h" #include "private/config/wrapper/journald.h"