-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PROD-30586: Hide blocked users in /all-members views. #4067
Merged
robertragas
merged 5 commits into
main
from
feature/PROD-30586-all-members-views-update
Sep 20, 2024
Merged
PROD-30586: Hide blocked users in /all-members views. #4067
robertragas
merged 5 commits into
main
from
feature/PROD-30586-all-members-views-update
Sep 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denis-getopensocial
added
type: bug
Fixes a bug in Open Social
status: needs review
This pull request is waiting for a requested review
prio: low
labels
Sep 9, 2024
robertragas
reviewed
Sep 12, 2024
robertragas
requested changes
Sep 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See remarks
So the issue here was the fact that views lost the current filters. |
robertragas
approved these changes
Sep 20, 2024
Everything fine now yes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
prio: low
status: needs review
This pull request is waiting for a requested review
team: guardians
type: bug
Fixes a bug in Open Social
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Users with Blocked status are displayed on the All Members page (
/all-members
).Solution
Update the views
/all-members
to hide blocked user.Issue tracker
https://getopensocial.atlassian.net/browse/PROD-30586
https://www.drupal.org/project/social/issues/3475825
Theme issue tracker
How to test
Screenshots
Release notes
Hide all blocked users from the view all members (/all-members).
Change Record
Translations