Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PROD-30586: Hide blocked users in /all-members views. #4067

Merged
merged 5 commits into from
Sep 20, 2024

Conversation

denis-getopensocial
Copy link
Contributor

@denis-getopensocial denis-getopensocial commented Sep 9, 2024

Problem

Users with Blocked status are displayed on the All Members page (/all-members).

Solution

Update the views /all-members to hide blocked user.

Issue tracker

https://getopensocial.atlassian.net/browse/PROD-30586
https://www.drupal.org/project/social/issues/3475825

Theme issue tracker

How to test

  • Create a user and set it blocked
  • Access /all-members
  • See that blocked users are not showing

Screenshots

Release notes

Hide all blocked users from the view all members (/all-members).

Change Record

Translations

@denis-getopensocial denis-getopensocial added type: bug Fixes a bug in Open Social status: needs review This pull request is waiting for a requested review prio: low labels Sep 9, 2024
@denis-getopensocial denis-getopensocial requested a review from a team September 9, 2024 12:57
@denis-getopensocial denis-getopensocial added this to the 13.0.0-alpha12 milestone Sep 9, 2024
@BiaInacio
Copy link
Contributor

Blocked users are not being shown on All members page!
image

@robertragas
Copy link
Contributor

Another remark is that the old view had multiple filters
Screenshot 2024-09-12 at 10 31 23
and the new one not anymore
Screenshot 2024-09-12 at 10 29 00
so this causes the admin to be visible there
Screenshot 2024-09-12 at 10 51 10

Copy link
Contributor

@robertragas robertragas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See remarks

@denis-getopensocial
Copy link
Contributor Author

denis-getopensocial commented Sep 16, 2024

So the issue here was the fact that views lost the current filters.
After adding a new filter I saw all previous filter appeared. So I remove my filter that already existed, and exported the view again and everything looked fine.

@robertragas
Copy link
Contributor

Everything fine now yes!

@robertragas robertragas merged commit 0641946 into main Sep 20, 2024
190 checks passed
@robertragas robertragas deleted the feature/PROD-30586-all-members-views-update branch September 20, 2024 14:18
@goalgorilla goalgorilla deleted a comment from github-actions bot Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
prio: low status: needs review This pull request is waiting for a requested review team: guardians type: bug Fixes a bug in Open Social
Development

Successfully merging this pull request may close these issues.

3 participants