Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add status object to plugin #9

Merged
merged 1 commit into from
Feb 12, 2020
Merged

feat: add status object to plugin #9

merged 1 commit into from
Feb 12, 2020

Conversation

jbrockopp
Copy link
Contributor

No description provided.

@jbrockopp jbrockopp added the feature Indicates a new feature label Feb 12, 2020
@jbrockopp jbrockopp requested a review from a team as a code owner February 12, 2020 14:29
@jbrockopp jbrockopp self-assigned this Feb 12, 2020
@jbrockopp jbrockopp mentioned this pull request Feb 12, 2020
Closed
@codecov
Copy link

codecov bot commented Feb 12, 2020 •
edited
Loading

Codecov Report

Merging #9 into master will increase coverage by 1.56%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #9      +/-   ##
==========================================
+ Coverage   52.68%   54.24%   +1.56%     
==========================================
  Files           5        6       +1     
  Lines         205      212       +7     
==========================================
+ Hits          108      115       +7     
  Misses         97       97
Impacted Files Coverage Δ
cmd/vela-kubernetes/status.go 100% <100%> (ø)

plyr4
plyr4 approved these changes Feb 12, 2020
View reviewed changes
Copy link
Contributor

@plyr4 plyr4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@plyr4 plyr4 merged commit e18be28 into master Feb 12, 2020
@plyr4 plyr4 deleted the feature/status branch February 12, 2020 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plyr4 plyr4 plyr4 approved these changes

@kneal kneal kneal approved these changes

Assignees

@jbrockopp jbrockopp

Labels
feature Indicates a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jbrockopp @kneal @plyr4