Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add validate logic for plugin #7

Merged
merged 2 commits into from
Feb 11, 2020
Merged

feat: add validate logic for plugin #7

merged 2 commits into from
Feb 11, 2020

Conversation

jbrockopp
Copy link
Contributor

No description provided.

@jbrockopp jbrockopp added the feature Indicates a new feature label Feb 11, 2020
@jbrockopp jbrockopp requested a review from a team as a code owner February 11, 2020 18:17
@jbrockopp jbrockopp self-assigned this Feb 11, 2020
@jbrockopp jbrockopp mentioned this pull request Feb 11, 2020
Closed
@codecov
Copy link

codecov bot commented Feb 11, 2020 •
edited
Loading

Codecov Report

Merging #7 into master will decrease coverage by 8.75%.
The diff coverage is 35.13%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #7      +/-   ##
==========================================
- Coverage   59.01%   50.25%   -8.76%     
==========================================
  Files           3        5       +2     
  Lines         122      195      +73     
==========================================
+ Hits           72       98      +26     
- Misses         50       97      +47
Impacted Files Coverage Δ
cmd/vela-kubernetes/main.go 0% <0%> (ø) ⬆️
cmd/vela-kubernetes/config.go 100% <100%> (ø)
cmd/vela-kubernetes/kubernetes.go 100% <100%> (ø)
cmd/vela-kubernetes/plugin.go 100% <100%> (ø) ⬆️

kneal
kneal approved these changes Feb 11, 2020
View reviewed changes
Copy link
Contributor

@kneal kneal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐬

@jbrockopp jbrockopp merged commit 18cf45e into master Feb 11, 2020
@jbrockopp jbrockopp deleted the feat/validate branch February 11, 2020 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kneal kneal kneal approved these changes

Assignees

@jbrockopp jbrockopp

Labels
feature Indicates a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jbrockopp @kneal