Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(config): create dir path before file write #30

Merged
merged 1 commit into from
Feb 21, 2020
Merged

fix(config): create dir path before file write #30

merged 1 commit into from
Feb 21, 2020

Conversation

jbrockopp
Copy link
Contributor

No description provided.

@jbrockopp jbrockopp added the bug Indicates a bug label Feb 21, 2020
@jbrockopp jbrockopp requested a review from a team as a code owner February 21, 2020 17:54
@jbrockopp jbrockopp self-assigned this Feb 21, 2020
@jbrockopp jbrockopp mentioned this pull request Feb 21, 2020
Closed
@codecov
Copy link

codecov bot commented Feb 21, 2020 •
edited
Loading

Codecov Report

Merging #30 into master will increase coverage by 0.43%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #30      +/-   ##
==========================================
+ Coverage   49.85%   50.28%   +0.43%     
==========================================
  Files           8        8              
  Lines         343      346       +3     
==========================================
+ Hits          171      174       +3     
  Misses        171      171              
  Partials        1        1
Impacted Files Coverage Δ
cmd/vela-kubernetes/config.go 100% <100%> (ø) ⬆️

kneal
kneal approved these changes Feb 21, 2020
View reviewed changes
Copy link
Contributor

@kneal kneal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐬

plyr4
plyr4 approved these changes Feb 21, 2020
View reviewed changes
Copy link
Contributor

@plyr4 plyr4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@plyr4 plyr4 merged commit 9f51697 into master Feb 21, 2020
@plyr4 plyr4 deleted the fix/config/write branch February 21, 2020 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plyr4 plyr4 plyr4 approved these changes

@kneal kneal kneal approved these changes

Assignees

@jbrockopp jbrockopp

Labels
bug Indicates a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jbrockopp @kneal @plyr4