Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add action for plugin #28

Merged
merged 1 commit into from
Feb 21, 2020
Merged

feat: add action for plugin #28

merged 1 commit into from
Feb 21, 2020

Conversation

jbrockopp
Copy link
Contributor

No description provided.

@jbrockopp jbrockopp added the feature Indicates a new feature label Feb 21, 2020
@jbrockopp jbrockopp requested a review from a team as a code owner February 21, 2020 16:28
@jbrockopp jbrockopp self-assigned this Feb 21, 2020
@jbrockopp jbrockopp mentioned this pull request Feb 21, 2020
Closed
kneal
kneal approved these changes Feb 21, 2020
View reviewed changes
Copy link
Contributor

@kneal kneal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐬

@codecov
Copy link

codecov bot commented Feb 21, 2020 •
edited
Loading

Codecov Report

Merging #28 into master will decrease coverage by 0.6%.
The diff coverage is 45%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #28      +/-   ##
==========================================
- Coverage   50.45%   49.85%   -0.61%     
==========================================
  Files           8        8              
  Lines         327      343      +16     
==========================================
+ Hits          165      171       +6     
- Misses        161      171      +10     
  Partials        1        1
Impacted Files Coverage Δ
cmd/vela-kubernetes/status.go 96.77% <ø> (ø) ⬆️
cmd/vela-kubernetes/apply.go 96.42% <ø> (ø) ⬆️
cmd/vela-kubernetes/patch.go 97.87% <ø> (ø) ⬆️
cmd/vela-kubernetes/main.go 0% <0%> (ø) ⬆️
cmd/vela-kubernetes/config.go 100% <100%> (ø) ⬆️
cmd/vela-kubernetes/plugin.go 60% <50%> (-2.17%) ⬇️

@jbrockopp jbrockopp merged commit cb8cb16 into master Feb 21, 2020
@jbrockopp jbrockopp deleted the feature/config/action branch February 21, 2020 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meinenec meinenec meinenec approved these changes

@kneal kneal kneal approved these changes

Assignees

@jbrockopp jbrockopp

Labels
feature Indicates a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jbrockopp @kneal @meinenec