Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: enable providing custom output #17

Merged
merged 1 commit into from
Feb 13, 2020
Merged

feat: enable providing custom output #17

merged 1 commit into from
Feb 13, 2020

Conversation

jbrockopp
Copy link
Contributor

No description provided.

@jbrockopp jbrockopp added the feature Indicates a new feature label Feb 13, 2020
@jbrockopp jbrockopp requested a review from a team as a code owner February 13, 2020 18:35
@jbrockopp jbrockopp self-assigned this Feb 13, 2020
@jbrockopp jbrockopp mentioned this pull request Feb 13, 2020
Closed
@codecov
Copy link

codecov bot commented Feb 13, 2020 •
edited
Loading

Codecov Report

Merging #17 into master will decrease coverage by 2.75%.
The diff coverage is 21.05%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #17      +/-   ##
==========================================
- Coverage   58.89%   56.13%   -2.76%     
==========================================
  Files           7        7              
  Lines         253      269      +16     
==========================================
+ Hits          149      151       +2     
- Misses        104      118      +14
Impacted Files Coverage Δ
cmd/vela-kubernetes/main.go 0% <0%> (ø) ⬆️
cmd/vela-kubernetes/patch.go 97.77% <100%> (+0.05%) ⬆️
cmd/vela-kubernetes/apply.go 96.15% <100%> (+0.15%) ⬆️

@codecov
Copy link

codecov bot commented Feb 13, 2020

Codecov Report

Merging #17 into master will decrease coverage by 2.75%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #17      +/-   ##
==========================================
- Coverage   58.89%   56.13%   -2.76%     
==========================================
  Files           7        7              
  Lines         253      269      +16     
==========================================
+ Hits          149      151       +2     
- Misses        104      118      +14

plyr4
plyr4 approved these changes Feb 13, 2020
View reviewed changes
Copy link
Contributor

@plyr4 plyr4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wass3r wass3r merged commit 590ed39 into master Feb 13, 2020
@wass3r wass3r deleted the feature/output branch February 13, 2020 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plyr4 plyr4 plyr4 approved these changes

@wass3r wass3r wass3r approved these changes

Assignees

@jbrockopp jbrockopp

Labels
feature Indicates a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jbrockopp @wass3r @plyr4