Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(svg): simplify SvgBuilder.elm #54

Merged
merged 5 commits into from
Dec 18, 2019
Merged

refactor(svg): simplify SvgBuilder.elm #54

merged 5 commits into from
Dec 18, 2019

Conversation

plyr4
Copy link
Contributor

@plyr4 plyr4 commented Dec 17, 2019

No description provided.

@plyr4 plyr4 requested a review from a team as a code owner December 17, 2019 18:50
wass3r
wass3r approved these changes Dec 18, 2019
View reviewed changes
Copy link
Collaborator

@wass3r wass3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kneal
kneal approved these changes Dec 18, 2019
View reviewed changes
Copy link
Contributor

@kneal kneal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐬

@kneal kneal merged commit c9cdf56 into master Dec 18, 2019
@kneal kneal deleted the refactor_svg_prep branch December 18, 2019 21:01
@wass3r wass3r added the enhancement Indicates an improvement to a feature label Dec 18, 2019
plyr4 added a commit that referenced this pull request Aug 19, 2022
@plyr4
refactor(svg): simplify SvgBuilder.elm (#54)
b9cf2da
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kneal kneal kneal approved these changes

@wass3r wass3r wass3r approved these changes

Assignees
No one assigned
Labels
enhancement Indicates an improvement to a feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@plyr4 @wass3r @kneal