Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing holes from polygons #150

Closed
pnorman opened this issue Sep 27, 2017 · 6 comments
Closed

Missing holes from polygons #150

pnorman opened this issue Sep 27, 2017 · 6 comments
Labels
Milestone

Comments

@pnorman
Copy link
Contributor

pnorman commented Sep 27, 2017

With the configuration

[webserver]
port = ":9090"

[[providers]]
name = "vector_demo"	# provider name is referenced from map layers
type = "postgis"		# the type of data provider. currently only supports postgis
host = "/var/run/postgresql"		# postgis database host
port = 5432				# postgis database port
database = "osmcarto_bc" 	# postgis database name
user = "pnorman"
password = ""

  [[providers.layers]]
  name = "water-lz"
  geometry_fieldname = "way"
  id_fieldname = "osm_id"
  sql = """
  SELECT
      0 AS osm_id,
      ST_AsBinary(way) AS way,
      'ocean' AS water
    FROM ne_ocean
    WHERE way && !BBOX!
  UNION ALL
  SELECT
      0 AS osm_id,
      ST_AsBinary(way) AS way,
      'lake' AS water
    FROM ne_lake
    WHERE way && !BBOX!
  """

[[maps]]
name = "vector_demo"
[[maps.layers]]
provider_layer = "vector_demo.water-lz"
min_zoom = 0
max_zoom = 5

I get

image

The problem is the missing Americas.

Not being sure if this was a problem with the qgis vector tile plugin, I downloaded the 2/0/1 tile and converted it to geojson with vt2geojson. I got the same problem.

@pnorman
Copy link
Contributor Author

pnorman commented Sep 27, 2017

Note: I've included the output tiles in a comment on geometalab/Vector-Tiles-Reader-QGIS-Plugin#81 (comment)

@ARolek
Copy link
Member

ARolek commented Sep 29, 2017

@pnorman what version of tegola are you using? v0.4.0-alpha? This could be a clipping issue that's being addressed on issue-56 branch. That one is just about ready to be merged into v0.4.0

@pnorman
Copy link
Contributor Author

pnorman commented Sep 29, 2017

@pnorman what version of tegola are you using? v0.4.0-alpha?

Yes

@ARolek
Copy link
Member

ARolek commented Oct 1, 2017

@pnorman ok. I think this is fixed on the issue-56 (#56) branch which is going through a round of performance optimizations right now. It looks like you're using an OSM dataset. Is this the water polygons? If not, can you send me a link to the dataset so I can run a test?

@pnorman
Copy link
Contributor Author

pnorman commented Oct 1, 2017

No, there's no OSM data at that zoom, just natural earth.

https://github.com/pnorman/vector_tile_engines/tree/master/loading has the scripts to load the data. You can ignore the osm2pgsql stuff

@ARolek
Copy link
Member

ARolek commented Nov 1, 2017

@pnorman can you try the new release of tegola (v0.4.0-rc1) to see if this issue has been addressed?

@ARolek ARolek added this to the v0.4.0 milestone Nov 1, 2017
@ARolek ARolek added the bug label Nov 1, 2017
@ARolek ARolek closed this as completed Nov 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants