Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance the as_numeric(text) Postgres helper to support different building height representations #58

Open
ARolek opened this issue Jun 11, 2020 · 2 comments

Comments

@ARolek
Copy link
Member

ARolek commented Jun 11, 2020

The as_numeric function is really primitive right now. It's mainly used for converting building heights in text format to numeric format so the values can be used for building extrusions when rendered. OSM has various ways to represent heights per: https://wiki.openstreetmap.org/wiki/Key:height. A new function should be put together than handles the various OSM height formats and also allows for conversion between meters / feet.

@ARolek
Copy link
Member Author

ARolek commented Jun 11, 2020

Here's an example of of a building that has levels and a height: https://www.openstreetmap.org/way/51185380

@jj0hns0n
Copy link
Contributor

We should also handle for levels=n and use some standard conversion on average height of a building storey/floor etc (https://en.wikipedia.org/wiki/Storey#:~:text=The%20height%20of%20each%20storey,figure%20to%20well%20over%20it).

OSM's guidance is that levels should only be used with height and not instead of, but many buildings only have levels.

buildingheights

An example of where things may be complicated https://www.openstreetmap.org/way/362187535 where the levels = 63 and the height only 10.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants