Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Support cos #185

Merged
merged 3 commits into from
Aug 22, 2023
Merged

✨ Support cos #185

merged 3 commits into from
Aug 22, 2023

Conversation

tosone
Copy link
Contributor

@tosone tosone commented Aug 21, 2023

No description provided.

@tosone tosone added the enhancement New feature or request label Aug 21, 2023
@tosone tosone added this to the Release v0.1.0 milestone Aug 21, 2023
@tosone tosone self-assigned this Aug 21, 2023
@tosone tosone changed the title ✨ Add cos support ✨ Support cos Aug 22, 2023
@tosone tosone force-pushed the dev-cos branch 2 times, most recently from 0613ebd to e2da7f9 Compare August 22, 2023 14:16
@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Patch coverage: 58.91% and project coverage change: +0.10% 🎉

Comparison is base (b8e3dca) 52.31% compared to head (f3ede93) 52.42%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #185      +/-   ##
==========================================
+ Coverage   52.31%   52.42%   +0.10%     
==========================================
  Files         118      118              
  Lines        6195     6297     +102     
==========================================
+ Hits         3241     3301      +60     
- Misses       2690     2722      +32     
- Partials      264      274      +10     
Flag Coverage Δ
unit-test-mysql 52.42% <58.91%> (+0.10%) ⬆️
unit-test-postgresql 52.42% <58.91%> (+0.10%) ⬆️
unit-test-sqlite3 52.42% <58.91%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
pkg/configs/configuration.go 0.00% <ø> (ø)
pkg/storage/cos/cos.go 51.53% <47.65%> (+46.40%) ⬆️
pkg/storage/filesystem/filesystem.go 51.85% <72.22%> (-2.36%) ⬇️
pkg/storage/s3/s3.go 84.75% <100.00%> (-0.51%) ⬇️
pkg/storage/storage.go 85.18% <100.00%> (+3.36%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tosone tosone enabled auto-merge August 22, 2023 14:24
@tosone tosone added this pull request to the merge queue Aug 22, 2023
@tosone tosone removed this pull request from the merge queue due to a manual request Aug 22, 2023
@tosone tosone enabled auto-merge August 22, 2023 14:38
@tosone tosone added this pull request to the merge queue Aug 22, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 22, 2023
@tosone tosone added this pull request to the merge queue Aug 22, 2023
Merged via the queue into main with commit 20718db Aug 22, 2023
11 checks passed
@tosone tosone deleted the dev-cos branch August 22, 2023 15:48
@tosone tosone mentioned this pull request Sep 4, 2023
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants