fix: do not use errors.Join, just use custom error approach #863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v2 #863 +/- ##
==========================================
- Coverage 96.23% 96.15% -0.09%
==========================================
Files 14 14
Lines 1808 1821 +13
==========================================
+ Hits 1740 1751 +11
- Misses 45 46 +1
- Partials 23 24 +1 ☔ View full report in Codecov by Sentry. |
Michsior14
referenced
this pull request
in Michsior14/transmission-gluetun-port-update
Sep 22, 2024
This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/go-resty/resty/v2](https://redirect.github.com/go-resty/resty) | `v2.15.1` -> `v2.15.2` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>go-resty/resty (github.com/go-resty/resty/v2)</summary> ### [`v2.15.2`](https://redirect.github.com/go-resty/resty/releases/tag/v2.15.2) [Compare Source](https://redirect.github.com/go-resty/resty/compare/v2.15.1...v2.15.2) ### Release Notes #### Bug Fixes - fix: do not use `errors.Join`, just use custom error approach by [@​jeevatkm](https://redirect.github.com/jeevatkm) in [https://github.com/go-resty/resty/pull/863](https://redirect.github.com/go-resty/resty/pull/863) #### Documentation - release: version bump and readme update for v2.15.2 by [@​jeevatkm](https://redirect.github.com/jeevatkm) in [https://github.com/go-resty/resty/pull/864](https://redirect.github.com/go-resty/resty/pull/864) **Full Changelog**: go-resty/resty@v2.15.1...v2.15.2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/Michsior14/transmission-gluetun-port-update). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC44MC4wIiwidXBkYXRlZEluVmVyIjoiMzguODAuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiZGVwZW5kZW5jaWVzIl19--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it turns out,
errors.Joinis not playing well with simple errors likeerrors.Neworfmt.Errorf. For now, let's go with a custom error withUnwrap.