Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change resty.GET to resty.MethodGet in doc comment #803

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

autopp
Copy link
Contributor

@autopp autopp commented Jul 9, 2024

This PR fixes doc comment of Request.Send() and Request.Execute().
resty.GET is renamed to resty.MethodGet at f990acd.
However, these comments were left out.doc comment.

Copy link
Member

@jeevatkm jeevatkm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@autopp Thanks for correcting the docs.

Copy link

codecov bot commented Jul 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.67%. Comparing base (30477b3) to head (e0fe8ab).

Additional details and impacted files
@@           Coverage Diff           @@
##               v2     #803   +/-   ##
=======================================
  Coverage   96.67%   96.67%           
=======================================
  Files          14       14           
  Lines        1742     1742           
=======================================
  Hits         1684     1684           
  Misses         37       37           
  Partials       21       21           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jeevatkm jeevatkm merged commit d8fbff6 into go-resty:v2 Jul 17, 2024
3 checks passed
@jeevatkm jeevatkm added this to the v2.14.0 milestone Jul 18, 2024
renovate bot referenced this pull request in Michsior14/transmission-gluetun-port-update Aug 5, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [github.com/go-resty/resty/v2](https://togithub.com/go-resty/resty) |
`v2.13.1` -> `v2.14.0` |
[![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fgo-resty%2fresty%2fv2/v2.14.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fgo-resty%2fresty%2fv2/v2.14.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fgo-resty%2fresty%2fv2/v2.13.1/v2.14.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fgo-resty%2fresty%2fv2/v2.13.1/v2.14.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>go-resty/resty (github.com/go-resty/resty/v2)</summary>

###
[`v2.14.0`](https://togithub.com/go-resty/resty/releases/tag/v2.14.0)

[Compare
Source](https://togithub.com/go-resty/resty/compare/v2.13.1...v2.14.0)

### Release Notes

#### New Features

- feat(curl): generate curl cmd for request && example for curl cmd by
[@&#8203;ahuigo](https://togithub.com/ahuigo) in
[https://github.com/go-resty/resty/pull/794](https://togithub.com/go-resty/resty/pull/794)

#### Enhancements

- build: update bazel config with new files by
[@&#8203;jeevatkm](https://togithub.com/jeevatkm) in
[https://github.com/go-resty/resty/pull/800](https://togithub.com/go-resty/resty/pull/800)
- chore: dependency and version update v2.14.0 by
[@&#8203;jeevatkm](https://togithub.com/jeevatkm) in
[https://github.com/go-resty/resty/pull/816](https://togithub.com/go-resty/resty/pull/816)

#### Upstream Fixes

- update net package for vuln CVE-2023-45288 by
[@&#8203;shedyfreak](https://togithub.com/shedyfreak) in
[https://github.com/go-resty/resty/pull/804](https://togithub.com/go-resty/resty/pull/804)

#### Test Cases

- fix(examples): wrongly stderr written as stdout by
[@&#8203;ahuigo](https://togithub.com/ahuigo) in
[https://github.com/go-resty/resty/pull/801](https://togithub.com/go-resty/resty/pull/801)

#### Documentation

- fix: change resty.GET to resty.MethodGet in doc comment by
[@&#8203;autopp](https://togithub.com/autopp) in
[https://github.com/go-resty/resty/pull/803](https://togithub.com/go-resty/resty/pull/803)
- resty dev version number and year update by
[@&#8203;jeevatkm](https://togithub.com/jeevatkm) in
[https://github.com/go-resty/resty/pull/799](https://togithub.com/go-resty/resty/pull/799)

#### New Contributors

- [@&#8203;ahuigo](https://togithub.com/ahuigo) made their first
contribution in
[https://github.com/go-resty/resty/pull/794](https://togithub.com/go-resty/resty/pull/794)
- [@&#8203;autopp](https://togithub.com/autopp) made their first
contribution in
[https://github.com/go-resty/resty/pull/803](https://togithub.com/go-resty/resty/pull/803)
- [@&#8203;shedyfreak](https://togithub.com/shedyfreak) made their first
contribution in
[https://github.com/go-resty/resty/pull/804](https://togithub.com/go-resty/resty/pull/804)

**Full Changelog**:
go-resty/resty@v2.13.1...v2.14.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View the
[repository job
log](https://developer.mend.io/github/Michsior14/transmission-gluetun-port-update).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40NDAuNyIsInVwZGF0ZWRJblZlciI6IjM3LjQ0MC43IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiXX0=-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants