Fix digest auth #789
Merged
Fix digest auth #789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reimplement parsing of digest auth challenge to handle cases where the values of key/value pairs contain commas, such as in qop="auth, auth-int"
The digest auth qop validation did only handle values separated like "auth, auth-int", but not "auth,auth-int".
jeevatkm
approved these changes
Apr 16, 2024
Michsior14
referenced
this pull request
in Michsior14/transmission-gluetun-port-update
May 9, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/go-resty/resty/v2](https://togithub.com/go-resty/resty) | `v2.12.0` -> `v2.13.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>go-resty/resty (github.com/go-resty/resty/v2)</summary> ### [`v2.13.0`](https://togithub.com/go-resty/resty/releases/tag/v2.13.0) [Compare Source](https://togithub.com/go-resty/resty/compare/v2.12.0...v2.13.0) ### Release Notes #### Enhancements - build: update github actions by [@​segevda](https://togithub.com/segevda) in [https://github.com/go-resty/resty/pull/785](https://togithub.com/go-resty/resty/pull/785) - update dependency golang.org/x/net and codecov ci integration by [@​jeevatkm](https://togithub.com/jeevatkm) in [https://github.com/go-resty/resty/pull/792](https://togithub.com/go-resty/resty/pull/792) #### Bug Fixes - fix: digest auth by [@​phw](https://togithub.com/phw) in [https://github.com/go-resty/resty/pull/789](https://togithub.com/go-resty/resty/pull/789) #### New Contributors - [@​phw](https://togithub.com/phw) made their first contribution in [https://github.com/go-resty/resty/pull/789](https://togithub.com/go-resty/resty/pull/789) **Full Changelog**: go-resty/resty@v2.12.0...v2.13.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/Michsior14/transmission-gluetun-port-update). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNDAuMTAiLCJ1cGRhdGVkSW5WZXIiOiIzNy4zNDAuMTAiLCJ0YXJnZXRCcmFuY2giOiJtYWluIiwibGFiZWxzIjpbImRlcGVuZGVuY2llcyJdfQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
renovate bot
referenced
this pull request
in anza-labs/lke-operator
May 14, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/go-resty/resty/v2](https://togithub.com/go-resty/resty) | `v2.12.0` -> `v2.13.1` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>go-resty/resty (github.com/go-resty/resty/v2)</summary> ### [`v2.13.1`](https://togithub.com/go-resty/resty/releases/tag/v2.13.1) [Compare Source](https://togithub.com/go-resty/resty/compare/v2.13.0...v2.13.1) ### Release Notes #### Fixes - fix: correct resty version number which was missed in the previous release by [@​jeevatkm](https://togithub.com/jeevatkm) in [https://github.com/go-resty/resty/pull/793](https://togithub.com/go-resty/resty/pull/793) **Full Changelog**: go-resty/resty@v2.13.0...v2.13.1 ### [`v2.13.0`](https://togithub.com/go-resty/resty/releases/tag/v2.13.0) [Compare Source](https://togithub.com/go-resty/resty/compare/v2.12.0...v2.13.0) ### Release Notes #### Enhancements - build: update github actions by [@​segevda](https://togithub.com/segevda) in [https://github.com/go-resty/resty/pull/785](https://togithub.com/go-resty/resty/pull/785) - update dependency golang.org/x/net and codecov ci integration by [@​jeevatkm](https://togithub.com/jeevatkm) in [https://github.com/go-resty/resty/pull/792](https://togithub.com/go-resty/resty/pull/792) #### Bug Fixes - fix: digest auth by [@​phw](https://togithub.com/phw) in [https://github.com/go-resty/resty/pull/789](https://togithub.com/go-resty/resty/pull/789) #### New Contributors - [@​phw](https://togithub.com/phw) made their first contribution in [https://github.com/go-resty/resty/pull/789](https://togithub.com/go-resty/resty/pull/789) **Full Changelog**: go-resty/resty@v2.12.0...v2.13.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/anza-labs/lke-operator). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNTEuMiIsInVwZGF0ZWRJblZlciI6IjM3LjM1MS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJhcmVhL2RlcGVuZGVuY3kiXX0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This re-implements parsing the digest challenge to fix authentication against servers returning multiple values for
qop.Take this example from https://httpwg.org/specs/rfc7616.html:
Here qop is set to
qop="auth, auth-int". Because the previous parser split the entire list by comma to obtain the key value pairs this gets separated intoqop="authandauth-int", which eventually failes to parse.The new parser goes over the challenge rune by rune and does not split when inside a quotation.
Also some servers will respond with
qop="auth,auth-int"(no space after the comma). Hence also adjustvalidateQopto handle this.