Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Improve Digest WWW-Authenticate response header parsing compatibility #735

Merged
merged 2 commits into from
Dec 27, 2023

Conversation

bearki
Copy link
Contributor

@bearki bearki commented Oct 17, 2023

Improve Digest WWW-Authenticate response header parsing compatibility

  1. Use commas to disassemble WWW-Authenticate instead of commas and spaces.
  2. Clear the spaces before and after each key-value pair.
  3. Added double quote clearing operation for stale and algorithm values.

Copy link

codecov bot commented Dec 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (577fed8) 96.51% compared to head (d03ba41) 96.52%.

Additional details and impacted files
@@           Coverage Diff           @@
##               v2     #735   +/-   ##
=======================================
  Coverage   96.51%   96.52%           
=======================================
  Files          12       12           
  Lines        1636     1639    +3     
=======================================
+ Hits         1579     1582    +3     
  Misses         36       36           
  Partials       21       21           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jeevatkm jeevatkm added this to the v2.11.0 Milestone milestone Dec 27, 2023
Copy link
Member

@jeevatkm jeevatkm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bearki Thanks for the PR, appreciated.

@jeevatkm jeevatkm merged commit 74050fd into go-resty:v2 Dec 27, 2023
3 checks passed
Michsior14 referenced this pull request in Michsior14/transmission-gluetun-port-update Dec 30, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [github.com/go-resty/resty/v2](https://togithub.com/go-resty/resty) |
`v2.10.0` -> `v2.11.0` |
[![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fgo-resty%2fresty%2fv2/v2.11.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fgo-resty%2fresty%2fv2/v2.11.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fgo-resty%2fresty%2fv2/v2.10.0/v2.11.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fgo-resty%2fresty%2fv2/v2.10.0/v2.11.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>go-resty/resty (github.com/go-resty/resty/v2)</summary>

###
[`v2.11.0`](https://togithub.com/go-resty/resty/releases/tag/v2.11.0):
Release

[Compare
Source](https://togithub.com/go-resty/resty/compare/v2.10.0...v2.11.0)

### Release Notes

#### Bug Fixes

- Security: Don't put the same bytes.Buffer into sync.Pool twice by
[@&#8203;lattwood](https://togithub.com/lattwood) in
[https://github.com/go-resty/resty/pull/745](https://togithub.com/go-resty/resty/pull/745),
[#&#8203;764](https://togithub.com/go-resty/resty/issues/764),
[#&#8203;756](https://togithub.com/go-resty/resty/issues/756)
- fix: Improve Digest WWW-Authenticate response header parsing
compatibility by [@&#8203;bearki](https://togithub.com/bearki) in
[https://github.com/go-resty/resty/pull/735](https://togithub.com/go-resty/resty/pull/735)

#### New Contributors

- [@&#8203;lattwood](https://togithub.com/lattwood) made their first
contribution in
[https://github.com/go-resty/resty/pull/745](https://togithub.com/go-resty/resty/pull/745)
- [@&#8203;bearki](https://togithub.com/bearki) made their first
contribution in
[https://github.com/go-resty/resty/pull/735](https://togithub.com/go-resty/resty/pull/735)

**Full Changelog**:
go-resty/resty@v2.10.0...v2.11.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/Michsior14/transmission-gluetun-port-update).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMDMuMSIsInVwZGF0ZWRJblZlciI6IjM3LjEwMy4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@bearki bearki deleted the debug-v2-digest branch January 2, 2024 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants