Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #164 #165

Merged
merged 2 commits into from
Jun 26, 2018
Merged

fix #164 #165

merged 2 commits into from
Jun 26, 2018

Conversation

Jack47
Copy link
Contributor

@Jack47 Jack47 commented Jun 26, 2018

don't use gziped reader when response content-length is zero

1. gziped empty response, content-length will not be empty, because of
gzip header
2. no gziped body at all, content-length is zero
@codecov
Copy link

codecov bot commented Jun 26, 2018

Codecov Report

Merging #165 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #165   +/-   ##
=======================================
  Coverage   96.22%   96.22%           
=======================================
  Files           9        9           
  Lines        1061     1061           
=======================================
  Hits         1021     1021           
  Misses         22       22           
  Partials       18       18
Impacted Files Coverage Δ
client.go 96.98% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6e6c4b...fe48d70. Read the comment docs.

@jeevatkm jeevatkm self-requested a review June 26, 2018 18:50
@jeevatkm jeevatkm added the bug label Jun 26, 2018
@jeevatkm jeevatkm added this to the v1.7 Milestone milestone Jun 26, 2018
Copy link
Member

@jeevatkm jeevatkm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Jack47 Thank you for the PR.

@jeevatkm jeevatkm merged commit 59cee09 into go-resty:master Jun 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants