Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

createClient overrides http.Transport #146

Closed
turboezh opened this issue Apr 19, 2018 · 2 comments
Closed

createClient overrides http.Transport #146

turboezh opened this issue Apr 19, 2018 · 2 comments
Assignees
Labels

Comments

@turboezh
Copy link

This line overrides Transport in custom http.Client.

c.SetTransport(&http.Transport{})

I think this line should be removed, it has no sense because transport already embedded in client.

In my case I lost proxy settings from my own http.Client.

@jeevatkm jeevatkm self-assigned this Apr 19, 2018
@jeevatkm jeevatkm added the bug label Apr 19, 2018
@jeevatkm jeevatkm added this to the v1.5 Milestone milestone Apr 19, 2018
@jeevatkm
Copy link
Member

@turboezh Nice catch, thanks. It seems I missed this part when I introduced feature of accepting client. I will correct it.

jeevatkm added a commit that referenced this issue Apr 20, 2018
@jeevatkm
Copy link
Member

@turboezh I have corrected it on edge, to be released in v1.5. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants