Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TestNormalize fails with Go 1.19 #157

Closed
jawn-smith opened this issue Aug 11, 2022 · 0 comments · Fixed by #158
Closed

TestNormalize fails with Go 1.19 #157

jawn-smith opened this issue Aug 11, 2022 · 0 comments · Fixed by #158

Comments

@jawn-smith
Copy link

Go 1.19 treats file paths that have file:/ rather than file:/// differently than previous versions of Go. See https://tip.golang.org/doc/go1.19

This causes TestNormalize to fail with Go 1.19:

--- FAIL: TestNormalizer_NormalizeBase (0.00s)
    --- PASS: TestNormalizer_NormalizeBase/#00 (0.00s)
    --- PASS: TestNormalizer_NormalizeBase/file:///folder//subfolder///file.json/ (0.00s)
    --- PASS: TestNormalizer_NormalizeBase/file:///. (0.00s)
    --- PASS: TestNormalizer_NormalizeBase/file://folder/file.json (0.00s)
    --- PASS: TestNormalizer_NormalizeBase/http://www.anotherexample.com/another/base/path/swagger.json#/definitions/Pet (0.00s)
    --- PASS: TestNormalizer_NormalizeBase/https://user:[email protected]:123/base/sub/file.json (0.00s)
    --- PASS: TestNormalizer_NormalizeBase/base/sub/file.json (0.00s)
    --- PASS: TestNormalizer_NormalizeBase/. (0.00s)
    --- PASS: TestNormalizer_NormalizeBase//base/sub/file.json?query=param (0.00s)
    --- PASS: TestNormalizer_NormalizeBase//base/sub/file.json (0.00s)
    --- PASS: TestNormalizer_NormalizeBase/.. (0.00s)
    --- PASS: TestNormalizer_NormalizeBase/gs://bucket/folder/file.json (0.00s)
    --- FAIL: TestNormalizer_NormalizeBase/file:/. (0.00s)
    --- FAIL: TestNormalizer_NormalizeBase/file:/base/sub/file.json#01 (0.00s)
    --- PASS: TestNormalizer_NormalizeBase/./base/sub/file.json (0.00s)
    --- PASS: TestNormalizer_NormalizeBase/# (0.00s)
    --- PASS: TestNormalizer_NormalizeBase/https:///host/base/sub/file.json?query=param (0.00s)
    --- PASS: TestNormalizer_NormalizeBase//.. (0.00s)
    --- PASS: TestNormalizer_NormalizeBase/\x7f� (0.00s)
    --- PASS: TestNormalizer_NormalizeBase/smb://host (0.00s)
    --- PASS: TestNormalizer_NormalizeBase////folder//subfolder///file.json/ (0.00s)
    --- FAIL: TestNormalizer_NormalizeBase/file:/base/sub/file.json (0.00s)
    --- FAIL: TestNormalizer_NormalizeBase/file:/.. (0.00s)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant