New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable pre-merge testing #67

Closed

pohly opened this issue Aug 11, 2021 · 2 comments

Contributor

pohly commented Aug 11, 2021

It would be useful to automatically check that PRs don't break tests, formatting, and API stability.

Perhaps we can copy how klog handles this? See https://github.com/kubernetes/klog/tree/main/.github

This applies to all repos under go-logr.

pohly mentioned this issue

export Logger.Sink #66

Merged

Contributor

thockin commented Aug 12, 2021

yes, it's long past time.

Contributor

thockin commented Aug 12, 2021

Done for logr, will clone to others when I get a sec.

thockin closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment