Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Proposal]关于kratos是否支持multipart-form binding的问题。 #2198

Closed
lyouthzzz opened this issue Jul 15, 2022 · 3 comments
Closed
Labels
proposal proposal

Comments

@lyouthzzz
Copy link
Contributor

Feature-request

希望可以提供multipart-form请求的解码器。
之前和kratos群里讨论过这个问题,官方的答复是 multipart-form不属于http grpc的mapping里,所以并不额外提供对应的解码器。
仔细想想,这是不合理的。
因为目前kratos实现的的codec 还是http/binding都是给http server使用的。grpc有自己的codec实现,我们并不需要关注,
所以kratos的解码器应该去支持http request的multpart-form的解码方案。

Proposal

建议参照gin框架的binding,在kratos中 transport/http/binding中去支持multipart-form的实现。

Pull-request

Decision process

Final decision maker mechanism

Proposal description

Implementation mode

@lyouthzzz lyouthzzz added the proposal proposal label Jul 15, 2022
@shenqidebaozi
Copy link
Member

不是因为 codec 的问题,是如果使用 proto 声明,文件应该对应 proto 哪个类型

@emcfarlane
Copy link

👋 hello! Maybe my project could help with gRPC file uploads: https://github.com/emcfarlane/larking

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
proposal proposal
Projects
None yet
Development

No branches or pull requests

4 participants