Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for MS Teams webhooks #6632

Merged
merged 22 commits into from
Apr 19, 2019

Conversation

dangrier
Copy link
Contributor

Implements #5964 to add Microsoft Teams webhooks (Incoming Webhook Connector).

Largely matched styling of Discord webhooks and aligned with other webhook functionality/appearance.

Tested on a local instance, with a connection to Teams and functioned as expected.

All commits signed off, and latest changes integrated from upstream.

models/webhook_msteams.go Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 15, 2019
@lafriks lafriks added the type/feature Completely new functionality. Can only be merged if feature freeze is not active. label Apr 15, 2019
@lafriks lafriks added this to the 1.9.0 milestone Apr 15, 2019
@codecov-io
Copy link

codecov-io commented Apr 15, 2019

Codecov Report

Merging #6632 into master will decrease coverage by 0.48%.
The diff coverage is 0.73%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6632      +/-   ##
==========================================
- Coverage   41.35%   40.87%   -0.49%     
==========================================
  Files         415      416       +1     
  Lines       56337    57013     +676     
==========================================
+ Hits        23299    23303       +4     
- Misses      29917    30589     +672     
  Partials     3121     3121
Impacted Files Coverage Δ
models/webhook_msteams.go 0% <0%> (ø)
models/webhook.go 60.16% <0%> (-0.91%) ⬇️
modules/auth/repo_form.go 41.73% <0%> (-0.74%) ⬇️
routers/repo/webhook.go 1.39% <0%> (-0.13%) ⬇️
modules/setting/webhook.go 100% <100%> (ø) ⬆️
routers/routes/routes.go 82.18% <100%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2af67f6...98d4786. Read the comment docs.

@dangrier
Copy link
Contributor Author

Is there anything else needed for approval?

@techknowlogick techknowlogick changed the title Issue #5964 - add support for MS Teams webhooks Add support for MS Teams webhooks Apr 19, 2019
@techknowlogick
Copy link
Member

@dangrier could you resolve git conflicts, and post screenshots of what a webhook would look like in MS Teams?

@techknowlogick
Copy link
Member

@dangrier I've just resolved the git conflicts. I did it via Github interface so hopefully a make fmt isn't needed.

@dangrier
Copy link
Contributor Author

Okay, didn't see that so also resolved - but not to worry!

It looks like this:
image

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 19, 2019
@techknowlogick
Copy link
Member

@dangrier ah phew. glad that was quick to diagnose.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 19, 2019
@techknowlogick techknowlogick merged commit b9d1fb6 into go-gitea:master Apr 19, 2019
@dangrier dangrier deleted the issue-5964-ms-teams-webhook branch April 19, 2019 20:16
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/feature Completely new functionality. Can only be merged if feature freeze is not active.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants