Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom fomantic-ui build #9415

Closed
silverwind opened this issue Dec 18, 2019 · 1 comment
Closed

Custom fomantic-ui build #9415

silverwind opened this issue Dec 18, 2019 · 1 comment
Labels
topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile topic/ui Change the appearance of the Gitea UI

Comments

@silverwind
Copy link
Member

As mentioned in #9374 (comment), the version of fomantic-ui we use is very big and includes around 30 modules of which we probably only use a handful, so I'd estimate we could drop the size of it by at least half if not more.

Proposing to add a custom build process that adds it as a npm dependency and a make fomantic-ui target to build it.

As a first step, we can commit the resulting files in the vendor directory, but I'd like to eventually have them integrated in the webpack bundle, but that could prove a bit challenging as it needs the right webpack loaders for the fonts etc.

@techknowlogick techknowlogick added topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile topic/ui Change the appearance of the Gitea UI labels Dec 18, 2019
@silverwind
Copy link
Member Author

Fixed with #9561

@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile topic/ui Change the appearance of the Gitea UI
Projects
None yet
Development

No branches or pull requests

2 participants