Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sometimes Ctrl+C cannot stop gitea #9398

Closed
lunny opened this issue Dec 18, 2019 · 6 comments
Closed

Sometimes Ctrl+C cannot stop gitea #9398

lunny opened this issue Dec 18, 2019 · 6 comments
Labels

Comments

@lunny
Copy link
Member

lunny commented Dec 18, 2019

macOS

图片

@lunny lunny added the type/bug label Dec 18, 2019
@bagasme
Copy link
Contributor

bagasme commented Dec 18, 2019

Have tried killing Gitea process?

@zeripath
Copy link
Contributor

So since graceful took over the handle signals with a lifecycle there are a few places which may need to pay attention to shutdown and stop too - I've noticed the dB initialisation code needs to pay attention.

The fundamental is cause is likely that the waitGroups are not being emptied - thus web won't finish.

I'll take a look.

@zeripath
Copy link
Contributor

OK I noticed that things waiting on the issue indexer won't shutdown nicely because the holder doesn't listen to shutdown - that's fixed in #9363. #9313 removed the equivalent problem from the repo holder but, introduced other bugs which should be fixed by: #9476

@guillep2k
Copy link
Member

@zeripath is this issue still pending?

@lunny
Copy link
Member Author

lunny commented Jan 8, 2020

Let's close now.

@lunny lunny closed this as completed Jan 8, 2020
@zeripath
Copy link
Contributor

zeripath commented Jan 8, 2020

There's probably other places but we can reopen when they become apparent

@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants