Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[impovement] don't reverence same issue multible times next to itself #8722

Closed
6543 opened this issue Oct 28, 2019 · 4 comments · Fixed by #8734
Closed

[impovement] don't reverence same issue multible times next to itself #8722

6543 opened this issue Oct 28, 2019 · 4 comments · Fixed by #8734

Comments

@6543
Copy link
Member

6543 commented Oct 28, 2019

just look at: https://gitea.com/gitea/tea/pulls/45
Gitea Version: 1.11.0+dev-56-g28f60bb5c

Bildschirmfoto zu 2019-10-28 22-33-12

@6543
Copy link
Member Author

6543 commented Oct 28, 2019

@guillep2k didn't you write code in this area, so do you have any idears where to look at?

@guillep2k
Copy link
Member

guillep2k commented Oct 29, 2019

Every time you edit the comment it will invalidate previous references and create them anew. The reasons are because previous ones could or could not be the same as the new ones, and because I thought a trail would be good for consistency.

The algorithm could be more sophisticated and detect "exact same list", of course. At the time it didn't seem too important. In this case, only a few minutes passed between one edition and the next, but what if days have passed? Mails will have been sent, people will have read that, etc. It made sense to me to leave a trail of changes, but I guess it can be confusing.

I don't know: it's a feature? a bug? 😁

@6543
Copy link
Member Author

6543 commented Oct 29, 2019

to have a trail is nice ... but add one check if it is next to itself and update instead?

is this hard to do?

@6543 6543 changed the title [bug] don't reverence same issue multible times [bug] don't reverence same issue multible times next to itself Oct 29, 2019
@6543 6543 changed the title [bug] don't reverence same issue multible times next to itself [impovement] don't reverence same issue multible times next to itself Oct 29, 2019
@guillep2k
Copy link
Member

to have a trail is nice ... but add one check if it is next to itself and update instead?

is this hard to do?

@6543 on it.

@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants