Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Repo Administrators to (Force) Merge "Review Required" PRs #8272

Closed
2 of 7 tasks
bagasme opened this issue Sep 24, 2019 · 2 comments
Closed
2 of 7 tasks

Allow Repo Administrators to (Force) Merge "Review Required" PRs #8272

bagasme opened this issue Sep 24, 2019 · 2 comments

Comments

@bagasme
Copy link
Contributor

bagasme commented Sep 24, 2019

  • Gitea version (or commit ref): 1.9.0
  • Git version: 2.17.1
  • Operating system: Ubuntu 18.04
  • Database (use [x]):
    • PostgreSQL
    • MySQL
    • MSSQL
    • SQLite
  • Can you reproduce the bug at https://try.gitea.io:
    • Yes (provide example URL)
    • No
    • Not relevant
  • Log gist:
    (not relevant)

Description

In cases whether there is an open PR against protected branch that requires approved reviews from whitelisted reviewers, and all reviewers aren't available in time, repo administrators can still merge that PR. An example when this feature is useful is when a PR contains important security fixes.

Screenshots

This screenshot is from my localhost Gitea instance on a computer. A user (which is repo administrator) open a PR against protected branch (master). Required approvals are 1. However, despite that he is an admin, he can't (force) merge his PR without approvals. That is, there isn't Merge Pull Request button.
image
On the other hand, on GitHub, there is Merge Pull Request button which allows admins to merge
PR without review approvals (that is, force merging).
image

@lunny
Copy link
Member

lunny commented Sep 24, 2019

I think maybe I have resolved this on #7481 ?

@bagasme
Copy link
Contributor Author

bagasme commented Sep 24, 2019

I think maybe I have resolved this on #7481 ?

@lunny Yes this issue is duplicate. Please close.

@bagasme bagasme closed this as completed Sep 24, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants