Issues related commit activity (reference) is missing

[davydov-vyacheslav]

• Gitea version (or commit ref): 1.10.0+dev-189-g08c63190c
• Reproducible on https://gitea.com

Description

Somewhere in time, there is was an feature of issues mention /reference like this:

Now looks like it missed:

The link to the issue is: https://gitea.com/davs/testrepo/issues/1

Is there a way to get this feature back?

[mrsdizzie]

In your examples of it not working, it is because you have a colon after the #1 -- Gitea doesn't support that. It should either be blank, or the issue can be inside of square brackets or paren but #1:wouldn't be seen as a valid issue number in this case

Your working example appears to have a space between the issue number and colon which is why it works.

Perhaps a colon could be added. Github seem to support that and we try to match what they do, though it is not documented so hard to get everything always. That is why it isn't working in this case though, the feature hasn't gone away.

[davydov-vyacheslav]

Ok. Got it. Just one comment: why “Fixed” has been determined and the issue has been closed after pushing the commits?

[mrsdizzie]

I'm not quite sure what you are asking sorry.

Are you asking why an issue is closed if you make a commit that says "fixed #1" ? If so that is based on:

https://help.github.com/en/articles/closing-issues-using-keywords

[davydov-vyacheslav]

@mrsdizzie but according to the image, the colon is just after the issue number. And it works for closing the issue, but not works to make reference. That was the just confusion of logic difference.

Anyway, the answer of how it was worked has been obtained. Thank you.

Should I close the issue or it’d be the reference for further someone’s PR?

[mrsdizzie]

Ah OK I see what you mean thank you for the extra explanation -- I hadn't realized from the screenshots that the issue was closed by that commit but not quoted.

That is a bug you can leave this issue open for reference in PR thanks

[davydov-vyacheslav]

Is there a way to prioritize the issue?

[mrsdizzie]

#8101 should fix this particular case when it is done I believe

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

[lunny]

Should be closed by #8101