Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-collapse or hide certain file on diff/PR #7092

Closed
DblK opened this issue May 31, 2019 · 8 comments
Closed

Auto-collapse or hide certain file on diff/PR #7092

DblK opened this issue May 31, 2019 · 8 comments
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/feature Completely new functionality. Can only be merged if feature freeze is not active.

Comments

@DblK
Copy link
Member

DblK commented May 31, 2019

On some project/language, there are files (for example VisualStudio Project file, etc.) that you must commit to have a working repository.
However, those file are managed by the IDE your are using and none of the changes are made by hand.

I would like to either auto-collapse the file to not spend time on review for file I won't watch or being able to specify (either inside the repository in .gitea.yml) or in settings inside gitea to list the files I want to ignore in those process (PR, Diff, etc...)

@zeripath zeripath added type/feature Completely new functionality. Can only be merged if feature freeze is not active. issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented labels May 31, 2019
@lunny
Copy link
Member

lunny commented Jun 2, 2019

Right, this is a good idea. We could define some situations here.

  • according extensions
  • specify sub folders
  • specify filenames
  • non-image binaries

@6543
Copy link
Member

6543 commented Oct 18, 2019

I would NOT hide them because of securety conzerns - but then #8579 has to be there first

@DblK
Copy link
Member Author

DblK commented Oct 25, 2019

When I said "hide" I had in mind collapse like the ticket @6543 was mentioning.
When #8579 will be done, this feature can be easily implemented by auto-collapse some files.

@lunny
Copy link
Member

lunny commented Nov 27, 2019

I think we can put a file named .gitea/pr_collapse which have a format similiar with .gitignore to do that.

@guillep2k
Copy link
Member

I think we can put a file named .gitea/pr_collapse which have a format similiar with .gitignore to do that.

I've always wanted /vendor files to auto-collapse. 👍

@mpuromaki
Copy link

diff

I would like to auto-collapse/hide/push-down diffs that have specific type of change (regexp?).

My use case is IDE generated changes to hundreds of files in each commit. These changes has to be included in the commits since they're checksums etc.

@zeripath
Copy link
Contributor

Does #16773 not completely fulfil this request?

@zeripath
Copy link
Contributor

yup I think this is fixed by #16773. Please reopen if that PR does not completely fulfil this request.

@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/feature Completely new functionality. Can only be merged if feature freeze is not active.
Projects
None yet
Development

No branches or pull requests

6 participants