Duplicated/empty row on My Repositories on Organization dashboard

[jomp16]

• Gitea version (or commit ref): 1.0.0+133-gd2bb8ef5
• Git version: 2.11.0
• Operating system: Arch Linux
• Database (use [x]):
  • MySQL
• Can you reproduce the bug at https://try.gitea.io:
  • No (not sure tho).

Description

I created a new organization and changed the owner of repository to that organization. That worked perfectly.

But I found something strange on Organization dashboard:

The empty row on "my repositories" just links to the Organization url.

Excepted result is:

(I removed the empty rows with Chrome inspector).

I don't know if the way I did to change ownership from me to a organization is wrong, or this is a Gitea bug.

[tboerger]

Duplicate of #56, please try to reproduce a big first on try.gitea.io which is always running latest master.

[jomp16]

I guess I didn't ask for theme support? Maybe you linked the wrong issue number?

And I also guess try.gitea.io isn't always updated, because version: 1.0.0+116-g69b86378.

But yeah, I don't see it on try.gitea.io. Update it to latest master and I can check it again.

I'll build with commit 69b8637 (to match try.gitea.io) and check if issue is on my side or some recent commit broke it.

--

Not a bug on my side, I build with version: 1.0.0+116-g69b86378 and it correctly show all the six repositories, without any empty <li> tag.

Did you misunderstand my issue?

--

I guess I need to find the faulty commit...

[jomp16]

I found the faulty commit: 302fa42.

Tested the commit before that (which is 88f45ce) and it didn't give out empty <li> tags.

I'm not sure why this commit gives an empty <li> tags, because it never touched the template file.

Maybe this line? 302fa42#diff-97681c8a2932ea3c23325d3518374d98R608

I'll revert this commit and see the results

--

Yep, reverting that commit renders the "My repositories" correctly without any extra empty <li> , but I really not sure the why.

--

@tboerger can you reopen this?

[tboerger]

#564 is the correct issue and the referenced pull request should have fixed that.

[tboerger]

And try.gitea.io is always the latest version... It shows 1.0.0 + 116 commits.

If your issue still isn't resolved please explain more details.

[jomp16]

You sure? Because seems try.gitea.io is at version 1.0.0+116-g69b86378. See the commit after the g and search GitHub commits for that commit. Commit: 69b8637 name: "docs: update zh-tw translation". See how many new commits Gitea team have made (16 new commits), and the the commit that is faulty for me, is in the middle of the new commits. So... Update try.gitea.io to point to the literally latest master which is d2bb8ef name: "Notifications: trying to get a better layout". And I'll check again. Ping @lunny, because you made that commit that's supposed to fix. But for some reason it does not for me. Reverting that commit does not generate empty lines alongside of the repositories links. See the first image on issue. Maybe I should record or create a test user and Organization on my Gitea instance running latest master and you see by yourselves?

[lunny]

try.gitea.io seems not the latest version. It's 1.0.0+116-g69b86378, but it should 1.0.0+134-g3c4d5e1e.

[bkcsoft]

^ I've noticed that try. isn't always updated as well, though I assumed it was drone being slow on the builds...

[lunny]

@tboerger

[jomp16]

And since try.gitea.io is updated (1.0.0+149-g8bc43195). I can reproduce this bug on it.

http://i.imgur.com/XHg2PyK.png

@tboerger now reopen this. You can reproduce this bug by switching to Organization on Dashboard. Like I said.

All teh info is on comments above.

[Bwko]

Possible duplicate of #746?

[jomp16]

Possible, but I reported first, and nobody believed me :)

Anyways, if it's a known issue now. Good :)

[Bwko]

@jomp16 I agree #746 is a duplicate of this issue 😉
Could you test if #749 solves your issue?