Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use runtime/debug for providing the version #6812

Closed
sapk opened this issue May 1, 2019 · 3 comments
Closed

Use runtime/debug for providing the version #6812

sapk opened this issue May 1, 2019 · 3 comments
Labels
type/proposal The new feature has not been accepted yet but needs to be discussed first.

Comments

@sapk
Copy link
Member

sapk commented May 1, 2019

Since go1.12 we can get the version from runtime/debug for the main module (gitea itself) and also submodules (lib) we are using. golang/go@45e9c55

So when we will only support 1.12 and 1.13 we could migrate to this system and clear some makefile and also wiil fix #4782 since we will not rely on env variable.

@lunny lunny added the type/proposal The new feature has not been accepted yet but needs to be discussed first. label May 1, 2019
@zeripath
Copy link
Contributor

zeripath commented May 3, 2019

This is probably fixed by #6836 and its backport #6839

@sapk
Copy link
Member Author

sapk commented May 3, 2019

This isn't the same. I suggest to use the fact that the module version (tag) is now available when building with mod. This will remove any need for a lot of line in makefile.

@wxiaoguang
Copy link
Contributor

I do not think Go's module version works well nor it satisfies Gitea's version mechanism.

https://github.com/golang/go/issues/29228

Correct me if I am wrong, feel free to re-open if there are more details or feasible plans.

@wxiaoguang wxiaoguang closed this as not planned Won't fix, can't repro, duplicate, stale Oct 26, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type/proposal The new feature has not been accepted yet but needs to be discussed first.
Projects
None yet
Development

No branches or pull requests

4 participants