Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pullrequest dependencies are disabled when internal issue tracker is disabled #6039

Closed
MarkusAmshove opened this issue Feb 11, 2019 · 5 comments · Fixed by #9842
Closed

Pullrequest dependencies are disabled when internal issue tracker is disabled #6039

MarkusAmshove opened this issue Feb 11, 2019 · 5 comments · Fixed by #9842
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/bug

Comments

@MarkusAmshove
Copy link
Contributor

  • Gitea version (or commit ref): master

Description

When selecting an external issue tracker in the repository settings (see 1st screenshot), it is no longer possible to add dependencies between pull requests.

In our current workflow, we do use an external issue tracker for all of our repositories.

However, we're leveraging PRs and would love to be able to have dependencies between PRs (which does work when internal issue tracker is enabled).

Screenshots

grafik

@lafriks lafriks added the type/enhancement An improvement of existing functionality label Feb 11, 2019
@MarkusAmshove
Copy link
Contributor Author

I tried to have a go on this, but I'm kinda lost on how to implement this.

My first try was to pull out the option from Enable Repository Issue Tracker as an additional option, which can be enabled when either PRs or Issues are enabled.

However, the name issue dependencies and the option EnableDependencies in IssueConfig wouldn't make sense anymore.
Also, the DB table seems to be issue_dependencies, so when trying to do it clean I have to change the database, translation keys etc..

Is there another approach I could to?
Is an additional option in for pull request config, to have 2 options, a better idea?

I think this needs a bit of design thought from the Gitea side, as this would be my first PR and got kinda huge :-)

@stale
Copy link

stale bot commented Apr 14, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

@stale stale bot added the issue/stale label Apr 14, 2019
@stale
Copy link

stale bot commented Apr 29, 2019

This issue has been automatically closed because of inactivity. You can re-open it if needed.

@stale stale bot closed this as completed Apr 29, 2019
@MarkusAmshove
Copy link
Contributor Author

Still relevant :-)

@lunny lunny added the issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented label Dec 12, 2019
@lunny lunny reopened this Dec 12, 2019
@stale stale bot removed the issue/stale label Dec 12, 2019
@6543

This comment has been minimized.

@lunny lunny added type/bug and removed type/enhancement An improvement of existing functionality labels Jan 17, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants