Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-closing of issues via PR doesn't work #2735

Closed
2 of 7 tasks
SnowMB opened this issue Oct 18, 2017 · 6 comments
Closed
2 of 7 tasks

Auto-closing of issues via PR doesn't work #2735

SnowMB opened this issue Oct 18, 2017 · 6 comments
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/enhancement An improvement of existing functionality

Comments

@SnowMB
Copy link
Contributor

SnowMB commented Oct 18, 2017

  • Gitea version (or commit ref): 1.2.0+6-g46bb1cf
  • Git version:
  • Operating system:
  • Database (use [x]):
    • PostgreSQL
    • MySQL
    • MSSQL
    • SQLite
  • Can you reproduce the bug at https://try.gitea.io:
    • Yes (provide example URL)
    • No
    • Not relevant
  • Log gist:

Description

I've tried a few things to automatically close issues when a PR is merged. I haven't found a way to do it.
Neither a commit with the message containing closes #xx nor using closes #xx as title or pr message has any effect.

This is problematic because gitea doesn't display references that are made to the pr / issue in the discussion tab like github does. So there is no indicator if the issue was discussed / handled in another issue / pr.

Screenshots

@lafriks lafriks added the type/enhancement An improvement of existing functionality label Oct 18, 2017
@lafriks lafriks added this to the 1.x.x milestone Oct 18, 2017
@lunny
Copy link
Member

lunny commented Oct 19, 2017

@lafriks this should be a bug, but not an enhancement.

@SnowMB
Copy link
Contributor Author

SnowMB commented Oct 19, 2017

@lunny It might be both. A bug for not recognizing the "closes #xx" in a commit message after the pr is merged.

Feature request for also supporting closing issues by title / description of the PR.

@krrutkow
Copy link
Contributor

Any update on when this issue might be addressed?

@finalex
Copy link

finalex commented Mar 8, 2018

Is there any plan for this issue?

@stale
Copy link

stale bot commented Feb 7, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

@stale stale bot added the issue/stale label Feb 7, 2019
@lunny lunny added issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented and removed issue/stale labels Feb 7, 2019
@mrsdizzie
Copy link
Member

Fixed since #8866

@lunny lunny removed this from the 1.x.x milestone Sep 8, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/enhancement An improvement of existing functionality
Projects
None yet
Development

No branches or pull requests

6 participants