Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't show mail-notification settings when ENABLE_NOTIFY_MAIL is false #20131

Closed
uriesk opened this issue Jun 25, 2022 · 1 comment · Fixed by #20138
Closed

Don't show mail-notification settings when ENABLE_NOTIFY_MAIL is false #20131

uriesk opened this issue Jun 25, 2022 · 1 comment · Fixed by #20138
Labels
topic/ui Change the appearance of the Gitea UI type/bug

Comments

@uriesk
Copy link

uriesk commented Jun 25, 2022

Description

I wasted time playing with mail-notification settings in the profile and adding / removing mail addresses.
Till i realized that there is a ENABLE_NOTIFY_MAIL setting, which is false per default.

I think the mail notification setting in the profile should not be available (grayed out), or there should be some
"Mail notifications are disabled by the Administration" or any other hint making it obvious that it is not available.

Screenshots

Screenshot_20220625_111716

Gitea Version

1.17.0-rc1

Can you reproduce the bug on the Gitea demo site?

Yes

Operating System

No response

Browser Version

Brave 1.40.105 Chromium: 103.0.5060.53

@uriesk uriesk added type/bug topic/ui Change the appearance of the Gitea UI labels Jun 25, 2022
@Francewhoa
Copy link

This is another example of a user struggling with notification at https://discourse.gitea.io/u/JVC-MSF

I believe that @uriesk's suggestions above would resolve this challenge

@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants