Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify git ref to sha lookups #16411

Closed
6543 opened this issue Jul 12, 2021 · 1 comment
Closed

Unify git ref to sha lookups #16411

6543 opened this issue Jul 12, 2021 · 1 comment
Assignees
@6543
Labels
type/refactoring Existing code has been cleaned up. There should be no new functionality.
Milestone
1.17.0

Comments

@6543
Copy link
Member

6543 commented Jul 12, 2021

example: #16400

... you can find ... code (git ref -> sha lookup) all over different places and we should unify them ...

As lunny worried utils is becoming a bit of a catch-all package. Not necessarily this PR but I wonder if we these would be better in a git package

cc @zeripath

note: "..Now a branch named deadbeef will override the sha deadbeef. I'm not sure if that's completely intentional, it may be best to provide some marker or mechanism to force sha over branches/tags.."
@6543 6543 added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Jul 12, 2021
@6543 6543 added this to the 1.16.0 milestone Jul 12, 2021
@6543 6543 self-assigned this Jul 12, 2021
@6543 6543 mentioned this issue Jul 12, 2021
Merged
@lunny lunny modified the milestones: 1.16.0, 1.17.0 Nov 19, 2021
@6543 6543 closed this as completed Apr 30, 2022
@6543
Copy link
Member Author

6543 commented Apr 30, 2022

(#19449)

@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@6543 6543

Labels
type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.17.0
Development

No branches or pull requests
2 participants
@lunny @6543