Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SVGs should always have the option to be displayed as image #14943

Closed
delvh opened this issue Mar 10, 2021 · 4 comments
Closed

SVGs should always have the option to be displayed as image #14943

delvh opened this issue Mar 10, 2021 · 4 comments
Labels
issue/duplicate The issue has already been reported.

Comments

@delvh
Copy link
Member

delvh commented Mar 10, 2021

Description

Gitea supports showing SVGs as image and not as text, but apparently that only applies when viewing the file in the file view (example).
When opening a new PR, a SVG will still only be displayed as text in the preview and later on in the existing PR.

Expected behavior

Wherever in a repo a SVG image gets encountered, it should be displayed initially as image, not as text, but with the ability to convert it to raw text.

Screenshots

Appearance in file view:
image

Appearance in PR:
image

Appearance in PR preview:
image

@zeripath
Copy link
Contributor

Look I don't think this is a bug - it's a missing feature.

@zeripath zeripath changed the title [Bug] SVGs should always have the option to be displayed as image SVGs should always have the option to be displayed as image Mar 11, 2021
@zeripath zeripath added type/feature Completely new functionality. Can only be merged if feature freeze is not active. topic/ui Change the appearance of the Gitea UI labels Mar 11, 2021
@delvh
Copy link
Member Author

delvh commented Mar 11, 2021

I see why you think so, but on the other hand I would expect, given that gitea is already able to display svg files as image, that they always offer the option to do so…
This is one of the rare cases where missing feature and bug are basically the same.

@KN4CK3R
Copy link
Member

KN4CK3R commented Mar 14, 2021

see #14867

@kdumontnu
Copy link
Contributor

Duplicate of #14329

@kdumontnu kdumontnu marked this as a duplicate of #14329 Mar 17, 2021
@techknowlogick techknowlogick added issue/duplicate The issue has already been reported. and removed type/feature Completely new functionality. Can only be merged if feature freeze is not active. topic/ui Change the appearance of the Gitea UI labels Mar 17, 2021
@go-gitea go-gitea locked and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue/duplicate The issue has already been reported.
Projects
None yet
Development

No branches or pull requests

5 participants