-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
swastika avatars #14799
Comments
Legally this is not an issue I believe, as only the specific original symbol is banned afaik, not approximations thereof. Pointing to https://codeberg.org/codeberg/avatars, which should be possible to integrate into mainline gitea |
if using codeberg/avatars ... |
I just stumbled across this issue. In fact only two of the images contain a structure that looks at least remotely like a swastika to me. However, I'm sure there are people that are probably a lot more sensitive than me, when it comes to this. As you will probably always run into some kind of issue with randomly generated images, the only real solution is probably to either provide a button to re-generate the avatar with another random seed if desired or to not to random-generate them, but to use a set of pre-generated and handpicked avatar images. Just to add a bit more (completely biased) personal opinion: I like the idea of random avatar images. It is a lot better to have distinguishable random avatars instead of a single default avatar. |
I just took a look at the DiceBear avatars. While I personally think they look great, I believe they have a lot more trigger-potential than the currently implmented random generation. |
I would like to copy a comment from @techknowlogick in CodeBerg/Community#394.
I think allowing the avatar generator to be chosen on install (and/or changed in config) would be sufficient for a host to choose whatever suits their use-case. |
This argument essentially boils down to any object with rotational symmetry order 4 and without mirror symmetry is a swastika. The avatars are generated using: https://github.com/issue9/identicon Looking at the code this appears to build its avatars with deliberate 4th order rotational symmetry It would not be hard to change: func drawBlocks(p *image.Paletted, size int, c, b1, b2 blockFunc, angle int) {
// 每个格子的长宽。先转换成 float,再计算!
blockSize := float64(size) / 3
twoBlockSize := 2 * blockSize
incr := func() { // 增加 angle 的值,但不会大于 3
angle++
if angle > 3 {
angle = 0
}
}
c(p, blockSize, blockSize, blockSize, 0)
b1(p, 0, 0, blockSize, angle)
b2(p, blockSize, 0, blockSize, angle)
incr()
b1(p, twoBlockSize, 0, blockSize, angle)
b2(p, twoBlockSize, blockSize, blockSize, angle)
incr()
b1(p, twoBlockSize, twoBlockSize, blockSize, angle)
b2(p, blockSize, twoBlockSize, blockSize, angle)
incr()
b1(p, 0, twoBlockSize, blockSize, angle)
b2(p, 0, blockSize, blockSize, angle)
} To break this symmetry by changing the angle placed in each corner from 0,1,2,3 to 0,1,3,2 instead. Now my initial review of the code of this library is not entirely favourable - however, this is a question of developer effort and time spent looking for a new avatar library. |
@davidak can you please stop insult my religion?
|
I'm going to go ahead and lock this discussion. Further discussion can perhaps be moved to issues regarding new avatar generation libraries to add, or changing the parameters we use for identicon. I think adding options would be a nice idea regardless the motivation, and I think that should also cover the use-cases presented. |
This could be replacement option: https://github.com/o1egl/govatar |
Please have a look at: |
[x]
):Description
The swastica was used by the german fascist movement. Later, it was the sign of the right-wing german party NSDAP and the third reich. Now it's legally forbidden to use this sign in germany (Strafgesetzbuch § 86a). It's also called „Hakenkreuz“ in germany.
Even this anti-fascist sign was long forbidden until a court decided that it is legal.
https://de.wikipedia.org/wiki/Swastika#/media/Datei:Anti-Nazi-Symbol.svg
The gitea avatar algorithm sometimes creates geometric shapes that could get recognised as swasticas. Therefore gitea could be considered illegal in germany.
That might sound a bit crazy and you could argue that it's just random geometric shapes, but it's a highly sensitive topic in germany and probably someone will show up and call you a fascist if you try to argue about it. I find it kind of ironic, because probably no one getting this random avatar is actually a fascist, but other people might be more sensitive.
So you might consider using a different algorithm for the avatar creation.
Related issue:
It was also noticed in social media: https://social.tchncs.de/@cark/105651953031693352
Screenshots
The text was updated successfully, but these errors were encountered: