Relative path in Org files does not link to raw files

[0Pranav]

• Gitea version (or commit ref): 1.12.4
• Git version: 2.25.1
• Operating system: Ubuntu Server 20.04 LTS
• Database (use [x]):
  • PostgreSQL
  • MySQL
  • MSSQL
  • SQLite
• Can you reproduce the bug at https://try.gitea.io:
  • Yes (https://try.gitea.io/0Pranav/vulkan-tutorial/src/branch/master)
  • No
  • Not relevant
• Log gist:

Description

In the example repo you can see org file in the master branch has the link https://try.gitea.io/0Pranav/vulkan-tutorial/src/branch/master/demo/vulkan.gif while in markdown the same link links to https://try.gitea.io/0Pranav/vulkan-tutorial/raw/branch/readme-test/demo/vulkan.gif, which results in the gif not being displayed in the org file

Screenshots

Markdown

Org

[zeripath]

OK the code that deals with orgmode is:

https://github.com/go-gitea/gitea/blob/master/modules/markup/orgmode/orgmode.go

Likely this code:

gitea/modules/markup/orgmode/orgmode.go

Lines 77 to 103 in 6a1a633

	func (r *Renderer) WriteRegularLink(l org.RegularLink) {
	link := []byte(html.EscapeString(l.URL))
	if l.Protocol == "file" {
	link = link[len("file:"):]
	}
	if len(link) > 0 && !markup.IsLink(link) &&
	link[0] != '#' && !bytes.HasPrefix(link, byteMailto) {
	lnk := string(link)
	if r.IsWiki {
	lnk = util.URLJoin("wiki", lnk)
	}
	link = []byte(util.URLJoin(r.URLPrefix, lnk))
	}
	description := string(link)
	if l.Description != nil {
	description = r.WriteNodesAsString(l.Description...)
	}
	switch l.Kind() {
	case "image":
	r.WriteString(fmt.Sprintf(`<img src="%s" alt="%s" title="%s" />`, link, description, description))
	case "video":
	r.WriteString(fmt.Sprintf(`<video src="%s" title="%s">%s</video>`, link, description, description))
	default:
	r.WriteString(fmt.Sprintf(`<a href="%s" title="%s">%s</a>`, link, description, description))
	}
	}

Probably needs to have changed inspired by:

gitea/modules/markup/markdown/goldmark.go

Lines 80 to 110 in 6a1a633

	case *ast.Image:
	// Images need two things:
	//
	// 1. Their src needs to munged to be a real value
	// 2. If they're not wrapped with a link they need a link wrapper
	// Check if the destination is a real link
	link := v.Destination
	if len(link) > 0 && !markup.IsLink(link) {
	prefix := pc.Get(urlPrefixKey).(string)
	if pc.Get(isWikiKey).(bool) {
	prefix = giteautil.URLJoin(prefix, "wiki", "raw")
	}
	prefix = strings.Replace(prefix, "/src/", "/media/", 1)
	lnk := string(link)
	lnk = giteautil.URLJoin(prefix, lnk)
	link = []byte(lnk)
	}
	v.Destination = link
	parent := n.Parent()
	// Create a link around image only if parent is not already a link
	if _, ok := parent.(*ast.Link); !ok && parent != nil {
	wrap := ast.NewLink()
	wrap.Destination = link
	wrap.Title = v.Title
	parent.ReplaceChild(parent, n, wrap)
	wrap.AppendChild(wrap, n)
	}
	case *ast.Link: