Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

words and lines are not localized #11369

Closed
alexanderadam opened this issue May 11, 2020 · 11 comments
Closed

words and lines are not localized #11369

alexanderadam opened this issue May 11, 2020 · 11 comments
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented modifies/translation outdated/theme/markdown

Comments

@alexanderadam
Copy link

alexanderadam commented May 11, 2020

  • Gitea version (or commit ref): 1.12.0+dev-292-g742e26f5a
  • Can you reproduce the bug at https://try.gitea.io:

Yes, this is actually how I stumbled over it. I have some test repositories because of some previous bug reports and someone created a test issue — which I closed. Suddenly I saw that the activated locale was in german. So everything was in german except "lines" and "words".

Screenshots

Screenshot_20200511_081224

@silverwind
Copy link
Member

silverwind commented May 11, 2020

The english ones were updated in 28e5e7f, I guess Crowdin has not caught up yet (I don't really know how it works exactly)?

@alexanderadam
Copy link
Author

@silverwind ah, so should I rather use Crowdin instead of the PR?

@silverwind
Copy link
Member

PR should be fine I guess. Maybe someone with a better understanding of Crowdin can comment how a case of updated english works. Given that you're seeing english, I think it invalidated all previous translations.

@alexanderadam
Copy link
Author

@silverwind ah so @a1012112796 just wrote that I should rather use crowdin.

Also I wasn't able to find 'lines' and 'words'…

@silverwind
Copy link
Member

Doing it on crowdin is certainly better and faster as translations don't require review.

@alexanderadam
Copy link
Author

Okay, the first point is already translated (I update the issue accordingly) but which are the keys for lines and words?
It seems that there's no key for words and there's a key for lines but it isn't translated anyway.

@alexanderadam alexanderadam changed the title "closed this issue" not localized? words and lines not localized? May 11, 2020
@alexanderadam alexanderadam changed the title words and lines not localized? words and lines are not localized May 11, 2020
@zeripath
Copy link
Contributor

This is (yet another) SimpleMDE/Codemirror problem

@alexanderadam
Copy link
Author

@zeripath so is there already an open issue for it? 🤔

@silverwind
Copy link
Member

I assume this is hardcoded in SimpleMDE, but fix will come with #10729.

@stale
Copy link

stale bot commented Jul 11, 2020

This issue has been automatically marked as stale because it has not had recent activity. I am here to help clear issues left open even if solved or waiting for more insight. This issue will be closed if no further activity occurs during the next 2 weeks. If the issue is still valid just add a comment to keep it alive. Thank you for your contributions.

@stale stale bot added the issue/stale label Jul 11, 2020
@lunny lunny added modifies/translation issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented labels Jul 11, 2020
@stale stale bot removed the issue/stale label Jul 11, 2020
@silverwind
Copy link
Member

Fixed with #23876 which removes these from the default editor.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented modifies/translation outdated/theme/markdown
Projects
None yet
Development

No branches or pull requests

5 participants