Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proc/native/freebsd: verify compatiblity with current go-tip (which will become Go 1.14) #1754

Closed
aarzilli opened this issue Nov 12, 2019 · 3 comments

Comments

@aarzilli
Copy link
Member

Go 1.14 uses a new system to preempt goroutines non-cooperatively by sending a SIGURG signal to its own threads. This necessitates increased rigour in signal routing. We should verify that this doesn't expose latent bugs in the freebsd native backend before Go 1.14/Delve 1.4.0 is released.

cc @rayrapetyan

@rayrapetyan
Copy link
Contributor

Currently it fails couple:

FAIL: TestIssue411
support.go:246: enabling recording for github.com/go-delve/delve/pkg/terminal.TestIssue411
command_test.go:105: output of "break math.go:8": ""
command_test.go:106: Error executing : Location "math.go:8" ambiguous: /ara/devel/go/src/github.com/go-delve/delve/_fixtures/math.go, /home/robert/sdk/gotip/src/runtime/internal/math/math.go…

FAIL: Test1ClientServer_traceContinue
FAIL: Test1ClientServer_traceContinue2
FAIL: TestDisasm

I believe first and last one should be common fails in all envs (please confirm). I can take care of the rest two.

@aarzilli
Copy link
Member Author

aarzilli commented Dec 2, 2019

Check out #1727 for fixes for os independent fixes for 1.14.

@derekparker
Copy link
Member

I think we can close this one. @aarzilli please reopen if I'm mistaken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants