Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delve fails when encountering unterminated CUs #1579

Closed
heschi opened this issue Jun 10, 2019 · 2 comments
Closed

Delve fails when encountering unterminated CUs #1579

heschi opened this issue Jun 10, 2019 · 2 comments

Comments

@heschi
Copy link
Contributor

heschi commented Jun 10, 2019

We just upgraded Delve (commits) and got a failure report. Our copy of libc has an object file with an incomplete CU -- it lacks a terminating 0 abbrev. After one of the changes in that range, probably #1565, Delve runs off the end of the CU, proceeds to the next, and then crashes looking at the wrong CU's file table.

I'm not sure if this is a bug in our libc or what, but either way it's also a regression in Delve from our perspective. Let me know if you need more information and I can try to get it for you.

$ readelf --debug-dump=info [redacted]/lib64/crt1.o                
Contents of the .debug_info section:

  Compilation Unit @ offset 0x0:
   Length:        0x63 (32-bit)
   Version:       2
   Abbrev Offset: 0x0
   Pointer Size:  8
 <0><b>: Abbrev Number: 1 (DW_TAG_compile_unit)
    <c>   DW_AT_stmt_list   : 0x0
    <10>   DW_AT_low_pc      : 0x0
    <18>   DW_AT_high_pc     : 0x2a
    <20>   DW_AT_name        : ../sysdeps/x86_64/start.S
    <3a>   DW_AT_comp_dir    : [redacted]
    <59>   DW_AT_producer    : GNU AS 2.24
    <65>   DW_AT_language    : 32769	(MIPS assembler)
  Compilation Unit @ offset 0x67:
   Length:        0x7a (32-bit)
   Version:       4
   Abbrev Offset: 0x14
   Pointer Size:  8
[snip]

cc @hyangah

@aarzilli
Copy link
Member

I think this is a duplicate of #1572 and #1574 should fix it.

@heschi
Copy link
Contributor Author

heschi commented Jun 11, 2019

Yep, tested the patch and looks good. Sorry for the dupe.

@heschi heschi closed this as completed Jun 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants