From 8eb488f2da1f051fb82c5a2a027221623b7ff9a8 Mon Sep 17 00:00:00 2001 From: aarzilli Date: Sun, 10 Nov 2019 17:52:38 +0100 Subject: [PATCH] Makefile: disable testing lldb-server backend on linux with Go 1.14 There seems to be some incompatibility with lldb-server version 6.0.0 on linux and Go 1.14. --- scripts/make.go | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/scripts/make.go b/scripts/make.go index bdba288d8f..0aa134c7ee 100644 --- a/scripts/make.go +++ b/scripts/make.go @@ -10,6 +10,7 @@ import ( "sort" "strings" + "github.com/go-delve/delve/pkg/goversion" "github.com/spf13/cobra" ) @@ -70,7 +71,7 @@ func NewMakeCommands() *cobra.Command { Use the flags -s, -r and -b to specify which tests to run. Specifying nothing is equivalent to: go run scripts/make.go test -s all -b default - go run scripts/make.go test -s basic -b lldb # if lldb-server is installed + go run scripts/make.go test -s basic -b lldb # if lldb-server is installed and Go < 1.14 go run scripts/make.go test -s basic -b rr # if rr is installed go run scripts/make.go test -s basic -m pie # only on linux @@ -289,7 +290,7 @@ func testCmd(cmd *cobra.Command, args []string) { fmt.Println("Testing default backend") testCmdIntl("all", "", "default", "normal") - if inpath("lldb-server") { + if inpath("lldb-server") && !goversion.VersionAfterOrEqual(runtime.Version(), 1, 14) { fmt.Println("\nTesting LLDB backend") testCmdIntl("basic", "", "lldb", "normal") }