Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color theme matcher logic issue #1400

Closed
cg505 opened this issue May 7, 2018 · 2 comments
Closed

Color theme matcher logic issue #1400

cg505 opened this issue May 7, 2018 · 2 comments

Comments

@cg505
Copy link

cg505 commented May 7, 2018

Check out ColorScheme.equalColor(). Suppose we are comparing against a theme that is the same as ours, but it also has useCursorColor, useHighlightColor, useBadgeColor, or useBoldColor (and this does not). Since we only check the instance variables, we don't catch the discrepancies and so the match will appear valid.

I ran into this when tweaking some themes and it was really counter-intuitive and should be pretty straight-forward to fix.

@gnunn1 gnunn1 closed this as completed in 93feadb May 18, 2018
@gnunn1
Copy link
Owner

gnunn1 commented May 18, 2018

I have fixed this and re-worked a few things at the same time as I noticed a couple of other bugs. Please do test this out, the color code is a bit ugh and could really use a rewrite but didn't go that far this time, would appreciate some validation that I didn't break anything.

@cg505
Copy link
Author

cg505 commented May 18, 2018

Seems to be working pretty nicely. Thanks for the update!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants