You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Check out ColorScheme.equalColor(). Suppose we are comparing against a theme that is the same as ours, but it also has useCursorColor, useHighlightColor, useBadgeColor, or useBoldColor (and this does not). Since we only check the instance variables, we don't catch the discrepancies and so the match will appear valid.
I ran into this when tweaking some themes and it was really counter-intuitive and should be pretty straight-forward to fix.
The text was updated successfully, but these errors were encountered:
I have fixed this and re-worked a few things at the same time as I noticed a couple of other bugs. Please do test this out, the color code is a bit ugh and could really use a rewrite but didn't go that far this time, would appreciate some validation that I didn't break anything.
Check out ColorScheme.equalColor(). Suppose we are comparing against a theme that is the same as ours, but it also has
useCursorColor
,useHighlightColor
,useBadgeColor
, oruseBoldColor
(andthis
does not). Since we only check the instance variables, we don't catch the discrepancies and so the match will appear valid.I ran into this when tweaking some themes and it was really counter-intuitive and should be pretty straight-forward to fix.
The text was updated successfully, but these errors were encountered: