Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

At least one case where our testsuite is faulty #1863

Open
GillesDuvert opened this issue Jul 17, 2024 · 2 comments
Open

At least one case where our testsuite is faulty #1863

GillesDuvert opened this issue Jul 17, 2024 · 2 comments

Comments

@GillesDuvert
Copy link
Contributor

in #1860 there was a mistake in saverestore.cpp that made test_saverestore.pro exit with error:

% SAVE: GDL cannot yet write such large SAVE files. Try with less values. File /tmp/GDL_save_test_numeric1.sav is invalid, remove it.
% Execution halted at: TEST_SAVE_NUMERIC   119 /home/gildas/gdl/testsuite/test_save_restore.pro
%                      TEST_SAVE_RESTORE   210 /home/gildas/gdl/testsuite/test_save_restore.pro
%                      $MAIN$          

(this, when run manually).
however, the test was reported as "passed" as https://github.com/gnudatalanguage/gdl/actions/runs/9962944994/job/27527857548?pr=1860 shows.
No need to add that his kind of behaviour is very dangerous.
Help needed.

@alaingdl
Copy link
Contributor

not that simple : it is possible to put
res=EXECUTE("SAVE, [...]") everywhere then testing "res" but usually I tested deeply a change before putting in the github.

Another solution would be to test that the file is generated or not.

Not that simple to decide for a trade-off between hyper basic tests and too much tests

@GillesDuvert
Copy link
Contributor Author

I suggest replacing execute() by gdl_execute() where gdl_execute calls execute with res=execute() an exit 1 if res is not ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants