Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transfer Event To and From are Backwards. #29

Open
bh2smith opened this issue Feb 16, 2022 · 2 comments
Open

Transfer Event To and From are Backwards. #29

bh2smith opened this issue Feb 16, 2022 · 2 comments

Comments

@bh2smith
Copy link

When a user deposits GNO, the Transfer event of the LGNO token has recipient as "from" and contract as "to":

emit Transfer(msg.sender, address(this), amount);

@rmeissner
Copy link

Same applies to the event in the withdraw method

@bh2smith
Copy link
Author

bh2smith commented Feb 16, 2022

The really unfortunate thing about this issue is that even with contract upgrade, all the historical events emitted by the contract prior to upgrade will forever have these fields reversed. Might even be more of an accounting headache to fix it and also messing up all the tax accounting software.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants