Skip to content
This repository has been archived by the owner on Nov 10, 2023. It is now read-only.

Addressbook list on send funds/custom transaction does not autofocus once the entry is selected #483

Closed
Agupane opened this issue Jan 27, 2020 · 4 comments
Assignees
Labels
Bug 🐛 Something isn't working Major Needs to be fixed for immediate next public release.

Comments

@Agupane
Copy link
Contributor

Agupane commented Jan 27, 2020

No description provided.

@Agupane Agupane added the Bug 🐛 Something isn't working label Jan 27, 2020
@lukasschor lukasschor added the Major Needs to be fixed for immediate next public release. label Jan 28, 2020
@fernandomg fernandomg self-assigned this Jan 29, 2020
@pablofullana pablofullana added this to the Sprint 2 "Fuji" milestone Jan 29, 2020
@fernandomg
Copy link
Contributor

Has been solved as part of #461 changes

@francovenica
Copy link
Contributor

I've tried the PR461 and I have problems.
It says that the autofocus is not working once the entry is selected. For "Send funds" once you select the entry and start to tab the focus is on the "X" to close the modal
For the "Custom Transaction" I can't see any address to select, I've tried contract address and those won't show up either, so I can't test it for that.

@fernandomg

@fernandomg
Copy link
Contributor

we discussed this off-line, just to make this clear. The intention was to make autofocus on the address book input after clicking on a pre-selected element and opening (#461 (comment))

This has nothing to do with the tabindex property for the elements in the modal.

I think we can address that in a separate issue and close this one.

@francovenica
Copy link
Contributor

Ok, Close it

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug 🐛 Something isn't working Major Needs to be fixed for immediate next public release.
Projects
None yet
Development

No branches or pull requests

5 participants